All of lore.kernel.org
 help / color / mirror / Atom feed
From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH] syscalls/setsockopt09: Add another linux git
Date: Tue, 8 Mar 2022 10:04:47 +0000	[thread overview]
Message-ID: <62272A6D.4090204@fujitsu.com> (raw)
In-Reply-To: <YiHHa51Lekmkpp6u@pevik>

Hi Petr
>> Hi Petr
>>> Hi Xu,
>
>>>> On centos7.9ga, I still hit another crash problem because of use-after-free in
>>>> prb_retire_rx_blk_timer_expired(). Since we free it when timer expired, so this
>>>> case will crash after we print TPASS info.
>
>>> Reviewed-by: Petr Vorel<pvorel@suse.cz>
>
>>> LGTM.
>>> I tested two old kernels, the one with patch survives, the other got reboot.
>
>>> BTW funny enough the affected system manages to print "TPASS: Nothing bad
>>> happened, probably" before reboot :).
>> Yes, it crash when timer expired, so it will print TPASS before reboot.
>> Also, I try sleep 10ms, but it still print TPASS and reboot after serval
>> seconds.
>
>> I have wrote it in my commit message, so this should  be friendly for
>> user to know this situation.
>
> Sure, I didn't expect we would be able to fix this (I'm *not* voting for sleep
> 10+ s). It can just be a bit confusing when you read test logs if the framework
> does not clearly show that system got rebooted (I saw reset in dmesg but didn't
> believe it's caused by this test output due TPASS. Lesson learned :)).
Yes, it looks confused.

So, how about testing 100 times in runtest/syscall and runtest/cve like 
"cve-2021-22555 setsockopt08 -i 100" does.

ps: I tested it on old kernel and it works well.

Best Regards
Yang Xu
>
> Kind regards,
> Petr
>
>> Best Regards
>> Yang Xu
>
>>> Kind regards,
>>> Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-03-08 10:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03  8:54 [LTP] [PATCH] syscalls/setsockopt09: Add another linux git Yang Xu
2022-03-03  9:11 ` xuyang2018.jy
2022-03-03 14:04 ` Petr Vorel
2022-03-04  3:24   ` xuyang2018.jy
2022-03-04  8:01     ` Petr Vorel
2022-03-08 10:04       ` xuyang2018.jy [this message]
2022-03-08 10:44     ` Martin Doucha
2022-03-09  2:03       ` xuyang2018.jy
2022-03-09 10:51         ` Martin Doucha
2022-03-10  6:07           ` xuyang2018.jy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62272A6D.4090204@fujitsu.com \
    --to=xuyang2018.jy@fujitsu.com \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.