From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934085AbcJZQEX (ORCPT <rfc822;w@1wt.eu>);
        Wed, 26 Oct 2016 12:04:23 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:50450 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933969AbcJZQER (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 26 Oct 2016 12:04:17 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] objtool: fix rare switch jump table pattern detection
Date: Wed, 26 Oct 2016 18:03:44 +0200
Message-ID: <6240615.e5XfHPpyq8@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <20161026153408.2rifnw7bvoc5sex7@treble>
References: <cover.1476393584.git.jpoimboe@redhat.com> <3971280.DNU2zoGODW@wuerfel> <20161026153408.2rifnw7bvoc5sex7@treble>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:OeQJtHB+1urizFYBOXi55Q/pwdeePij91K+LJzTciMhAOuGfQaJ
 GXa0dJYtURbdLayXi/QFeIN7U3WRMmJxR4HKZlpEja4sfe3FslU8C54sYDs/iTYTw+CFGx4
 P/J5zoZicutv+1B6RQaIyO7h6V0xAL6tUnC5/VymQB4hW0ZLHBY2OzOIMeZmLpVifHQpwyB
 Sz++bCKmVCh7YYptt6F3Q==
X-UI-Out-Filterresults: notjunk:1;V01:K0:5BDyRN4eOn4=:kmbMkIUWa4fYzmy4oqigpO
 i3XOrnFyIlCy9XIX1e/TUL+JP/zO10nWxV9cSJ00bhMiCHh7H+aUjl0O+QFADwUELzoZJj168
 0A2pcbByM73yR/Q6m64AL0BASNyBfUvmk8uu3qR0D5SWkAZ2/hxkhAZe57EgDZXpYO276Q2pC
 pBbICV6ivLcpewqJ/6EamNm5CL6b5fnJswnM9li4rmXrCJY6SghecSlhv2iBs8JjAXvlvDP1k
 8aBhLHMCVE7om8Ysd9mJBwQan+4uY4Kt4x6uVPorGSO3KLkhV9Vtdy5wz6f44jhTkImRnq0ZK
 SOyadXfRDuu9ccJj4KzNe6J59cvUMattJgtKlF/+hjoBL2OlpzqHNo67f0v5kgBaMWE33IiEU
 dKuVROYtrCM3MgWCDK1X6lUp/ZS9KccDqRO6ddR71ce2igdhmRNZACta4Hs84d5XmdIakOfsf
 QIk5RS0g4Q5H+HSZdquTC9y0THyTEXRFIGf6C2wbEz2xv4CkFHuor1Gbd29vj/uXIYB7Q5G/C
 GX6mhireh9HYGu7GwtwiDipIutSTk2uY1OF8JVrwObSWv2qLtx43rKOaSvLaE6vzElYfl6pSH
 4YCb55oWU6+p1E4gDzc6apfs1bMJNxq2JXO0hyGY1c1pTwtftLJlHKH8DLovhGOJ/jf3w6Dc1
 jrjN58JUrK5fAnrQryKdQPXxq+AboHvlg7va4pNwkg4z3A6uMFqsfgx6T467LK/0HIG1s1yGQ
 9vmD8m8K/SemT3Dv
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, October 26, 2016 10:34:08 AM CEST Josh Poimboeuf wrote:
> The following commit:
> 
>   3732710ff6f2 ("objtool: Improve rare switch jump table pattern detection")
> 
> ... improved objtool's ability to detect gcc switch statement jump
> tables for gcc 6.  However the check to allow short jumps with the
> scanned range of instructions wasn't quite right.  The pattern detection
> should allow jumps to the indirect jump instruction itself.
> 
> This fixes the following warning:
> 
>   drivers/infiniband/sw/rxe/rxe_comp.o: warning: objtool: rxe_completer()+0x315: sibling call from callable instruction with changed frame pointer
> 
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 3732710ff6f2 ("objtool: Improve rare switch jump table pattern detection")
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>

Tested-by: Arnd Bergmann <arnd@arndb.de>

It fixes the mlx4/resource_tracker.o problem, but not the other
one for ttusb-dec/ttusb_dec.o, as you mentioned.

Do you need any more help creating a testcase for that one?

	Arnd