All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/7 v4] linux: explain why we need host-{flex, bison}
Date: Fri, 17 Aug 2018 18:06:47 +0200	[thread overview]
Message-ID: <625814ff31c1c985e01a6cf51f58b28811b3af71.1534522005.git.yann.morin.1998@free.fr> (raw)
In-Reply-To: <cover.1534522005.git.yann.morin.1998@free.fr>

The commit that added the dependency on host-{bison,flex} did
so because the pre-generated kconfig parser source files were
removed from the kernel tree, in linux-4.16.

But then, in linux-4.17, the pre-generated dtc parser source
files were in turn removed as well.

So, document the two reasons why they are needed, so we don't
accidentally remove them when we (soon) introduce the kconfig
dependencies.

(Also fix the first assignment to LINUX_DEPENDENCIES to be a
simple assignement, not an append-assignment.)

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Arnout Vandecappelle <arnout@mind.be>
---
 linux/linux.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/linux/linux.mk b/linux/linux.mk
index e0d437427d..d307970065 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -62,7 +62,13 @@ LINUX_PATCHES = $(call qstrip,$(BR2_LINUX_KERNEL_PATCH))
 LINUX_PATCH = $(filter ftp://% http://% https://%,$(LINUX_PATCHES))
 
 LINUX_INSTALL_IMAGES = YES
-LINUX_DEPENDENCIES += host-bison host-flex host-kmod
+LINUX_DEPENDENCIES = host-kmod
+
+# Starting with 4.16, the generated kconfig paser code is no longer
+# shipped with the kernel sources, so we need flex and bison.
+# Starting with 4.17, the generated dtc parser code is no longer
+# shipped with the kernel sources, so we need flex and bison.
+LINUX_DEPENDENCIES += host-bison host-flex
 
 # host tools needed for kernel compression
 ifeq ($(BR2_LINUX_KERNEL_LZ4),y)
-- 
2.14.1

  reply	other threads:[~2018-08-17 16:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-17 16:06 [Buildroot] [PATCH 0/7 v4] core/pkg-kconfig: ensure we have necessary tools to run configurators Yann E. MORIN
2018-08-17 16:06 ` Yann E. MORIN [this message]
2018-08-18 21:13   ` [Buildroot] [PATCH 1/7 v4] linux: explain why we need host-{flex, bison} Thomas Petazzoni
2018-08-17 16:06 ` [Buildroot] [PATCH 2/7 v4] support/dependencies: check for system-provided bison and flex Yann E. MORIN
2018-08-18 21:17   ` Thomas Petazzoni
2018-08-18 21:29     ` Thomas Petazzoni
2018-08-17 16:06 ` [Buildroot] [PATCH 3/7 v4] core/pkg-kconfig: allow dependencies before configurators Yann E. MORIN
2018-08-18 21:22   ` Thomas Petazzoni
2018-08-17 16:06 ` [Buildroot] [PATCH 4/7 v4] linux: kconfig may need host-{flex, bison} to build the configurators Yann E. MORIN
2018-08-17 16:06 ` [Buildroot] [PATCH 5/7 v4] linux: host-{flex, bison} only needed for DTS Yann E. MORIN
2018-08-17 16:06 ` [Buildroot] [PATCH 6/7 v4] linux: kconfig needs the toolchain Yann E. MORIN
2018-08-17 16:06 ` [Buildroot] [PATCH 7/7 v4] boot/uboot: needs host-{flex,bison} Yann E. MORIN
2018-09-13 19:04   ` Thomas Petazzoni
2018-08-20 14:10 ` [Buildroot] [PATCH 0/7 v4] core/pkg-kconfig: ensure we have necessary tools to run configurators Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=625814ff31c1c985e01a6cf51f58b28811b3af71.1534522005.git.yann.morin.1998@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.