From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Tian, Kevin" <kevin.tian@intel.com>
Subject: RE: [PATCH 18/31] nVMX: Implement VMLAUNCH and VMRESUME
Date: Thu, 26 May 2011 08:42:56 +0800
Message-ID: <625BA99ED14B2D499DC4E29D8138F1505C9BFA3C0B@shsmsx502.ccr.corp.intel.com>
References: <1305575004-nyh@il.ibm.com>
 <201105161953.p4GJr8Jo001858@rice.haifa.ibm.com>
 <625BA99ED14B2D499DC4E29D8138F1505C9BFA39F8@shsmsx502.ccr.corp.intel.com>
 <20110525132623.GE16418@fermat.math.technion.ac.il>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"gleb@redhat.com" <gleb@redhat.com>,
	"avi@redhat.com" <avi@redhat.com>
To: Nadav Har'El <nyh@math.technion.ac.il>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mga01.intel.com ([192.55.52.88]:26155 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752762Ab1EZAnB convert rfc822-to-8bit (ORCPT
	<rfc822;kvm@vger.kernel.org>); Wed, 25 May 2011 20:43:01 -0400
In-Reply-To: <20110525132623.GE16418@fermat.math.technion.ac.il>
Content-Language: en-US
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

> From: Nadav Har'El [mailto:nyh@math.technion.ac.il]
> Sent: Wednesday, May 25, 2011 9:26 PM
> 
> On Wed, May 25, 2011, Tian, Kevin wrote about "RE: [PATCH 18/31] nVMX:
> Implement VMLAUNCH and VMRESUME":
> > > +	if (!saved_vmcs02)
> > > +		return -ENOMEM;
> > > +
> >
> > we shouldn't return error after the guest mode is updated. Or else move
> > enter_guest_mode to a later place...
> 
> I moved things around, but I don't think it matters anyway: If we return
> ENOMEM, the KVM ioctl fails, and the whole L1 guest dies - it doesn't matter
> at this point if we were in the middle of updating its state.
> 

yes but the code this way is cleaner that guest mode is set only when next
we'll certainly enter L2.

Thanks
Kevin