From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56681C3DA7D for ; Thu, 5 Jan 2023 09:47:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 25AA48559E; Thu, 5 Jan 2023 10:47:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=theobroma-systems.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=theobroma-systems.com header.i=@theobroma-systems.com header.b="RpSWmu+Y"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8B731855AD; Thu, 5 Jan 2023 10:47:16 +0100 (CET) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2062.outbound.protection.outlook.com [40.107.104.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D8E8780EAF for ; Thu, 5 Jan 2023 10:47:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=theobroma-systems.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=quentin.schulz@theobroma-systems.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PEv0Ewv+lsl/bZjn/4q/3357aYizVChKy2BW1KsXB+Mo78ZhpW0pKEIJEtoWHMw0Xim3c55OC0eptaOs10l9aBu1NcM/fy1MF+hZVLeygp1HORy0vSvC2m5SjdPZiF8enjfEU+1vvh+CKpbKzego/cyklo+YOD0VrJshalSymGmaeGUvojG/3NkuMUyXz+E74iaPYho+HmKsU5FcYl5HAFpW6+RLn92CZpIsaZunCQd83Jzv749T+Ds/ViDzT7swKgSWqb0iBkJgdCG+O2jilyv6J6vhz1s8lN3WYE3Kni48DM2ZSeOuiJ8w8jUH+c/eC00JBncPVVf7s7a/kHBZEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UbUbpo4D1q8o/sXRmSCZ0pmgfm/YMwJmAklx1sJJuqY=; b=gqeWJwdkSZ6TsPuQ6cokpNzyrcj8pSHQYMYRln22YqxC3YTtZYl8BkEzKp49GIpeBt6mhHr6pw6U5kPtM7ytc/US3wxQQQNUZicqpuEL8P66qvC25XY/Crm8WJFYXZNAawyQjHU42kyk9wocXVMg5KFOKXgs4yo7G+wQWjXm6Ll5jhtWnJrfkflwYyFXt+D5qnNW66B3zgb5ccyZ8lhQLQvl3cvCaOtBF4H0UVWvOHYVrcGVpoWBSShfgr+SQ4xRFrcRlAuJF9ZU48hc0bjZzp4AxG7B2siUAvd27N82wRKm1d3NB6eE/lLKxdBv9o8a2lixAdN0ecnYsum3fDvDag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=theobroma-systems.com; dmarc=pass action=none header.from=theobroma-systems.com; dkim=pass header.d=theobroma-systems.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=theobroma-systems.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UbUbpo4D1q8o/sXRmSCZ0pmgfm/YMwJmAklx1sJJuqY=; b=RpSWmu+YATy5Mr5LLcUcV0ELMza9zIl3xEtB5uLJZ/Zj9xd+j/MDjrn3iKoum6poLcY27t8BS5rriDma7l8gEkETMYDCU73qPJfIt6j8AmDIhwijLnY+jLfwmY2oW0kSn/adJI9zop6D8pdpgqIv3BwvWnpoSsrg+GfDqG0CJXj++avoGjPa2pyIBAfmQCgJUXlBJ5kaZM/nksOJ3FxcqaLNPzU9yD27WIkgW7u81AvPNFG4KSVEIL6tyDoK0lpPkKDWnH3PIYVqafu0ooIhZEH5JWP0rSIo4atWJVWY5KK92vV9O+aV0cWz1WDqbWIx5AlCa3iPlXYLBnPKaTGhwg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=theobroma-systems.com; Received: from DU2PR04MB8536.eurprd04.prod.outlook.com (2603:10a6:10:2d7::10) by AM9PR04MB7667.eurprd04.prod.outlook.com (2603:10a6:20b:2d5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 09:47:11 +0000 Received: from DU2PR04MB8536.eurprd04.prod.outlook.com ([fe80::9ebd:cd48:9396:76f6]) by DU2PR04MB8536.eurprd04.prod.outlook.com ([fe80::9ebd:cd48:9396:76f6%6]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 09:47:10 +0000 Message-ID: <625a6222-8a46-cbb4-74e5-d077d460b712@theobroma-systems.com> Date: Thu, 5 Jan 2023 10:47:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v8 09/13] rockchip: Use multiple-images for rk3399 Content-Language: en-US To: Simon Glass Cc: U-Boot Mailing List , Tom Rini , huang lin , Jeffy Chen , Kever Yang , Ivan Mikhaylov , Roger Quadros , Philippe Reynes , Alper Nebi Yasak , Jerome Forissier , Peter Geis References: <20221221230726.638740-1-sjg@chromium.org> <20221221230726.638740-10-sjg@chromium.org> From: Quentin Schulz In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1PR0902CA0029.eurprd09.prod.outlook.com (2603:10a6:802:1::18) To DU2PR04MB8536.eurprd04.prod.outlook.com (2603:10a6:10:2d7::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8536:EE_|AM9PR04MB7667:EE_ X-MS-Office365-Filtering-Correlation-Id: 895633ed-353a-471d-89c9-08daef01d084 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OcDJn5a3iq6vuzGx7lewWlU4VFowXvW4OUFsUhHxuaf0RR1bi4ziPAJS1Eqsl+kFKdJ06ISO1UfX2csPloyV9l1saS/IPwcXDybrbSTtprw50O/KVTpHXFu1RmV5vSHxXCK+wQxrn4rSC18B0xZ3o7n8v9KWJdbGoDygcalNZrnkM4MwP+aeC733NPU5eVfosiQ7t5UlYERcfp5/lNkAcq86f1QKJD/hZS2gM26QzW/I6Bxd+iBH43lg2GeVnRa8/j2eZAm9r39/hUoU3PoOX1NhvMxn0CMjVZvOtpzIyL5CcphZWsknQ9+bD0BAck32nwgZO/0lbc73DY0yi+tElmUoKFk+blyMXTCYbsR2W8Hx0T9+yTKq7JbpTeMfjmKATXMOmmjJdC7casS0OuNfNjG2uzZG5MblP6BjbneD6g94tIpSeY9fRUaXxxlYwPBE++xfVrfc/J9rsz4XWeVKVjOVzmwTq4v9ZtrcRHVQggCvgnb64T2SvOzrfyI0rEFX+slrYIcxmu3kwz1Z2pIrFR89UpAVNAjZ9g9OAVI58rYYN2CFLxzVLF+6oLMUf0FQQL4DfMwUwuhoNdctyfjtSO7yGz89kQO5kC4bN0P8IONBQ7b9A2mRQKTTJ1DTJajva4+gcMEi1nWQptDt3iThO5LRt0zohoHOscl42K+8t4JG26dSTQaz5oly5Z+54S3C2VgyEIP2vJ+6XfedFY0GmAVG/LoWwEBeymSHVNlZxMg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8536.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(376002)(136003)(396003)(39850400004)(346002)(451199015)(66946007)(316002)(6916009)(7416002)(31686004)(186003)(6506007)(6512007)(53546011)(4326008)(2906002)(54906003)(5660300002)(44832011)(478600001)(6666004)(41300700001)(6486002)(31696002)(86362001)(83380400001)(2616005)(66476007)(38100700002)(8676002)(36756003)(66556008)(8936002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2p1S0hKSS8rem1HeEFlRzZQQnlHSUlGWFVJaE5jdCtQMHE5dWF6NzVZcXZi?= =?utf-8?B?M2hwUjN4SFhpbE9MRUQ1QzdlMnFnM24xSnBOa1k3MlpjZlJmYjZwTnlyWTRN?= =?utf-8?B?aFBPUGNNeHdSZkFidGYrdkp1SHpxTzFaYldFZmpDYjVaQlpwSmdqSEliMWM0?= =?utf-8?B?Vy9TZHp6SmNwSUxON05wbys4MHNWY3BVbmlaU1hhNldtN042bkN4QTc1ZnVy?= =?utf-8?B?dkZEK0pxWFJhM3BCdEpXSlZLc3FxelF1b1BGdm1PcEFKdlFhS0plelBvVzVw?= =?utf-8?B?OVZvSE9oRlBjWm92K0szTExENHVqK1FzYzNXKzNOSXc2b1I5Ni9DY2hkLytn?= =?utf-8?B?UHpPTDdhRG9KRUZ4UHFxd1N6T2ZpRTVVRFJrTEdEaURKeXc4ZXlSRExKaEZW?= =?utf-8?B?UEFsTjNWVW90cThzdGRxcGtVcW1aZnBqS1h4QnRzUG5BdGMzTlgyOXBnb28z?= =?utf-8?B?UTJoN2xuSFNIWG1aL1U4QndnQ2ZGdGpFbXY1MUY4OFF2clg3VUh2MFFYcWxl?= =?utf-8?B?czBaZldYcjk0L2dmbk14T0tBL1RjKzZzcFY4dlNmb2lwNGNKSEMzOHJvTW5m?= =?utf-8?B?Z3ZOdGQrT3F1cFI5YVcwWVpUUWJucUZGY1N3cnE4dU83b2Jla0JpTGRYYVVE?= =?utf-8?B?WWVWVGNaM2ltSVFkK0VHR1FLZmFIOG41aDBjQkhkTkp1R0hHa0psbUxUaHVU?= =?utf-8?B?di9HdzJkRTVock8vLzQ4UEVmTGYyTGw2bnRycWtNR0V0TzVSdzN3QlVjWjlZ?= =?utf-8?B?V1oyeUg0RndaSEJEaFpoVmx6cm5UR1dFNXpKa2FLa3E3b1lHREQ0VmJnc2pY?= =?utf-8?B?TjUvSFdiclpFVDFrTkprc3pDNnVyd3NoNG50bEZwSkoxd3IxSy80aENhSkVx?= =?utf-8?B?K0JjN3FNWGpUL3FzOW1IZE9LbVFjTFVXTURjNXRmNE9CaGw3RG10c1NIV3hu?= =?utf-8?B?d2VQZVUxMmZzVmxsYS9ReFhPVU1UV3hmc3RLVVpJOVlwVXVEVW9FM1o0NHNC?= =?utf-8?B?RUZ5UjVvalNtaEJCRWo0OENwWDlhVTA0VjhkclB0UVdsSDc1WDRFcVh4ZHRD?= =?utf-8?B?Z2IvSFdacWk0NzIxcDRhdnYva0hsaVJpc0s0alVrYmVVamVsZlZXTFV6TGdD?= =?utf-8?B?SWNlZUtHc0lwSUI1dWw0Qy9CWjd6a3hEQzh4MGpKR3I2ZVNiaWcrZE1QMDVO?= =?utf-8?B?QWdJVXBFYmdaMDRUdElXL3JENWhtbVpIUmlTMUhydkVCMnc2dnFwSFN4Wjha?= =?utf-8?B?WE01em1kcUN4QXF0K2phVzZSZk83UFpXZzZLdDNLbkQ5WHpncFJId3NyV1Iw?= =?utf-8?B?UXN5NGhYazBNbFFqNkZEckorYTRic1Jtby83MmNHbTFuODNCOWxhYjZYZVBa?= =?utf-8?B?Zm5WZkc3a0d3QUZPOWN0aGZENnVlYm9NWUR5azlXMzRyYjk4M2VNSXpwMi8v?= =?utf-8?B?MjhBcHVnQTVRMjlkenN2dmZldm4rTmJJM01OdUpEajZGTjNDd1hBREFLQ3ZN?= =?utf-8?B?NGNOMkpIZ0FCalZiTXRvZzVEN1FRVU1laVlHbHA4SFJxOE5yamlENFljNWNL?= =?utf-8?B?L3UxTjB3MFRjaTFWNy9NVkw5Y0htT1dvTHlVMUNIOU9OZzByekxpSWlOeFZC?= =?utf-8?B?V05ZT0l0RXNYRHZpQjdBVjBJSW9aRy9CdDBqOWZJMDFyQVlwZDU1RkNpMzg5?= =?utf-8?B?U0REQ1lnZFptUFFRbFVxUXBabHhnbHlxaFFkeFUxZEUrTjdPZXNudDVselRM?= =?utf-8?B?S0crd1BkTzlUc2xMN0dJQ1dZb1JRa094TTFBRElqOVpxNlpkR1YwdTFyOGd1?= =?utf-8?B?QzlYQk4wOEZJTmxPTmk3Zlo1N25URk0wWFkxWjdUdGptRTFkaWxjMzl2SjV0?= =?utf-8?B?RTFWUHhDbmNIdFc0Vm8vRDl4ZTlXdlNqelpjTk9IRzdNYjl0SlcwS2lsRkx1?= =?utf-8?B?MUVpd21GMldIRm1oNWNsMjgrRHFkSUJCKzdXUzJocWxCanNNamVZOUpHNkxy?= =?utf-8?B?SHZLUFFEa3YzZmlPUWtzdDMzWjFRZkFDU1llMEJDZnFxZ2d6MmZ5bXZ1WHdn?= =?utf-8?B?NCt2VzdYempRalpjZWhGRFcwUWJSclphS0Z0S3ErZjI0R24renB6SXk2Ykh0?= =?utf-8?B?eEFFWDJZQTJSWFRucVR2NExnUUo0U0xFRDJPSXRlVUpYRzVwbXBmMGdlQjRT?= =?utf-8?B?MWZEaDJZdmRuVm9ZVHgzRmNsTXJCVWZmR1RNU0pMWDNPc0ZFNVA3QmRLakZ0?= =?utf-8?B?TkNEUndSKzNWdzAxK0p6WS9HVGp3PT0=?= X-OriginatorOrg: theobroma-systems.com X-MS-Exchange-CrossTenant-Network-Message-Id: 895633ed-353a-471d-89c9-08daef01d084 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8536.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 09:47:09.9948 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z21b7naZSgNjk1eL1wy5jNfYA+xagWRj/DhFNUrsFQS9nWmgXLH+L7O7zvH8FEQWOF5iap8vCWAobr69mmCKgVA1mKy94ObegVVOdWydpWKrdSGGhkgElkI8ZDoO/ZYR X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7667 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On 1/4/23 21:01, Simon Glass wrote: > Hi Quentin, > > On Mon, 2 Jan 2023 at 09:42, Quentin Schulz > wrote: >> >> Hi Simon, >> >> On 12/22/22 00:07, Simon Glass wrote: >>> Enable multiple-images so we can generate more than one image. Also >>> add a comment for the end of the #if block. >>> >>> Signed-off-by: Simon Glass >>> --- >>> >>> (no changes since v5) >>> >>> Changes in v5: >>> - Rename from 'Include binman script in 64-bit boards' >>> - Drop duplicate #include in rk3368-u-boot.dtsi >>> - Keep the name as fit for puma >>> - Drop redundant check for CONFIG_ROCKCHIP_SPI_IMAGE >>> - Drop imply of BINMAN in Kconfig (rely on ARCH_ROCKCHIP instead) >>> >>> arch/arm/dts/rk3399-u-boot.dtsi | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/dts/rk3399-u-boot.dtsi b/arch/arm/dts/rk3399-u-boot.dtsi >>> index 3c1a15fe51b..85a4f472d5d 100644 >>> --- a/arch/arm/dts/rk3399-u-boot.dtsi >>> +++ b/arch/arm/dts/rk3399-u-boot.dtsi >>> @@ -62,6 +62,7 @@ >>> >>> #if defined(CONFIG_ROCKCHIP_SPI_IMAGE) && defined(CONFIG_HAS_ROM) >>> &binman { >>> + multiple-images; >>> rom { >>> filename = "u-boot.rom"; >>> size = <0x400000>; >>> @@ -82,7 +83,7 @@ >>> }; >>> }; >>> }; >>> -#endif >>> +#endif /* CONFIG_ROCKCHIP_SPI_IMAGE */ >> >> && CONFIG_HAS_ROM >> >> On a different topic, I'm a bit confused by this u-boot.rom binary. is >> it not just for Chromebooks? We now have u-boot-rockchip-spi.bin for SPI >> images but they are different (same as u-boot-rockchip.bin, just >> formatted in a way it can be flashed on a SPI flash). > > The .rom is for SPI flash, not just Chromebooks. Perhaps we should > unify the two of them? > I was under the impression that this .rom was mostly used for Chromebooks which is the reason why I didn't change any of it when adding support for u-boot-rockchip-spi.bin back then since the images are different (-spi has the u-boot fit instead of legacy, -spi has support for tpl while .rom only has support for SPL). I'm all for unifying them if we can find something that does not make the ifdef situation in rockchip-u-boot.dtsi more dire :) HAS_ROM is enabled on: TARGET_CHROMEBOOK_JERRY TARGET_EVB_RK3288 TARGET_CHROMEBOOK_BOB TARGET_CHROMEBOOK_KEVIN so this binman entry will only be used for the last two (the first two are handled in arch/arm/dts/rk3288-u-boot.dtsi, but with the same content as in arch/arm/dts/rk3399-u-boot.dtsi). Hence why I thought it was Chromebook related :) Are there any requirements for those devices that make them require something different than current u-boot-rockchip-spi.bin? Cheers, Quentin