From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC7C5C4741F for ; Mon, 28 Sep 2020 11:55:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A73D12074A for ; Mon, 28 Sep 2020 11:55:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726658AbgI1Lzy (ORCPT ); Mon, 28 Sep 2020 07:55:54 -0400 Received: from foss.arm.com ([217.140.110.172]:50226 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726600AbgI1Lzy (ORCPT ); Mon, 28 Sep 2020 07:55:54 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7F71231B; Mon, 28 Sep 2020 04:55:53 -0700 (PDT) Received: from [192.168.178.2] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9F3EE3F6CF; Mon, 28 Sep 2020 04:55:51 -0700 (PDT) Subject: Re: [PATCH 3/3] arm64: rebuild sched domains on invariance status changes To: Quentin Perret , Ionela Voinescu Cc: mingo@redhat.com, peterz@infradead.org, vincent.guittot@linaro.org, catalin.marinas@arm.com, will@kernel.org, rjw@rjwysocki.net, viresh.kumar@linaro.org, valentin.schneider@arm.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20200924123937.20938-1-ionela.voinescu@arm.com> <20200924123937.20938-4-ionela.voinescu@arm.com> <20200924133925.GC3920949@google.com> <20200924161002.GC17927@arm.com> <20200925135900.GA11648@google.com> From: Dietmar Eggemann Message-ID: <626062da-1d0e-3095-dd6f-f909a60a7de3@arm.com> Date: Mon, 28 Sep 2020 13:55:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200925135900.GA11648@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/09/2020 15:59, Quentin Perret wrote: > Hey Ionela, > > On Thursday 24 Sep 2020 at 17:10:02 (+0100), Ionela Voinescu wrote: >> I'm not sure what is a good way of fixing this.. I could add more info >> to the warning to suggest it might be temporary ("Disabling EAS: >> frequency-invariant load tracking currently not supported"). For further >> debugging there are the additional prints guarded by sched_debug(). >> >> I'll look over the code some more to see if other ideas pop out. Any >> suggestions are appreciated. > > Right, I'm not seeing anything perfect here, but I think I'd be > personally happy with this message being entirely guarded by > sched_debug(), like we do for asym CPU capacities for instance. > > It's not easy to see if EAS has started at all w/o sched debug anyway, > so I expect folks who need it to enable the debug stuff during > bring-up. With a descriptive enough warn message, that should be just > fine. But that's my 2p, so I'm happy to hear if others disagree. Are you discussing a scenario where the system doesn't have FI via CPUfreq but only via AMU? And then we would get the pr_warn "rd %*pbl: Disabling EAS: frequency-invariant load tracking not supported" in (1)-(3)? (1) initial sd build (2) update_topology_flags_workfn() (3) rebuild_sched_domains_energy() (4) init_amu_fie() Today (e.g. on Juno( we start EAS within (1) root@juno:~# dmesg | grep "build_perf_domains\|EAS" [ 3.491304] *** build_perf_domains: rd 0-5 [ 3.574226] sched_energy_set: starting EAS <--- !!! [ 3.847584] *** build_perf_domains: rd 0-5 [ 3.928227] *** build_perf_domains: rd 0-5 And on a future AMU FI only system it would look like: Disabling EAS: frequency-invariant load tracking not supported" Disabling EAS: frequency-invariant load tracking not supported" Disabling EAS: frequency-invariant load tracking not supported" sched_energy_set: starting EAS I guess it's a good idea to put all those warnings which indicate why EAS can't be started under sched_debug(). The warning "rd %*pbl: CPUs do not have asymmetric capacities" already is. This one is actually very similar to the FI related one, since 'asymmetric capacities' could only exist starting with (2) (big.LITTLE based entirely on CPUfreq diffs) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE19FC2D0A8 for ; Mon, 28 Sep 2020 11:57:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 376622073A for ; Mon, 28 Sep 2020 11:57:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k3jmTxrN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 376622073A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HkM4IK8awO2wVPv07JYiZ6bDWouQYIErn/3ly9upHns=; b=k3jmTxrNY8fPYlr/R33CQek6D vzJshrP4zYPgoVhjfDaO7we6X1f99FE06C6VxaepBKQMRBD0jrs5DCEnWuk45w1CFUbrkshfnwPt+ NguFVsS/fF/VOr6W+DbMrvWtm5rR2Lv86CeLfL6Svrc5CHGXuI52BEUESvemNSKQ/LbLg9XQ6qhXP iCt9+FLXJ9VvRKkAtyAnBwWFzaWgsxwgnpqLELVpNhKFNQJk+UHk2m+Dtt+i85IpYjAA3KhB06G6f Sji3ogdLByZq2FLX6Ymf0qPzvH7Q0YyGbAq0Sot0uTVzCxnD4WkRshlA7KHVO+kK+2FuQ+DdxrTsh H+7S4Lpaw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMrl7-0006OZ-Tj; Mon, 28 Sep 2020 11:55:57 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMrl5-0006NW-Eq for linux-arm-kernel@lists.infradead.org; Mon, 28 Sep 2020 11:55:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7F71231B; Mon, 28 Sep 2020 04:55:53 -0700 (PDT) Received: from [192.168.178.2] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9F3EE3F6CF; Mon, 28 Sep 2020 04:55:51 -0700 (PDT) Subject: Re: [PATCH 3/3] arm64: rebuild sched domains on invariance status changes To: Quentin Perret , Ionela Voinescu References: <20200924123937.20938-1-ionela.voinescu@arm.com> <20200924123937.20938-4-ionela.voinescu@arm.com> <20200924133925.GC3920949@google.com> <20200924161002.GC17927@arm.com> <20200925135900.GA11648@google.com> From: Dietmar Eggemann Message-ID: <626062da-1d0e-3095-dd6f-f909a60a7de3@arm.com> Date: Mon, 28 Sep 2020 13:55:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200925135900.GA11648@google.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200928_075555_557443_032FB35D X-CRM114-Status: GOOD ( 19.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vincent.guittot@linaro.org, linux-pm@vger.kernel.org, peterz@infradead.org, catalin.marinas@arm.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, mingo@redhat.com, viresh.kumar@linaro.org, will@kernel.org, valentin.schneider@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25/09/2020 15:59, Quentin Perret wrote: > Hey Ionela, > > On Thursday 24 Sep 2020 at 17:10:02 (+0100), Ionela Voinescu wrote: >> I'm not sure what is a good way of fixing this.. I could add more info >> to the warning to suggest it might be temporary ("Disabling EAS: >> frequency-invariant load tracking currently not supported"). For further >> debugging there are the additional prints guarded by sched_debug(). >> >> I'll look over the code some more to see if other ideas pop out. Any >> suggestions are appreciated. > > Right, I'm not seeing anything perfect here, but I think I'd be > personally happy with this message being entirely guarded by > sched_debug(), like we do for asym CPU capacities for instance. > > It's not easy to see if EAS has started at all w/o sched debug anyway, > so I expect folks who need it to enable the debug stuff during > bring-up. With a descriptive enough warn message, that should be just > fine. But that's my 2p, so I'm happy to hear if others disagree. Are you discussing a scenario where the system doesn't have FI via CPUfreq but only via AMU? And then we would get the pr_warn "rd %*pbl: Disabling EAS: frequency-invariant load tracking not supported" in (1)-(3)? (1) initial sd build (2) update_topology_flags_workfn() (3) rebuild_sched_domains_energy() (4) init_amu_fie() Today (e.g. on Juno( we start EAS within (1) root@juno:~# dmesg | grep "build_perf_domains\|EAS" [ 3.491304] *** build_perf_domains: rd 0-5 [ 3.574226] sched_energy_set: starting EAS <--- !!! [ 3.847584] *** build_perf_domains: rd 0-5 [ 3.928227] *** build_perf_domains: rd 0-5 And on a future AMU FI only system it would look like: Disabling EAS: frequency-invariant load tracking not supported" Disabling EAS: frequency-invariant load tracking not supported" Disabling EAS: frequency-invariant load tracking not supported" sched_energy_set: starting EAS I guess it's a good idea to put all those warnings which indicate why EAS can't be started under sched_debug(). The warning "rd %*pbl: CPUs do not have asymmetric capacities" already is. This one is actually very similar to the FI related one, since 'asymmetric capacities' could only exist starting with (2) (big.LITTLE based entirely on CPUfreq diffs) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel