Re: [PATCH 04/18] drm/vc4: txp: Properly set the possible_crtcs mask

From: Thomas Zimmermann <tzimmermann@suse.de>
To: Maxime Ripard <maxime@cerno.tech>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Jonas Karlman <jonas@kwiboo.se>
Cc: Tim Gover <tim.gover@raspberrypi.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	dri-devel@lists.freedesktop.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	Phil Elwell <phil@raspberrypi.com>
Subject: Re: [PATCH 04/18] drm/vc4: txp: Properly set the possible_crtcs mask
Date: Fri, 9 Apr 2021 10:11:07 +0200	[thread overview]
Message-ID: <627b8c9e-8035-2f44-7c30-f2442b519588@suse.de> (raw)
In-Reply-To: <20210317154352.732095-5-maxime@cerno.tech>


[-- Attachment #1.1.1: Type: text/plain, Size: 1245 bytes --]


Am 17.03.21 um 16:43 schrieb Maxime Ripard:
> The current code does a binary or on the possible_crtcs variable of the
> TXP encoder, while we want to set it to that value instead.
> 
> Fixes: 39fcb2808376 ("drm/vc4: txp: Turn the TXP into a CRTC of its own")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>

Cc: <stable@vger.kernel.org> # v5.9+

> ---
>   drivers/gpu/drm/vc4/vc4_txp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c
> index c0122d83b651..2fc7f4b5fa09 100644
> --- a/drivers/gpu/drm/vc4/vc4_txp.c
> +++ b/drivers/gpu/drm/vc4/vc4_txp.c
> @@ -507,7 +507,7 @@ static int vc4_txp_bind(struct device *dev, struct device *master, void *data)
>   		return ret;
>   
>   	encoder = &txp->connector.encoder;
> -	encoder->possible_crtcs |= drm_crtc_mask(crtc);
> +	encoder->possible_crtcs = drm_crtc_mask(crtc);
>   
>   	ret = devm_request_irq(dev, irq, vc4_txp_interrupt, 0,
>   			       dev_name(dev), txp);
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel