From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v6 3/3] bonding: free queue memory in stop
	function
Date: Mon, 27 Jul 2015 11:55:35 +0200
Message-ID: <6288420.ey92DFMaNu@xps13>
References: <1437491784-26676-4-git-send-email-bernard.iremonger@intel.com>
 <4617847.gsgatBVqCY@xps13>
 <8CEF83825BEC744B83065625E567D7C219F34510@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
 [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id CC19CC546
 for <dev@dpdk.org>; Mon, 27 Jul 2015 11:56:51 +0200 (CEST)
Received: by wibxm9 with SMTP id xm9so104576147wib.0
 for <dev@dpdk.org>; Mon, 27 Jul 2015 02:56:51 -0700 (PDT)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C219F34510@IRSMSX108.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-07-27 08:31, Iremonger, Bernard:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2015-07-21 16:16, Bernard Iremonger:
> > > add function bond_ethdev_free_queues() and call from the
> > bond_ethdev_stop() function.
> > 
> > Other drivers free their queues when closing.
> > Why is it done in stop() for bonding?
> 
> Hi Thomas,
> 
> The close() function  is empty in bonding so I decided to free the queues in the stop() function which is implemented.
> The stop() function is called before the close() function, so the effect is the same.

No, the effect is not the same. We can call stop() without close()
and then re-start the port.

> It would be better to free the queues in the close() function, I will move it there.

Yes please.