All of lore.kernel.org
 help / color / mirror / Atom feed
From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: the question about ext4 noacl mount option
Date: Tue, 31 May 2022 15:03:57 +0000	[thread overview]
Message-ID: <62963CA2.9040509@fujitsu.com> (raw)
In-Reply-To: <YpYqhq214oofeQAA@mit.edu>

on 2022/5/31 22:47, Theodore Ts'o wrote:
> On Fri, Apr 15, 2022 at 03:41:32AM +0000, xuyang2018.jy@fujitsu.com wrote:
>> Hi Teo
>>
>> When I use mount option noacl on 5.18-rc2, I got the following warning
>>
>> [  179.441511] EXT4-fs: Mount option "noacl" will be removed by 3.5
>>                 Contact linux-ext4@vger.kernel.org if you think we should
>> keep it.
>
> I'm curious... is there a reason why you use noacl?

> That is, if we
> made the noacl mount option a no-op (that is, it wouldn't disable
> Posix ACL's), would it make a difference for your use case?

I don't have use case for this and I use noacl when I wrote a xfstests 
case[1] to verify setgid whether works correctly for my kernel patchset 
that move setgid stripping code into vfs[2].

noacl will affect setgid stripping logic.

The S_ISGID stripping logic is entangled with umask stripping.

If a filesystem doesn't support or enable POSIX ACLs then umask
stripping is done directly in the vfs before calling into the
filesystem.

If the filesystem does support POSIX ACLs then unmask stripping may be
done in the filesystem itself when calling posix_acl_create().

[1]https://patchwork.kernel.org/project/fstests/patch/1653062664-2125-1-git-send-email-xuyang2018.jy@fujitsu.com/
[2]https://patchwork.kernel.org/project/linux-fsdevel/list/?series=643645

>
>        	      	       	    - Ted

      reply	other threads:[~2022-05-31 15:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-15  3:41 the question about ext4 noacl mount option xuyang2018.jy
2022-05-31 10:40 ` Jan Kara
2022-05-31 14:47 ` Theodore Ts'o
2022-05-31 15:03   ` xuyang2018.jy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62963CA2.9040509@fujitsu.com \
    --to=xuyang2018.jy@fujitsu.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.