All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Anton Ivanov <anton.ivanov@kot-begemot.co.uk>
Cc: linux-um@lists.infradead.org
Subject: Re: 4.20-rc1 looks broken for UML
Date: Tue, 06 Nov 2018 20:56:04 +0100	[thread overview]
Message-ID: <6298063.A9SzxUBULK@blindfold> (raw)
In-Reply-To: <e5c51b9c-97d5-ae12-b06f-303f0469d46b@kot-begemot.co.uk>

Anton,

Am Dienstag, 6. November 2018, 20:09:44 CET schrieb Anton Ivanov:
> 
> On 11/6/18 5:25 PM, Anton Ivanov wrote:
> > On 06/11/2018 17:04, Richard Weinberger wrote:
> >> Am Dienstag, 6. November 2018, 16:00:59 CET schrieb Anton Ivanov:
> >>> On 11/5/18 10:07 PM, Richard Weinberger wrote:
> >>>> Anton,
> >>>>
> >>>> Am Montag, 5. November 2018, 16:22:36 CET schrieb Anton Ivanov:
> >>>>> This looks like something specific to ttys - the io there gets
> >>>>> corruption and/or hangs.
> >>>>>
> >>>>> I cannot reproduce it when I ssh in.
> >>>>>
> >>>>> It does not look like it is the new write IRQ bugfix - that works 
> >>>>> fine
> >>>>> over 4.19.
> >>>>>
> >>>>> Still debugging...
> >>>> Hmm, I don't see this with my Debian userspace.
> >>>> What exactly is your setup/config?
> >>>
> >>> Gotcha.
> >>>
> >>> 8ebfe885c65ec82a0b1e955cf99ed62664e84414 is the guilty party.
> >>>
> >>> With it, I get tty corruption on UML. Any attempt to push a large 
> >>> amount
> >>> of data via the console results in spurious echoes or even a hang.
> >>>
> >>> Reverting it fixes things.
> >> Really?!
> >> This is "TTY: sn_console: Replace spin_is_locked() with spin_trylock()".
> >> sn_console is "SGI Altix L1 serial console"...
> >
> > OK. Then I am losing my mind.
> 
> Not fully. I stand by my earlier statement - 4.20-rc1 is not quite right.
> 
> The combination of debug options I had enabled hanged UML on boot with 
> 4.20-rc1 made it hang on boot or produce the aforementioned corruption 
> on tty later.
> 
> Turning all debug off gives me a kernel which boots. However, it fails 
> later at some point either on networking or or on disk.
> 
> The same images boot cleanly with 4.14 to 4.19 +/- various fixes.
> 
> I am going to rebuild everything from scratch including new clean Debian 
> images tomorrow and start digging again.

I did a test with your .config and indeed, UML hangs.

The offending commit is this one:
commit ecb0a83e3198f2c1142901687afacbc73602a13b
Author: Christoph Hellwig <hch@lst.de>
Date:   Thu Oct 18 22:55:03 2018 +0200

    ubd: remove use of blk_rq_map_sg
    
    There is no good reason to create a scatterlist in the ubd driver,
    it can just iterate the request directly.
    
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    [rw: Folded in improvements as discussed with hch and jens]
    Signed-off-by: Richard Weinberger <richard@nod.at>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>

Please check your root filesystem, it is possible that the broken block
driver broke it and you see further problems.
Let me figure what in your .config triggers the issue.

Thanks,
//richard



_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um


  reply	other threads:[~2018-11-06 19:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05 13:13 4.20-rc1 looks broken for UML Anton Ivanov
2018-11-05 15:22 ` Anton Ivanov
2018-11-05 22:07   ` Richard Weinberger
2018-11-06  7:03     ` Anton Ivanov
2018-11-06 15:00     ` Anton Ivanov
2018-11-06 15:07       ` Anton Ivanov
2018-11-06 18:00         ` Lance Roy
2018-11-06 18:12           ` Anton Ivanov
2018-11-06 17:04       ` Richard Weinberger
2018-11-06 17:25         ` Anton Ivanov
2018-11-06 19:09           ` Anton Ivanov
2018-11-06 19:56             ` Richard Weinberger [this message]
2018-11-06 20:49               ` Richard Weinberger
2018-11-07  7:53                 ` Christoph Hellwig
2018-11-07 10:46                   ` Anton Ivanov
2018-11-07 13:33                     ` Anton Ivanov
2018-11-06 17:42         ` Anton Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6298063.A9SzxUBULK@blindfold \
    --to=richard@nod.at \
    --cc=anton.ivanov@kot-begemot.co.uk \
    --cc=linux-um@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.