From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED53FC4320A for ; Tue, 17 Aug 2021 09:44:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADE4A60FC3 for ; Tue, 17 Aug 2021 09:44:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ADE4A60FC3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CEED86E150; Tue, 17 Aug 2021 09:44:01 +0000 (UTC) Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by gabe.freedesktop.org (Postfix) with ESMTPS id 34E2F6E150 for ; Tue, 17 Aug 2021 09:44:00 +0000 (UTC) Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17H9Pqpa013375; Tue, 17 Aug 2021 11:43:46 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : subject : to : cc : references : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=iQBg0AS6zUIUk6stFAs5jtKKe3PmvtRCEODGkgVmoNc=; b=aJ5izF7+gl64fItY6ngezbpPsIixaPydAqMvgnaPmpjJuHEqtjtuibZJTQJsr11vpzU0 K1RVbPIXoSCTzmT7enfhhOkSrHfLw4YA0oYVrjo12yWX08HK2XSSkGrhNkAMR7UezVkb 3vU3+P/DUja06o95Y23dKRAJ8TRF54QhbjC/AUkkocuxNWKlhGcKELCNeeVLeh8BreM4 Nfsn0+phqzjBbe1Gw5K7GOLfgt6RBgCB84oKxeXdXKb2tBgxEy6IHJh4tCzqAEdKJXM4 1xFEYhjBvilS8ES2nZqkt7THcBRyRyDQnWu4SnC0kKhV3S110yFUxdQJTYVFpjPnNMvD qw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3afx6junxb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Aug 2021 11:43:46 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8914910002A; Tue, 17 Aug 2021 11:43:44 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 75DA722AFE7; Tue, 17 Aug 2021 11:43:44 +0200 (CEST) Received: from lmecxl0557.lme.st.com (10.75.127.44) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Aug 2021 11:43:43 +0200 From: Raphael Gallais-Pou Subject: Re: [PATCH] drm/stm: ltdc: improve pm_runtime to stop clocks To: Marek Vasut CC: Yannick FERTRE , Philippe CORNU , Raphael GALLAIS-POU , Yannick FERTRE - foss , Philippe CORNU - foss , Benjamin Gaignard , David Airlie , "Daniel Vetter" , Maxime Coquelin , Alexandre TORGUE - foss , "dri-devel@lists.freedesktop.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Stephen Boyd References: <20210629115709.16145-1-raphael.gallais-pou@foss.st.com> <420e243d-7541-a07e-177b-d2db11c26aef@denx.de> <3bb823e4-4724-7072-fe9f-7b8a355c8e50@foss.st.com> <5d65ca80-4f94-49e1-5de1-cf29e8231a6a@denx.de> Message-ID: <629b6666-74b3-91f0-5c6c-e26d55ea62d8@foss.st.com> Date: Tue, 17 Aug 2021 11:43:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <5d65ca80-4f94-49e1-5de1-cf29e8231a6a@denx.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.75.127.44] X-ClientProxiedBy: SFHDAG1NODE3.st.com (10.75.127.3) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-08-17_03:2021-08-16, 2021-08-17 signatures=0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 7/2/21 8:07 PM, Marek Vasut wrote: > On 7/2/21 11:23 AM, Raphael Gallais-Pou wrote: >> Hello Marek, > > Hi, > >> Sorry for the late answer. > > No worries, take your time > >> On 6/30/21 2:35 AM, Marek Vasut wrote: >>> On 6/29/21 1:58 PM, Raphael GALLAIS-POU - foss wrote: >>> >>> [...] >>> >>>> +++ b/drivers/gpu/drm/stm/ltdc.c >>>> @@ -425,10 +425,17 @@ static void ltdc_crtc_atomic_enable(struct drm_crtc *crtc, >>>>   { >>>>       struct ltdc_device *ldev = crtc_to_ltdc(crtc); >>>>       struct drm_device *ddev = crtc->dev; >>>> +    int ret; >>>>         DRM_DEBUG_DRIVER("\n"); >>>>   -    pm_runtime_get_sync(ddev->dev); >>>> +    if (!pm_runtime_active(ddev->dev)) { >>>> +        ret = pm_runtime_get_sync(ddev->dev); >>> >>> All these if (!pm_runtime_active()) then pm_runtime_get_sync() calls look like workaround for some larger issue. Shouldn't the pm_runtime do some refcounting on its own , so this shouldn't be needed ? >> >> >> This problem purely comes from the driver internals, so I don't think it is a workaround. >> >> Because of the "ltdc_crtc_mode_set_nofb" function which does not have any "symmetrical" call, such as enable/disable functions, there was two calls to pm_runtime_get_sync against one call to pm_runtime_put_sync. >> >> This instability resulted in the LTDC clocks being always enabled, even when the peripheral was disabled. This could be seen in the clk_summary as explained in the patch summary among other things. >> >> By doing so, we first check if the clocks are not already activated, and in that case we call pm_runtime_get_sync. > > I just have to wonder, how come other drivers don't need these if (!pm_runtime_active()) pm_runtime_get_sync() conditions. I think they just get/put the runtime PM within a call itself, not across function calls. Maybe that could be the right fix here too ? Hello Marek, I've run a deeper analysis over this implementation. If I may take rockchip's "rockchip_drm_vop.c" driver, there is an boolean "is_enabled" set to true when crtc_atomic_enable is called. The above implementation could save us from adding such field in the ltdc_dev structure. Another solution could be in order to simply call pm_runtime_get_sync() in ltdc_crtc_mode_set_nofb() and by removing this condition in ltdc_atomic_crtc_disable() the driver behaves just like the first version of this patch. In this way, it avoids such conditions and seems more to get along with the current implementation. Regards, Raphaël From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A11EFC4338F for ; Tue, 17 Aug 2021 09:44:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87A9460FC3 for ; Tue, 17 Aug 2021 09:44:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236145AbhHQJor (ORCPT ); Tue, 17 Aug 2021 05:44:47 -0400 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:42892 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235402AbhHQJop (ORCPT ); Tue, 17 Aug 2021 05:44:45 -0400 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17H9Pqpa013375; Tue, 17 Aug 2021 11:43:46 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : subject : to : cc : references : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=iQBg0AS6zUIUk6stFAs5jtKKe3PmvtRCEODGkgVmoNc=; b=aJ5izF7+gl64fItY6ngezbpPsIixaPydAqMvgnaPmpjJuHEqtjtuibZJTQJsr11vpzU0 K1RVbPIXoSCTzmT7enfhhOkSrHfLw4YA0oYVrjo12yWX08HK2XSSkGrhNkAMR7UezVkb 3vU3+P/DUja06o95Y23dKRAJ8TRF54QhbjC/AUkkocuxNWKlhGcKELCNeeVLeh8BreM4 Nfsn0+phqzjBbe1Gw5K7GOLfgt6RBgCB84oKxeXdXKb2tBgxEy6IHJh4tCzqAEdKJXM4 1xFEYhjBvilS8ES2nZqkt7THcBRyRyDQnWu4SnC0kKhV3S110yFUxdQJTYVFpjPnNMvD qw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3afx6junxb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Aug 2021 11:43:46 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8914910002A; Tue, 17 Aug 2021 11:43:44 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 75DA722AFE7; Tue, 17 Aug 2021 11:43:44 +0200 (CEST) Received: from lmecxl0557.lme.st.com (10.75.127.44) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Aug 2021 11:43:43 +0200 From: Raphael Gallais-Pou Subject: Re: [PATCH] drm/stm: ltdc: improve pm_runtime to stop clocks To: Marek Vasut CC: Yannick FERTRE , Philippe CORNU , Raphael GALLAIS-POU , Yannick FERTRE - foss , Philippe CORNU - foss , Benjamin Gaignard , David Airlie , "Daniel Vetter" , Maxime Coquelin , Alexandre TORGUE - foss , "dri-devel@lists.freedesktop.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Stephen Boyd References: <20210629115709.16145-1-raphael.gallais-pou@foss.st.com> <420e243d-7541-a07e-177b-d2db11c26aef@denx.de> <3bb823e4-4724-7072-fe9f-7b8a355c8e50@foss.st.com> <5d65ca80-4f94-49e1-5de1-cf29e8231a6a@denx.de> Message-ID: <629b6666-74b3-91f0-5c6c-e26d55ea62d8@foss.st.com> Date: Tue, 17 Aug 2021 11:43:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <5d65ca80-4f94-49e1-5de1-cf29e8231a6a@denx.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.75.127.44] X-ClientProxiedBy: SFHDAG1NODE3.st.com (10.75.127.3) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-08-17_03:2021-08-16,2021-08-17 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/2/21 8:07 PM, Marek Vasut wrote: > On 7/2/21 11:23 AM, Raphael Gallais-Pou wrote: >> Hello Marek, > > Hi, > >> Sorry for the late answer. > > No worries, take your time > >> On 6/30/21 2:35 AM, Marek Vasut wrote: >>> On 6/29/21 1:58 PM, Raphael GALLAIS-POU - foss wrote: >>> >>> [...] >>> >>>> +++ b/drivers/gpu/drm/stm/ltdc.c >>>> @@ -425,10 +425,17 @@ static void ltdc_crtc_atomic_enable(struct drm_crtc *crtc, >>>>   { >>>>       struct ltdc_device *ldev = crtc_to_ltdc(crtc); >>>>       struct drm_device *ddev = crtc->dev; >>>> +    int ret; >>>>         DRM_DEBUG_DRIVER("\n"); >>>>   -    pm_runtime_get_sync(ddev->dev); >>>> +    if (!pm_runtime_active(ddev->dev)) { >>>> +        ret = pm_runtime_get_sync(ddev->dev); >>> >>> All these if (!pm_runtime_active()) then pm_runtime_get_sync() calls look like workaround for some larger issue. Shouldn't the pm_runtime do some refcounting on its own , so this shouldn't be needed ? >> >> >> This problem purely comes from the driver internals, so I don't think it is a workaround. >> >> Because of the "ltdc_crtc_mode_set_nofb" function which does not have any "symmetrical" call, such as enable/disable functions, there was two calls to pm_runtime_get_sync against one call to pm_runtime_put_sync. >> >> This instability resulted in the LTDC clocks being always enabled, even when the peripheral was disabled. This could be seen in the clk_summary as explained in the patch summary among other things. >> >> By doing so, we first check if the clocks are not already activated, and in that case we call pm_runtime_get_sync. > > I just have to wonder, how come other drivers don't need these if (!pm_runtime_active()) pm_runtime_get_sync() conditions. I think they just get/put the runtime PM within a call itself, not across function calls. Maybe that could be the right fix here too ? Hello Marek, I've run a deeper analysis over this implementation. If I may take rockchip's "rockchip_drm_vop.c" driver, there is an boolean "is_enabled" set to true when crtc_atomic_enable is called. The above implementation could save us from adding such field in the ltdc_dev structure. Another solution could be in order to simply call pm_runtime_get_sync() in ltdc_crtc_mode_set_nofb() and by removing this condition in ltdc_atomic_crtc_disable() the driver behaves just like the first version of this patch. In this way, it avoids such conditions and seems more to get along with the current implementation. Regards, Raphaël From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4B4BC4338F for ; Tue, 17 Aug 2021 09:46:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95A0660F38 for ; Tue, 17 Aug 2021 09:46:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 95A0660F38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:CC:To:Subject:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=tWPGC6e0GQaHOE/1cdaiLWZfS0QytbLxoR9YPBbP8mE=; b=Z7mzV2Cl8/E+Xn9NLwwH99LT38 vMlSOF/tveS7K8OhROA+TDnradNMk7N/SJN0Jl5P20eXPuYFYDpfNTL/1vLMAiLp1ks+dVLw9ZXQ4 dTNmsfBvjtmoRxMD2XuXMNsTRtLU6ArzJRgl1hxeeDe8odpZ7RqCd7QPuguZjTlprFRLgeSCL6gyg zHKKGvpglxm/g6jbEVbeHGOO+e9nlQ6ij93aBA2xYKad4jWyoBwMkk8JtPcLeMjvhSmHPvek3J8gw iCreT8PCeTP2ndfwDxkAxBXLdz/Z66rDss/ID12ixo61ACsj3jx/OOPUAsDKXXx3QpuOoN97sDzwM uW4yiR6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFvdp-001soq-UE; Tue, 17 Aug 2021 09:44:18 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFvde-001siY-Lm for linux-arm-kernel@lists.infradead.org; Tue, 17 Aug 2021 09:44:10 +0000 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17H9Pqpa013375; Tue, 17 Aug 2021 11:43:46 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : subject : to : cc : references : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=iQBg0AS6zUIUk6stFAs5jtKKe3PmvtRCEODGkgVmoNc=; b=aJ5izF7+gl64fItY6ngezbpPsIixaPydAqMvgnaPmpjJuHEqtjtuibZJTQJsr11vpzU0 K1RVbPIXoSCTzmT7enfhhOkSrHfLw4YA0oYVrjo12yWX08HK2XSSkGrhNkAMR7UezVkb 3vU3+P/DUja06o95Y23dKRAJ8TRF54QhbjC/AUkkocuxNWKlhGcKELCNeeVLeh8BreM4 Nfsn0+phqzjBbe1Gw5K7GOLfgt6RBgCB84oKxeXdXKb2tBgxEy6IHJh4tCzqAEdKJXM4 1xFEYhjBvilS8ES2nZqkt7THcBRyRyDQnWu4SnC0kKhV3S110yFUxdQJTYVFpjPnNMvD qw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3afx6junxb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Aug 2021 11:43:46 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8914910002A; Tue, 17 Aug 2021 11:43:44 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 75DA722AFE7; Tue, 17 Aug 2021 11:43:44 +0200 (CEST) Received: from lmecxl0557.lme.st.com (10.75.127.44) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Aug 2021 11:43:43 +0200 From: Raphael Gallais-Pou Subject: Re: [PATCH] drm/stm: ltdc: improve pm_runtime to stop clocks To: Marek Vasut CC: Yannick FERTRE , Philippe CORNU , Raphael GALLAIS-POU , Yannick FERTRE - foss , Philippe CORNU - foss , Benjamin Gaignard , David Airlie , "Daniel Vetter" , Maxime Coquelin , Alexandre TORGUE - foss , "dri-devel@lists.freedesktop.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Stephen Boyd References: <20210629115709.16145-1-raphael.gallais-pou@foss.st.com> <420e243d-7541-a07e-177b-d2db11c26aef@denx.de> <3bb823e4-4724-7072-fe9f-7b8a355c8e50@foss.st.com> <5d65ca80-4f94-49e1-5de1-cf29e8231a6a@denx.de> Message-ID: <629b6666-74b3-91f0-5c6c-e26d55ea62d8@foss.st.com> Date: Tue, 17 Aug 2021 11:43:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <5d65ca80-4f94-49e1-5de1-cf29e8231a6a@denx.de> Content-Language: en-US X-Originating-IP: [10.75.127.44] X-ClientProxiedBy: SFHDAG1NODE3.st.com (10.75.127.3) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-08-17_03:2021-08-16, 2021-08-17 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210817_024407_037000_B0C4218A X-CRM114-Status: GOOD ( 27.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDcvMi8yMSA4OjA3IFBNLCBNYXJlayBWYXN1dCB3cm90ZToKPiBPbiA3LzIvMjEgMTE6MjMg QU0sIFJhcGhhZWwgR2FsbGFpcy1Qb3Ugd3JvdGU6Cj4+IEhlbGxvIE1hcmVrLAo+Cj4gSGksCj4K Pj4gU29ycnkgZm9yIHRoZSBsYXRlIGFuc3dlci4KPgo+IE5vIHdvcnJpZXMsIHRha2UgeW91ciB0 aW1lCj4KPj4gT24gNi8zMC8yMSAyOjM1IEFNLCBNYXJlayBWYXN1dCB3cm90ZToKPj4+IE9uIDYv MjkvMjEgMTo1OCBQTSwgUmFwaGFlbCBHQUxMQUlTLVBPVSAtIGZvc3Mgd3JvdGU6Cj4+Pgo+Pj4g Wy4uLl0KPj4+Cj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3N0bS9sdGRjLmMKPj4+PiBAQCAt NDI1LDEwICs0MjUsMTcgQEAgc3RhdGljIHZvaWQgbHRkY19jcnRjX2F0b21pY19lbmFibGUoc3Ry dWN0IGRybV9jcnRjICpjcnRjLAo+Pj4+IMKgIHsKPj4+PiDCoMKgwqDCoMKgIHN0cnVjdCBsdGRj X2RldmljZSAqbGRldiA9IGNydGNfdG9fbHRkYyhjcnRjKTsKPj4+PiDCoMKgwqDCoMKgIHN0cnVj dCBkcm1fZGV2aWNlICpkZGV2ID0gY3J0Yy0+ZGV2Owo+Pj4+ICvCoMKgwqAgaW50IHJldDsKPj4+ PiDCoCDCoMKgwqDCoMKgIERSTV9ERUJVR19EUklWRVIoIlxuIik7Cj4+Pj4gwqAgLcKgwqDCoCBw bV9ydW50aW1lX2dldF9zeW5jKGRkZXYtPmRldik7Cj4+Pj4gK8KgwqDCoCBpZiAoIXBtX3J1bnRp bWVfYWN0aXZlKGRkZXYtPmRldikpIHsKPj4+PiArwqDCoMKgwqDCoMKgwqAgcmV0ID0gcG1fcnVu dGltZV9nZXRfc3luYyhkZGV2LT5kZXYpOwo+Pj4KPj4+IEFsbCB0aGVzZSBpZiAoIXBtX3J1bnRp bWVfYWN0aXZlKCkpIHRoZW4gcG1fcnVudGltZV9nZXRfc3luYygpIGNhbGxzIGxvb2sgbGlrZSB3 b3JrYXJvdW5kIGZvciBzb21lIGxhcmdlciBpc3N1ZS4gU2hvdWxkbid0IHRoZSBwbV9ydW50aW1l IGRvIHNvbWUgcmVmY291bnRpbmcgb24gaXRzIG93biAsIHNvIHRoaXMgc2hvdWxkbid0IGJlIG5l ZWRlZCA/Cj4+Cj4+Cj4+IFRoaXMgcHJvYmxlbSBwdXJlbHkgY29tZXMgZnJvbSB0aGUgZHJpdmVy IGludGVybmFscywgc28gSSBkb24ndCB0aGluayBpdCBpcyBhIHdvcmthcm91bmQuCj4+Cj4+IEJl Y2F1c2Ugb2YgdGhlICJsdGRjX2NydGNfbW9kZV9zZXRfbm9mYiIgZnVuY3Rpb24gd2hpY2ggZG9l cyBub3QgaGF2ZSBhbnkgInN5bW1ldHJpY2FsIiBjYWxsLCBzdWNoIGFzIGVuYWJsZS9kaXNhYmxl IGZ1bmN0aW9ucywgdGhlcmUgd2FzIHR3byBjYWxscyB0byBwbV9ydW50aW1lX2dldF9zeW5jIGFn YWluc3Qgb25lIGNhbGwgdG8gcG1fcnVudGltZV9wdXRfc3luYy4KPj4KPj4gVGhpcyBpbnN0YWJp bGl0eSByZXN1bHRlZCBpbiB0aGUgTFREQyBjbG9ja3MgYmVpbmcgYWx3YXlzIGVuYWJsZWQsIGV2 ZW4gd2hlbiB0aGUgcGVyaXBoZXJhbCB3YXMgZGlzYWJsZWQuIFRoaXMgY291bGQgYmUgc2VlbiBp biB0aGUgY2xrX3N1bW1hcnkgYXMgZXhwbGFpbmVkIGluIHRoZSBwYXRjaCBzdW1tYXJ5IGFtb25n IG90aGVyIHRoaW5ncy4KPj4KPj4gQnkgZG9pbmcgc28sIHdlIGZpcnN0IGNoZWNrIGlmIHRoZSBj bG9ja3MgYXJlIG5vdCBhbHJlYWR5IGFjdGl2YXRlZCwgYW5kIGluIHRoYXQgY2FzZSB3ZSBjYWxs IHBtX3J1bnRpbWVfZ2V0X3N5bmMuCj4KPiBJIGp1c3QgaGF2ZSB0byB3b25kZXIsIGhvdyBjb21l IG90aGVyIGRyaXZlcnMgZG9uJ3QgbmVlZCB0aGVzZSBpZiAoIXBtX3J1bnRpbWVfYWN0aXZlKCkp IHBtX3J1bnRpbWVfZ2V0X3N5bmMoKSBjb25kaXRpb25zLiBJIHRoaW5rIHRoZXkganVzdCBnZXQv cHV0IHRoZSBydW50aW1lIFBNIHdpdGhpbiBhIGNhbGwgaXRzZWxmLCBub3QgYWNyb3NzIGZ1bmN0 aW9uIGNhbGxzLiBNYXliZSB0aGF0IGNvdWxkIGJlIHRoZSByaWdodCBmaXggaGVyZSB0b28gPwoK CkhlbGxvIE1hcmVrLAoKCkkndmUgcnVuIGEgZGVlcGVyIGFuYWx5c2lzIG92ZXIgdGhpcyBpbXBs ZW1lbnRhdGlvbi4KCklmIEkgbWF5IHRha2Ugcm9ja2NoaXAncyAicm9ja2NoaXBfZHJtX3ZvcC5j IiBkcml2ZXIsIHRoZXJlIGlzIGFuIGJvb2xlYW4gImlzX2VuYWJsZWQiIHNldCB0byB0cnVlIHdo ZW4gY3J0Y19hdG9taWNfZW5hYmxlIGlzIGNhbGxlZC4KClRoZSBhYm92ZSBpbXBsZW1lbnRhdGlv biBjb3VsZCBzYXZlIHVzIGZyb20gYWRkaW5nIHN1Y2ggZmllbGQgaW4gdGhlIGx0ZGNfZGV2IHN0 cnVjdHVyZS4KCkFub3RoZXIgc29sdXRpb24gY291bGQgYmUgaW4gb3JkZXIgdG8gc2ltcGx5IGNh bGwgcG1fcnVudGltZV9nZXRfc3luYygpIGluIGx0ZGNfY3J0Y19tb2RlX3NldF9ub2ZiKCkgYW5k IGJ5IHJlbW92aW5nIHRoaXMgY29uZGl0aW9uIGluIGx0ZGNfYXRvbWljX2NydGNfZGlzYWJsZSgp IHRoZSBkcml2ZXIgYmVoYXZlcyBqdXN0IGxpa2UgdGhlIGZpcnN0IHZlcnNpb24gb2YgdGhpcyBw YXRjaC4KCkluIHRoaXMgd2F5LCBpdCBhdm9pZHMgc3VjaCBjb25kaXRpb25zIGFuZCBzZWVtcyBt b3JlIHRvIGdldCBhbG9uZyB3aXRoIHRoZSBjdXJyZW50IGltcGxlbWVudGF0aW9uLgoKClJlZ2Fy ZHMsCgpSYXBoYcOrbAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK