From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751395AbdFEN6P (ORCPT ); Mon, 5 Jun 2017 09:58:15 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:26524 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751368AbdFEN5H (ORCPT ); Mon, 5 Jun 2017 09:57:07 -0400 Subject: Re: [PATCH v2 1/1] w1: Add subsystem kernel public interface To: Greg Kroah-Hartman CC: Evgeniy Polyakov , Sebastian Reichel , , References: <20170516200814.12360-1-afd@ti.com> <20170516200814.12360-2-afd@ti.com> <20170603102233.GA19112@kroah.com> From: "Andrew F. Davis" Message-ID: <62ab04d3-a648-01d1-ae0e-aa2e79b08f9a@ti.com> Date: Mon, 5 Jun 2017 08:57:01 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170603102233.GA19112@kroah.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/03/2017 05:22 AM, Greg Kroah-Hartman wrote: > On Tue, May 16, 2017 at 03:08:14PM -0500, Andrew F. Davis wrote: >> Like other subsystems we should be able to define slave devices outside >> of the w1 directory. To do this we move public facing interface >> definitions to include/linux/w1.h and rename the internal definition >> file to w1_internal.h. >> >> As w1_family.h and w1_int.h contained almost entirely public >> driver interface definitions we simply removed these files and >> moved the remaining definitions into w1_internal.h. >> >> With this we can now start to move slave devices out of w1/slaves and >> into the subsystem based on the function they implement, again like >> other drivers. >> >> Signed-off-by: Andrew F. Davis >> Reviewed-by: Sebastian Reichel > > This breaks the build for me: > CC [M] drivers/power/supply/ds2760_battery.o > drivers/power/supply/ds2760_battery.c:31:10: fatal error: ../../w1/w1.h: No such file or directory > #include "../../w1/w1.h" > ^~~~~~~~~~~~~~~ > compilation terminated. > > > So there was w1 drivers outside of the drivers/w1/ directory :) > Seems these drivers are like the BQ27xxx I'm trying to fix-up, these are platform drivers that connect with the real driver in w1/. Must have missed my search. > Please fix and resend. > Fix sent in v3. Thanks, Andrew > thanks, > > greg k-h > From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Andrew F. Davis" Date: Mon, 05 Jun 2017 13:57:01 +0000 Subject: Re: [PATCH v2 1/1] w1: Add subsystem kernel public interface Message-Id: <62ab04d3-a648-01d1-ae0e-aa2e79b08f9a@ti.com> List-Id: References: <20170516200814.12360-1-afd@ti.com> <20170516200814.12360-2-afd@ti.com> <20170603102233.GA19112@kroah.com> In-Reply-To: <20170603102233.GA19112@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Greg Kroah-Hartman Cc: Evgeniy Polyakov , Sebastian Reichel , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On 06/03/2017 05:22 AM, Greg Kroah-Hartman wrote: > On Tue, May 16, 2017 at 03:08:14PM -0500, Andrew F. Davis wrote: >> Like other subsystems we should be able to define slave devices outside >> of the w1 directory. To do this we move public facing interface >> definitions to include/linux/w1.h and rename the internal definition >> file to w1_internal.h. >> >> As w1_family.h and w1_int.h contained almost entirely public >> driver interface definitions we simply removed these files and >> moved the remaining definitions into w1_internal.h. >> >> With this we can now start to move slave devices out of w1/slaves and >> into the subsystem based on the function they implement, again like >> other drivers. >> >> Signed-off-by: Andrew F. Davis >> Reviewed-by: Sebastian Reichel > > This breaks the build for me: > CC [M] drivers/power/supply/ds2760_battery.o > drivers/power/supply/ds2760_battery.c:31:10: fatal error: ../../w1/w1.h: No such file or directory > #include "../../w1/w1.h" > ^~~~~~~~~~~~~~~ > compilation terminated. > > > So there was w1 drivers outside of the drivers/w1/ directory :) > Seems these drivers are like the BQ27xxx I'm trying to fix-up, these are platform drivers that connect with the real driver in w1/. Must have missed my search. > Please fix and resend. > Fix sent in v3. Thanks, Andrew > thanks, > > greg k-h >