All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] board: stm32mp1: Remove gpio_hog_probe_all() from board
@ 2021-09-01  9:51 Patrice Chotard
  2021-09-01  9:51 ` [PATCH 2/2] board: dh_stm32mp1: " Patrice Chotard
  2021-09-03  8:30 ` [PATCH 1/2] board: stm32mp1: " Patrick DELAUNAY
  0 siblings, 2 replies; 7+ messages in thread
From: Patrice Chotard @ 2021-09-01  9:51 UTC (permalink / raw)
  To: u-boot
  Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Jaehoon Chung,
	Manuel Reis, Simon Glass

DM_GPIO_HOG flag has been replaced by GPIO_HOG flag since a while in
commit 49b10cb49262 ("gpio: fixes for gpio-hog support").

And furthermore, gpio_hog_probe_all() is already called in board_r.c.
So gpio_hog_probe() can be removed from stm32mp1.c.

Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---

 board/st/stm32mp1/stm32mp1.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c
index 032f08d795..b5500399e6 100644
--- a/board/st/stm32mp1/stm32mp1.c
+++ b/board/st/stm32mp1/stm32mp1.c
@@ -649,9 +649,6 @@ int board_init(void)
 	/* address of boot parameters */
 	gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100;
 
-	if (CONFIG_IS_ENABLED(DM_GPIO_HOG))
-		gpio_hog_probe_all();
-
 	board_key_check();
 
 	if (board_is_ev1())
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH 2/2] board: dh_stm32mp1: Remove gpio_hog_probe_all() from board
  2021-09-01  9:51 [PATCH 1/2] board: stm32mp1: Remove gpio_hog_probe_all() from board Patrice Chotard
@ 2021-09-01  9:51 ` Patrice Chotard
  2021-09-03  8:31   ` Patrick DELAUNAY
  2021-09-03 13:02   ` Marek Vasut
  2021-09-03  8:30 ` [PATCH 1/2] board: stm32mp1: " Patrick DELAUNAY
  1 sibling, 2 replies; 7+ messages in thread
From: Patrice Chotard @ 2021-09-01  9:51 UTC (permalink / raw)
  To: u-boot
  Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Marek Vasut,
	Simon Glass

DM_GPIO_HOG flag has been replaced by GPIO_HOG flag since a while in
commit 49b10cb49262 ("gpio: fixes for gpio-hog support").

And furthermore, gpio_hog_probe_all() is already called in board_r.c.
So gpio_hog_probe() can be removed from stm32mp1.c.

Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Marek Vasut <marex@denx.de>
---

 board/dhelectronics/dh_stm32mp1/board.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/board/dhelectronics/dh_stm32mp1/board.c b/board/dhelectronics/dh_stm32mp1/board.c
index d7c1857c16..725b438d76 100644
--- a/board/dhelectronics/dh_stm32mp1/board.c
+++ b/board/dhelectronics/dh_stm32mp1/board.c
@@ -593,9 +593,6 @@ int board_init(void)
 	/* address of boot parameters */
 	gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100;
 
-	if (CONFIG_IS_ENABLED(DM_GPIO_HOG))
-		gpio_hog_probe_all();
-
 	board_key_check();
 
 #ifdef CONFIG_DM_REGULATOR
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] board: stm32mp1: Remove gpio_hog_probe_all() from board
  2021-09-01  9:51 [PATCH 1/2] board: stm32mp1: Remove gpio_hog_probe_all() from board Patrice Chotard
  2021-09-01  9:51 ` [PATCH 2/2] board: dh_stm32mp1: " Patrice Chotard
@ 2021-09-03  8:30 ` Patrick DELAUNAY
  1 sibling, 0 replies; 7+ messages in thread
From: Patrick DELAUNAY @ 2021-09-03  8:30 UTC (permalink / raw)
  To: Patrice Chotard, u-boot
  Cc: U-Boot STM32, Jaehoon Chung, Manuel Reis, Simon Glass

Hi,

On 9/1/21 11:51 AM, Patrice Chotard wrote:
> DM_GPIO_HOG flag has been replaced by GPIO_HOG flag since a while in
> commit 49b10cb49262 ("gpio: fixes for gpio-hog support").
>
> And furthermore, gpio_hog_probe_all() is already called in board_r.c.
> So gpio_hog_probe() can be removed from stm32mp1.c.
>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
>
>   board/st/stm32mp1/stm32mp1.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c
> index 032f08d795..b5500399e6 100644
> --- a/board/st/stm32mp1/stm32mp1.c
> +++ b/board/st/stm32mp1/stm32mp1.c
> @@ -649,9 +649,6 @@ int board_init(void)
>   	/* address of boot parameters */
>   	gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100;
>   
> -	if (CONFIG_IS_ENABLED(DM_GPIO_HOG))
> -		gpio_hog_probe_all();
> -
>   	board_key_check();
>   
>   	if (board_is_ev1())


Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Thanks
Patrick


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] board: dh_stm32mp1: Remove gpio_hog_probe_all() from board
  2021-09-01  9:51 ` [PATCH 2/2] board: dh_stm32mp1: " Patrice Chotard
@ 2021-09-03  8:31   ` Patrick DELAUNAY
  2021-10-08  6:46     ` Patrice CHOTARD
  2021-09-03 13:02   ` Marek Vasut
  1 sibling, 1 reply; 7+ messages in thread
From: Patrick DELAUNAY @ 2021-09-03  8:31 UTC (permalink / raw)
  To: Patrice Chotard, u-boot; +Cc: U-Boot STM32, Marek Vasut, Simon Glass

Hi Patrice,

On 9/1/21 11:51 AM, Patrice Chotard wrote:
> DM_GPIO_HOG flag has been replaced by GPIO_HOG flag since a while in
> commit 49b10cb49262 ("gpio: fixes for gpio-hog support").
>
> And furthermore, gpio_hog_probe_all() is already called in board_r.c.
> So gpio_hog_probe() can be removed from stm32mp1.c.
>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Marek Vasut <marex@denx.de>
> ---
>
>   board/dhelectronics/dh_stm32mp1/board.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/board/dhelectronics/dh_stm32mp1/board.c b/board/dhelectronics/dh_stm32mp1/board.c
> index d7c1857c16..725b438d76 100644
> --- a/board/dhelectronics/dh_stm32mp1/board.c
> +++ b/board/dhelectronics/dh_stm32mp1/board.c
> @@ -593,9 +593,6 @@ int board_init(void)
>   	/* address of boot parameters */
>   	gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100;
>   
> -	if (CONFIG_IS_ENABLED(DM_GPIO_HOG))
> -		gpio_hog_probe_all();
> -
>   	board_key_check();
>   
>   #ifdef CONFIG_DM_REGULATOR


Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Thanks
Patrick


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] board: dh_stm32mp1: Remove gpio_hog_probe_all() from board
  2021-09-01  9:51 ` [PATCH 2/2] board: dh_stm32mp1: " Patrice Chotard
  2021-09-03  8:31   ` Patrick DELAUNAY
@ 2021-09-03 13:02   ` Marek Vasut
  2021-10-08  6:47     ` Patrice CHOTARD
  1 sibling, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2021-09-03 13:02 UTC (permalink / raw)
  To: Patrice Chotard, u-boot; +Cc: Patrick DELAUNAY, U-Boot STM32, Simon Glass

On 9/1/21 11:51 AM, Patrice Chotard wrote:
> DM_GPIO_HOG flag has been replaced by GPIO_HOG flag since a while in
> commit 49b10cb49262 ("gpio: fixes for gpio-hog support").
> 
> And furthermore, gpio_hog_probe_all() is already called in board_r.c.
> So gpio_hog_probe() can be removed from stm32mp1.c.
> 
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Marek Vasut <marex@denx.de>
> ---
> 
>   board/dhelectronics/dh_stm32mp1/board.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/board/dhelectronics/dh_stm32mp1/board.c b/board/dhelectronics/dh_stm32mp1/board.c
> index d7c1857c16..725b438d76 100644
> --- a/board/dhelectronics/dh_stm32mp1/board.c
> +++ b/board/dhelectronics/dh_stm32mp1/board.c
> @@ -593,9 +593,6 @@ int board_init(void)
>   	/* address of boot parameters */
>   	gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100;
>   
> -	if (CONFIG_IS_ENABLED(DM_GPIO_HOG))
> -		gpio_hog_probe_all();
> -
>   	board_key_check();

This is likely OK, yes.

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] board: dh_stm32mp1: Remove gpio_hog_probe_all() from board
  2021-09-03  8:31   ` Patrick DELAUNAY
@ 2021-10-08  6:46     ` Patrice CHOTARD
  0 siblings, 0 replies; 7+ messages in thread
From: Patrice CHOTARD @ 2021-10-08  6:46 UTC (permalink / raw)
  To: Patrick DELAUNAY, u-boot; +Cc: U-Boot STM32, Marek Vasut, Simon Glass

Hi

On 9/3/21 10:31 AM, Patrick DELAUNAY wrote:
> Hi Patrice,
> 
> On 9/1/21 11:51 AM, Patrice Chotard wrote:
>> DM_GPIO_HOG flag has been replaced by GPIO_HOG flag since a while in
>> commit 49b10cb49262 ("gpio: fixes for gpio-hog support").
>>
>> And furthermore, gpio_hog_probe_all() is already called in board_r.c.
>> So gpio_hog_probe() can be removed from stm32mp1.c.
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> Cc: Marek Vasut <marex@denx.de>
>> ---
>>
>>   board/dhelectronics/dh_stm32mp1/board.c | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/board/dhelectronics/dh_stm32mp1/board.c b/board/dhelectronics/dh_stm32mp1/board.c
>> index d7c1857c16..725b438d76 100644
>> --- a/board/dhelectronics/dh_stm32mp1/board.c
>> +++ b/board/dhelectronics/dh_stm32mp1/board.c
>> @@ -593,9 +593,6 @@ int board_init(void)
>>       /* address of boot parameters */
>>       gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100;
>>   -    if (CONFIG_IS_ENABLED(DM_GPIO_HOG))
>> -        gpio_hog_probe_all();
>> -
>>       board_key_check();
>>     #ifdef CONFIG_DM_REGULATOR
> 
> 
> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> 
> Thanks
> Patrick
> 
Applied on u-boot-stm32 for next
Thanks
Patrice

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] board: dh_stm32mp1: Remove gpio_hog_probe_all() from board
  2021-09-03 13:02   ` Marek Vasut
@ 2021-10-08  6:47     ` Patrice CHOTARD
  0 siblings, 0 replies; 7+ messages in thread
From: Patrice CHOTARD @ 2021-10-08  6:47 UTC (permalink / raw)
  To: Marek Vasut, u-boot; +Cc: Patrick DELAUNAY, U-Boot STM32, Simon Glass

Hi

On 9/3/21 3:02 PM, Marek Vasut wrote:
> On 9/1/21 11:51 AM, Patrice Chotard wrote:
>> DM_GPIO_HOG flag has been replaced by GPIO_HOG flag since a while in
>> commit 49b10cb49262 ("gpio: fixes for gpio-hog support").
>>
>> And furthermore, gpio_hog_probe_all() is already called in board_r.c.
>> So gpio_hog_probe() can be removed from stm32mp1.c.
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> Cc: Marek Vasut <marex@denx.de>
>> ---
>>
>>   board/dhelectronics/dh_stm32mp1/board.c | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/board/dhelectronics/dh_stm32mp1/board.c b/board/dhelectronics/dh_stm32mp1/board.c
>> index d7c1857c16..725b438d76 100644
>> --- a/board/dhelectronics/dh_stm32mp1/board.c
>> +++ b/board/dhelectronics/dh_stm32mp1/board.c
>> @@ -593,9 +593,6 @@ int board_init(void)
>>       /* address of boot parameters */
>>       gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100;
>>   -    if (CONFIG_IS_ENABLED(DM_GPIO_HOG))
>> -        gpio_hog_probe_all();
>> -
>>       board_key_check();
> 
> This is likely OK, yes.

Applied on u-boot-stm32 for next
Thanks
Patrice

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-10-08  6:47 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01  9:51 [PATCH 1/2] board: stm32mp1: Remove gpio_hog_probe_all() from board Patrice Chotard
2021-09-01  9:51 ` [PATCH 2/2] board: dh_stm32mp1: " Patrice Chotard
2021-09-03  8:31   ` Patrick DELAUNAY
2021-10-08  6:46     ` Patrice CHOTARD
2021-09-03 13:02   ` Marek Vasut
2021-10-08  6:47     ` Patrice CHOTARD
2021-09-03  8:30 ` [PATCH 1/2] board: stm32mp1: " Patrick DELAUNAY

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.