From: Kumar Gala <galak@kernel.crashing.org>
To: Tudor Laurentiu <Laurentiu.Tudor@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/time: When starting the decrementer don't zero the other bits in TCR
Date: Thu, 1 Sep 2011 13:49:39 -0500 [thread overview]
Message-ID: <631F005F-2A4D-40E6-8C34-177F5CCAE40D@kernel.crashing.org> (raw)
In-Reply-To: <4E5FA6ED.9010703@freescale.com>
On Sep 1, 2011, at 10:38 AM, Tudor Laurentiu wrote:
> On 9/1/2011 4:56 PM, Kumar Gala wrote:
>>=20
>> On Sep 1, 2011, at 3:31 AM, Tudor Laurentiu wrote:
>>=20
>>> On 9/1/2011 9:27 AM, Kumar Gala wrote:
>>>>=20
>>>> On Aug 25, 2011, at 7:19 AM, Laurentiu Tudor wrote:
>>>>=20
>>>>> Clearing the other TCR bits might break code that sets them (e.g. =
to setup
>>>>> the watchdog or fixed interval timer) before =
start_cpu_decrementer() gets
>>>>> called.
>>>>=20
>>>> Can you be more specific about the case you're concerned about. =
I'm not sure we want to leave the FIT enabled if it was previously. =
Watchdog I could possibly see leaving alone.
>>>=20
>>> My particular case was this: I was experimenting with having the =
watchdog enabled during the boot process, in case something goes wrong =
before the normal watchdog mechanism kicks in. That didn't work without =
making this modification.
>>> Then, thinking that having a function start_cpu_decrementer() =
touching the other timers and not only the decrementer as its name =
implies might not be good. So I submitted this patch to the public =
mailing list to let the community decide if it's useful.
>>=20
>> So I think renaming the function is fine, and I think not touching =
the watchdog bits is also reasonable. So if you update the patch along =
those lines I think we can push in. I do want to make sure that the FIT =
is disabled as we dont expect it.
>=20
> how about:
>=20
> static void setup_cpu_timers()
>=20
> ?
Sounds fine to me
>=20
>> Probably add a comment about how care needs to be taken if the =
wathchdog is enable be firmware or a previous kernel.
>=20
> OK.
>=20
>=20
>=20
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
prev parent reply other threads:[~2011-09-01 18:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 12:19 [PATCH] powerpc/time: When starting the decrementer don't zero the other bits in TCR Laurentiu Tudor
2011-09-01 6:27 ` Kumar Gala
2011-09-01 8:31 ` Tudor Laurentiu
2011-09-01 13:56 ` Kumar Gala
2011-09-01 15:38 ` Tudor Laurentiu
2011-09-01 18:49 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=631F005F-2A4D-40E6-8C34-177F5CCAE40D@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=Laurentiu.Tudor@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.