From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67699C433EF for ; Mon, 14 Mar 2022 11:55:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239825AbiCNL4v (ORCPT ); Mon, 14 Mar 2022 07:56:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239713AbiCNL4e (ORCPT ); Mon, 14 Mar 2022 07:56:34 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2E4865DA; Mon, 14 Mar 2022 04:55:24 -0700 (PDT) X-UUID: 8e5afcbc685345658257b8f04900fa8c-20220314 X-UUID: 8e5afcbc685345658257b8f04900fa8c-20220314 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 316277914; Mon, 14 Mar 2022 19:55:18 +0800 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Mon, 14 Mar 2022 19:55:17 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 14 Mar 2022 19:55:16 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 14 Mar 2022 19:55:16 +0800 Message-ID: <632e51a931d1c7253eb72d8b2df281e25621bfa1.camel@mediatek.com> Subject: Re: [v3 19/19] ASoC: mediatek: mt6358: add missing EXPORT_SYMBOLs From: Jiaxin Yu To: AngeloGioacchino Del Regno , , CC: , , , , , , , , , , Date: Mon, 14 Mar 2022 19:55:15 +0800 In-Reply-To: References: <20220313151023.21229-1-jiaxin.yu@mediatek.com> <20220313151023.21229-20-jiaxin.yu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-03-14 at 11:18 +0100, AngeloGioacchino Del Regno wrote: > Il 13/03/22 16:10, Jiaxin Yu ha scritto: > > This fixes the following build errors when mt6358 is configured as > > module: > > > > > > ERROR: modpost: "mt6358_set_mtkaif_protocol" > > > > [sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.ko] > > > > undefined! > > > > ERROR: modpost: "mt6358_set_mtkaif_protocol" > > > > [sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.ko] > > > > undefined! > > > > Signed-off-by: Jiaxin Yu > > Hello Jiaxin, > > Can you please add a Fixes tag to this patch and send it separately > from > the MT8186 series? > > After adding the Fixes tag: > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > > Thanks, > Angelo > Hello Angelo, OK, I will send this patch with the Fixes tag separately from the MT8186 series. Thanks, Jiaxin.Yu > > --- > > sound/soc/codecs/mt6358.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/sound/soc/codecs/mt6358.c b/sound/soc/codecs/mt6358.c > > index 1fdd2f8cf877..61f2a7632fd4 100644 > > --- a/sound/soc/codecs/mt6358.c > > +++ b/sound/soc/codecs/mt6358.c > > @@ -107,6 +107,7 @@ int mt6358_set_mtkaif_protocol(struct > > snd_soc_component *cmpnt, > > priv->mtkaif_protocol = mtkaif_protocol; > > return 0; > > } > > +EXPORT_SYMBOL_GPL(mt6358_set_mtkaif_protocol); > > > > static void playback_gpio_set(struct mt6358_priv *priv) > > { > > @@ -273,6 +274,7 @@ int mt6358_mtkaif_calibration_enable(struct > > snd_soc_component *cmpnt) > > 1 << RG_AUD_PAD_TOP_DAT_MISO_LOOPBACK_SFT); > > return 0; > > } > > +EXPORT_SYMBOL_GPL(mt6358_mtkaif_calibration_enable); > > > > int mt6358_mtkaif_calibration_disable(struct snd_soc_component > > *cmpnt) > > { > > @@ -296,6 +298,7 @@ int mt6358_mtkaif_calibration_disable(struct > > snd_soc_component *cmpnt) > > capture_gpio_reset(priv); > > return 0; > > } > > +EXPORT_SYMBOL_GPL(mt6358_mtkaif_calibration_disable); > > > > int mt6358_set_mtkaif_calibration_phase(struct snd_soc_component > > *cmpnt, > > int phase_1, int phase_2) > > @@ -310,6 +313,7 @@ int mt6358_set_mtkaif_calibration_phase(struct > > snd_soc_component *cmpnt, > > phase_2 << RG_AUD_PAD_TOP_PHASE_MODE2_SFT); > > return 0; > > } > > +EXPORT_SYMBOL_GPL(mt6358_set_mtkaif_calibration_phase); > > > > /* dl pga gain */ > > enum { > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E903EC433F5 for ; Mon, 14 Mar 2022 11:56:33 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 46C621733; Mon, 14 Mar 2022 12:55:41 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 46C621733 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1647258991; bh=vpv44WyMr9l2XxHdjsyQScHpDhJeEN2amHuvUwv9piQ=; h=Subject:From:To:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=jrhmI2ZbsK9VedPxvG75FjYy0tRtU9hXJs9+1fn0mxW9pFMDbUQe9F3YQmPCMC4VE Of5Vx6lbbSy2hnok0NuFzIzqWxLLbzz9QkVP0In6uHMZK+Bd51+GtZh5YSezoDxc6X xf2NYtrdltpJdBRaosCIxLxsHbsm4cSZrtVjG9XY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C2198F8012C; Mon, 14 Mar 2022 12:55:40 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C990CF80139; Mon, 14 Mar 2022 12:55:38 +0100 (CET) Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2C9DFF80100 for ; Mon, 14 Mar 2022 12:55:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2C9DFF80100 X-UUID: 8e5afcbc685345658257b8f04900fa8c-20220314 X-UUID: 8e5afcbc685345658257b8f04900fa8c-20220314 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 316277914; Mon, 14 Mar 2022 19:55:18 +0800 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Mon, 14 Mar 2022 19:55:17 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 14 Mar 2022 19:55:16 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 14 Mar 2022 19:55:16 +0800 Message-ID: <632e51a931d1c7253eb72d8b2df281e25621bfa1.camel@mediatek.com> Subject: Re: [v3 19/19] ASoC: mediatek: mt6358: add missing EXPORT_SYMBOLs From: Jiaxin Yu To: AngeloGioacchino Del Regno , , Date: Mon, 14 Mar 2022 19:55:15 +0800 In-Reply-To: References: <20220313151023.21229-1-jiaxin.yu@mediatek.com> <20220313151023.21229-20-jiaxin.yu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, tzungbi@google.com, linux-mediatek@lists.infradead.org, trevor.wu@mediatek.com, matthias.bgg@gmail.com, aaronyu@google.com, julianbraha@gmail.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 2022-03-14 at 11:18 +0100, AngeloGioacchino Del Regno wrote: > Il 13/03/22 16:10, Jiaxin Yu ha scritto: > > This fixes the following build errors when mt6358 is configured as > > module: > > > > > > ERROR: modpost: "mt6358_set_mtkaif_protocol" > > > > [sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.ko] > > > > undefined! > > > > ERROR: modpost: "mt6358_set_mtkaif_protocol" > > > > [sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.ko] > > > > undefined! > > > > Signed-off-by: Jiaxin Yu > > Hello Jiaxin, > > Can you please add a Fixes tag to this patch and send it separately > from > the MT8186 series? > > After adding the Fixes tag: > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > > Thanks, > Angelo > Hello Angelo, OK, I will send this patch with the Fixes tag separately from the MT8186 series. Thanks, Jiaxin.Yu > > --- > > sound/soc/codecs/mt6358.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/sound/soc/codecs/mt6358.c b/sound/soc/codecs/mt6358.c > > index 1fdd2f8cf877..61f2a7632fd4 100644 > > --- a/sound/soc/codecs/mt6358.c > > +++ b/sound/soc/codecs/mt6358.c > > @@ -107,6 +107,7 @@ int mt6358_set_mtkaif_protocol(struct > > snd_soc_component *cmpnt, > > priv->mtkaif_protocol = mtkaif_protocol; > > return 0; > > } > > +EXPORT_SYMBOL_GPL(mt6358_set_mtkaif_protocol); > > > > static void playback_gpio_set(struct mt6358_priv *priv) > > { > > @@ -273,6 +274,7 @@ int mt6358_mtkaif_calibration_enable(struct > > snd_soc_component *cmpnt) > > 1 << RG_AUD_PAD_TOP_DAT_MISO_LOOPBACK_SFT); > > return 0; > > } > > +EXPORT_SYMBOL_GPL(mt6358_mtkaif_calibration_enable); > > > > int mt6358_mtkaif_calibration_disable(struct snd_soc_component > > *cmpnt) > > { > > @@ -296,6 +298,7 @@ int mt6358_mtkaif_calibration_disable(struct > > snd_soc_component *cmpnt) > > capture_gpio_reset(priv); > > return 0; > > } > > +EXPORT_SYMBOL_GPL(mt6358_mtkaif_calibration_disable); > > > > int mt6358_set_mtkaif_calibration_phase(struct snd_soc_component > > *cmpnt, > > int phase_1, int phase_2) > > @@ -310,6 +313,7 @@ int mt6358_set_mtkaif_calibration_phase(struct > > snd_soc_component *cmpnt, > > phase_2 << RG_AUD_PAD_TOP_PHASE_MODE2_SFT); > > return 0; > > } > > +EXPORT_SYMBOL_GPL(mt6358_set_mtkaif_calibration_phase); > > > > /* dl pga gain */ > > enum { > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADD38C433F5 for ; Mon, 14 Mar 2022 11:58:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lBmzKD1kt+IYZEl5gA/OFJ4YNxiQ6W1p9KymVDVMdp0=; b=3fmZ9f8aaEHaBY yF0XFdap7gjc330i0F3y0cAr8eKQxvZxfBu2yZDhp9fOi/KJdXuee1h95mmfiDn+/IXuqVQh5/ARr zCcUyE23nlwi3FZOEggUcJ3ko5iTQe/to2QyoJ48Yd1J/eybvnS0ljv/7JBw3V2dO7ZWUCrNFlsyN GpFgyIKRSY7RuP+y3vTXgD10zbOdeF3YLLDep5WWpTqeZvjQgbFrOHp5//qvD9zeyJptPi3y9lWU7 DIoL/TTCDqkpLpHl1RPIqBI53Wrg1N2y7uFqu9Ql1+N5OnDGhrR37sdBcDv3t+KOjj3Fp+4CtHE3j kE0uwpYQbW/m3ReQGSxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nTjL5-005HTs-3m; Mon, 14 Mar 2022 11:58:15 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nTjKz-005HQV-DH; Mon, 14 Mar 2022 11:58:12 +0000 X-UUID: 185cc21947d946b7a8e97db66c079cad-20220314 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=MVtKCFAueMwLBrZ6EX6ZpQPZrum3kuQ8mairUH1Uh1o=; b=MU3rDi7S/3Z5TIYVymaNU6K8kDp3OUUwA2rLjzcTVRBMfq3ovcovporWcyreKzOfvPJKMNXTcHKEdKSGLjGxfwvclqhHwCIRzZvpXQoEd+EGKFSQq0Z40dYsU5otxzkhB50iDryNjVmnq5YdbJJAadI6qs6kj8FgwnKMOk+6VXA=; X-UUID: 185cc21947d946b7a8e97db66c079cad-20220314 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1139240187; Mon, 14 Mar 2022 04:57:52 -0700 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 14 Mar 2022 04:55:24 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 14 Mar 2022 19:55:16 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 14 Mar 2022 19:55:16 +0800 Message-ID: <632e51a931d1c7253eb72d8b2df281e25621bfa1.camel@mediatek.com> Subject: Re: [v3 19/19] ASoC: mediatek: mt6358: add missing EXPORT_SYMBOLs From: Jiaxin Yu To: AngeloGioacchino Del Regno , , CC: , , , , , , , , , , Date: Mon, 14 Mar 2022 19:55:15 +0800 In-Reply-To: References: <20220313151023.21229-1-jiaxin.yu@mediatek.com> <20220313151023.21229-20-jiaxin.yu@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220314_045809_498702_A39BB4E8 X-CRM114-Status: GOOD ( 17.32 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 2022-03-14 at 11:18 +0100, AngeloGioacchino Del Regno wrote: > Il 13/03/22 16:10, Jiaxin Yu ha scritto: > > This fixes the following build errors when mt6358 is configured as > > module: > > > > > > ERROR: modpost: "mt6358_set_mtkaif_protocol" > > > > [sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.ko] > > > > undefined! > > > > ERROR: modpost: "mt6358_set_mtkaif_protocol" > > > > [sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.ko] > > > > undefined! > > > > Signed-off-by: Jiaxin Yu > > Hello Jiaxin, > > Can you please add a Fixes tag to this patch and send it separately > from > the MT8186 series? > > After adding the Fixes tag: > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > > Thanks, > Angelo > Hello Angelo, OK, I will send this patch with the Fixes tag separately from the MT8186 series. Thanks, Jiaxin.Yu > > --- > > sound/soc/codecs/mt6358.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/sound/soc/codecs/mt6358.c b/sound/soc/codecs/mt6358.c > > index 1fdd2f8cf877..61f2a7632fd4 100644 > > --- a/sound/soc/codecs/mt6358.c > > +++ b/sound/soc/codecs/mt6358.c > > @@ -107,6 +107,7 @@ int mt6358_set_mtkaif_protocol(struct > > snd_soc_component *cmpnt, > > priv->mtkaif_protocol = mtkaif_protocol; > > return 0; > > } > > +EXPORT_SYMBOL_GPL(mt6358_set_mtkaif_protocol); > > > > static void playback_gpio_set(struct mt6358_priv *priv) > > { > > @@ -273,6 +274,7 @@ int mt6358_mtkaif_calibration_enable(struct > > snd_soc_component *cmpnt) > > 1 << RG_AUD_PAD_TOP_DAT_MISO_LOOPBACK_SFT); > > return 0; > > } > > +EXPORT_SYMBOL_GPL(mt6358_mtkaif_calibration_enable); > > > > int mt6358_mtkaif_calibration_disable(struct snd_soc_component > > *cmpnt) > > { > > @@ -296,6 +298,7 @@ int mt6358_mtkaif_calibration_disable(struct > > snd_soc_component *cmpnt) > > capture_gpio_reset(priv); > > return 0; > > } > > +EXPORT_SYMBOL_GPL(mt6358_mtkaif_calibration_disable); > > > > int mt6358_set_mtkaif_calibration_phase(struct snd_soc_component > > *cmpnt, > > int phase_1, int phase_2) > > @@ -310,6 +313,7 @@ int mt6358_set_mtkaif_calibration_phase(struct > > snd_soc_component *cmpnt, > > phase_2 << RG_AUD_PAD_TOP_PHASE_MODE2_SFT); > > return 0; > > } > > +EXPORT_SYMBOL_GPL(mt6358_set_mtkaif_calibration_phase); > > > > /* dl pga gain */ > > enum { > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02FA8C433EF for ; Mon, 14 Mar 2022 11:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZkVprkeGy7keSJwHDpI4xREJqQleXXA68PvKH+EITUk=; b=t9fdoRaVOnjqa5 ne5dH5zr5QwqBFgXcXlgXwdxLIFElE+MsJUHXcd/TQjQi991gMo4lRnkIp7svlmPRL1oDtMzZW4xM VZ03BFWu/iCu+u49tQYSG5LLXRO6e7afjBRYYJCr8otfT98x6x2sy/U+EHiyLvnxphwIJeqgFHKJ9 vmSzSTF3TewvYSBlxMexB0wrG0f1lKdirTy/vNrPE5zsnQqG1KqYDdQukVK9q85v+gMEUrkhEv7OT j/ceA6hUYaUkULNd+IB32inntlesWKbwoDoEfXYzU5cm8ePh/jkQ6vh8iMv6qw/51y/ZTczkZgczR 0qu5hyfaUlHo/FPEZ4+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nTjLB-005HVY-0G; Mon, 14 Mar 2022 11:58:21 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nTjKz-005HQV-DH; Mon, 14 Mar 2022 11:58:12 +0000 X-UUID: 185cc21947d946b7a8e97db66c079cad-20220314 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=MVtKCFAueMwLBrZ6EX6ZpQPZrum3kuQ8mairUH1Uh1o=; b=MU3rDi7S/3Z5TIYVymaNU6K8kDp3OUUwA2rLjzcTVRBMfq3ovcovporWcyreKzOfvPJKMNXTcHKEdKSGLjGxfwvclqhHwCIRzZvpXQoEd+EGKFSQq0Z40dYsU5otxzkhB50iDryNjVmnq5YdbJJAadI6qs6kj8FgwnKMOk+6VXA=; X-UUID: 185cc21947d946b7a8e97db66c079cad-20220314 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1139240187; Mon, 14 Mar 2022 04:57:52 -0700 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 14 Mar 2022 04:55:24 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 14 Mar 2022 19:55:16 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 14 Mar 2022 19:55:16 +0800 Message-ID: <632e51a931d1c7253eb72d8b2df281e25621bfa1.camel@mediatek.com> Subject: Re: [v3 19/19] ASoC: mediatek: mt6358: add missing EXPORT_SYMBOLs From: Jiaxin Yu To: AngeloGioacchino Del Regno , , CC: , , , , , , , , , , Date: Mon, 14 Mar 2022 19:55:15 +0800 In-Reply-To: References: <20220313151023.21229-1-jiaxin.yu@mediatek.com> <20220313151023.21229-20-jiaxin.yu@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220314_045809_498702_A39BB4E8 X-CRM114-Status: GOOD ( 17.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2022-03-14 at 11:18 +0100, AngeloGioacchino Del Regno wrote: > Il 13/03/22 16:10, Jiaxin Yu ha scritto: > > This fixes the following build errors when mt6358 is configured as > > module: > > > > > > ERROR: modpost: "mt6358_set_mtkaif_protocol" > > > > [sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.ko] > > > > undefined! > > > > ERROR: modpost: "mt6358_set_mtkaif_protocol" > > > > [sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.ko] > > > > undefined! > > > > Signed-off-by: Jiaxin Yu > > Hello Jiaxin, > > Can you please add a Fixes tag to this patch and send it separately > from > the MT8186 series? > > After adding the Fixes tag: > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > > Thanks, > Angelo > Hello Angelo, OK, I will send this patch with the Fixes tag separately from the MT8186 series. Thanks, Jiaxin.Yu > > --- > > sound/soc/codecs/mt6358.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/sound/soc/codecs/mt6358.c b/sound/soc/codecs/mt6358.c > > index 1fdd2f8cf877..61f2a7632fd4 100644 > > --- a/sound/soc/codecs/mt6358.c > > +++ b/sound/soc/codecs/mt6358.c > > @@ -107,6 +107,7 @@ int mt6358_set_mtkaif_protocol(struct > > snd_soc_component *cmpnt, > > priv->mtkaif_protocol = mtkaif_protocol; > > return 0; > > } > > +EXPORT_SYMBOL_GPL(mt6358_set_mtkaif_protocol); > > > > static void playback_gpio_set(struct mt6358_priv *priv) > > { > > @@ -273,6 +274,7 @@ int mt6358_mtkaif_calibration_enable(struct > > snd_soc_component *cmpnt) > > 1 << RG_AUD_PAD_TOP_DAT_MISO_LOOPBACK_SFT); > > return 0; > > } > > +EXPORT_SYMBOL_GPL(mt6358_mtkaif_calibration_enable); > > > > int mt6358_mtkaif_calibration_disable(struct snd_soc_component > > *cmpnt) > > { > > @@ -296,6 +298,7 @@ int mt6358_mtkaif_calibration_disable(struct > > snd_soc_component *cmpnt) > > capture_gpio_reset(priv); > > return 0; > > } > > +EXPORT_SYMBOL_GPL(mt6358_mtkaif_calibration_disable); > > > > int mt6358_set_mtkaif_calibration_phase(struct snd_soc_component > > *cmpnt, > > int phase_1, int phase_2) > > @@ -310,6 +313,7 @@ int mt6358_set_mtkaif_calibration_phase(struct > > snd_soc_component *cmpnt, > > phase_2 << RG_AUD_PAD_TOP_PHASE_MODE2_SFT); > > return 0; > > } > > +EXPORT_SYMBOL_GPL(mt6358_set_mtkaif_calibration_phase); > > > > /* dl pga gain */ > > enum { > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel