From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available Date: Wed, 15 Jun 2016 22:50:37 +0200 Message-ID: <6330398.ySWGKSmLdn@wuerfel> References: <20160615152816.2800830-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Saeed Mahameed Cc: Matan Barak , Leon Romanovsky , "David S. Miller" , Saeed Mahameed , Or Gerlitz , Doug Ledford , Eli Cohen , Majd Dibbiny , Linux Netdev List , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Wednesday, June 15, 2016 7:04:54 PM CEST Saeed Mahameed wrote: > > Hi Arnd, > > We already took care of those issues, they only apply to Leon's tree > https://git.kernel.org/cgit/linux/kernel/git/leon/linux-rdma.git/, > this tree is meant to maintain MLX5 Shared code between netdev and > linux-rdma trees prior to submission to both trees. > > This patch is a non-shared code and it only exists in > https://git.kernel.org/cgit/linux/kernel/git/leon/linux-rdma.git/log/?h=topic/net-next-mlx5. > It is yet to be submitted to Dave's net/net-next tree. later on, this > patch and all the others will go through the normal submission > process. Ok, I see. It would be nice if the process had a way to avoid build regressions in linux-next, in particular if you already have a fix by the time a patch that introduces a problem gets added. Can you check if the fix for the second problem correctly removes the unnecessary 64-bit division (as opposed to adding a call to div_s64() or do_div()), and if it removes all traces of 'struct timespec' again? Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932428AbcFOUtP (ORCPT ); Wed, 15 Jun 2016 16:49:15 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:52169 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752819AbcFOUtL (ORCPT ); Wed, 15 Jun 2016 16:49:11 -0400 From: Arnd Bergmann To: Saeed Mahameed Cc: Matan Barak , Leon Romanovsky , "David S. Miller" , Saeed Mahameed , Or Gerlitz , Doug Ledford , Eli Cohen , Majd Dibbiny , Linux Netdev List , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available Date: Wed, 15 Jun 2016 22:50:37 +0200 Message-ID: <6330398.ySWGKSmLdn@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <20160615152816.2800830-1-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:xIs/wHGhAuUiEwtHR0/6w1co3LL59ApG1XkR81PTC1kwozghILI IeJ0vdjQmZvKXHcAN6+GcxhpWv+6XY7zoH1v4CulvijAxwgYjTHZqUYyFowz2Pfwsw1dtGq AxupD0IYp3LSy052G0WDfvEY9RBE2CErpqYqGxE8qn20aUKwYIOtYsjOKZSbp6/2GI5Zor6 3cHUmRTHcjT0WkBbl4F1g== X-UI-Out-Filterresults: notjunk:1;V01:K0:Soi8f87hr40=:oKfFrjdmw6LAEK+sqIfWco oqXRQ9So/gaQy2Ctmrc7vNB87Ih6kp3HXUUCRC866qxtDWeOW/hRGe4p7Yjjm579pZkTZqSjd tn4u9DzUkMg2wMCAz2qAKwe+7H52JhgP36WV9ceF+Cwl3XCSxqLrLut8bzqEu2QGn2ZfH6iSb 7IeG9efWAILbJUAKrD5nzz9egUF22hiaWUlUHN+T008PPnz+PmmxOSZ1Q9yJlIw0I2Npjbw8E P0ren4HXCz9cJ3DWLHdH8zzhjiVmVYFt/DASnV/1NJ/uEhSI0E3SMHvfcxjKathgd/qRlDg5o P/wPwEVE10VdD2j1jM5f4FpEh/othp5CcdfSWq7ozTbv2XIDISWyApavv8Pi1jxl0YEARiEC6 ejHjbC78YaSwrIleMATRRFtGNqs4lpPNFGfOS9dNfu4JUvoTzUe0oteG4LtbMRLg7thZ519yS qVDyVcLP6xA3+hlAGHu1yAZ76Zgn+K6abyoXh3GgOZlmv5JwWSkhwnHFE59KQjWd5HHkzoTAB yEUCXdvxaj79DuQuW3KHIWciAnZlJL7+i7PPPcTqV1BYdrCTW+R/lxhK8aqk872xg/uCYknQl wYuY6B4EdSp6G01eEfgD8y0UlViHSWVVpV/GdaMCiualWVtDGmHi5TT8Bd3cMiyg8rB3B0JCD 2zq7eNBqMMN9NfZUnFEyzkhDoBEWa6ndzb20tNvuRTNfnKvG5m/UryqkwH5GV5zO6JNQ+xT9i jw52NZXL4dME9Xwq Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, June 15, 2016 7:04:54 PM CEST Saeed Mahameed wrote: > > Hi Arnd, > > We already took care of those issues, they only apply to Leon's tree > https://git.kernel.org/cgit/linux/kernel/git/leon/linux-rdma.git/, > this tree is meant to maintain MLX5 Shared code between netdev and > linux-rdma trees prior to submission to both trees. > > This patch is a non-shared code and it only exists in > https://git.kernel.org/cgit/linux/kernel/git/leon/linux-rdma.git/log/?h=topic/net-next-mlx5. > It is yet to be submitted to Dave's net/net-next tree. later on, this > patch and all the others will go through the normal submission > process. Ok, I see. It would be nice if the process had a way to avoid build regressions in linux-next, in particular if you already have a fix by the time a patch that introduces a problem gets added. Can you check if the fix for the second problem correctly removes the unnecessary 64-bit division (as opposed to adding a call to div_s64() or do_div()), and if it removes all traces of 'struct timespec' again? Arnd