From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 2/2] virtio: allow running w/o vlan filtering Date: Wed, 15 Feb 2017 09:38:49 +0100 Message-ID: <6336921.dAlPi7hBRt@xps13> References: <1425602726-26538-1-git-send-email-stephen@networkplumber.org> <55C1EA34.3000105@6wind.com> <1945608.IVpO5Mj81A@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Vincent JARDIN To: yuanhan.liu@linux.intel.com Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id D363D9E7 for ; Wed, 15 Feb 2017 09:38:50 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id c85so35979296wmi.1 for ; Wed, 15 Feb 2017 00:38:50 -0800 (PST) In-Reply-To: <1945608.IVpO5Mj81A@xps13> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This is a very old thread which has no conclusion. Now that we have more experience with virtio, could we try to fix it properly? http://dpdk.org/patch/3897/ 2015-10-21 15:58, Thomas Monjalon: > 2015-08-05 12:49, Vincent JARDIN: > > > Use '--disable-hw-vlan-filter' in testpmd command line will allow it continue to work. > > > You can have a try. > > > > Yes, but not using this flag should not imply to exit. > > > > > I am not sure which one is better when app configures one feature but fail to negotiate it with host(which means has > > > no such capability to support this feature currently). > > > 1)The driver cheat the app, and continue to do the rest of work(of course need some hints). > > > 2)give hints and exit, then user re-run app with correct configuration. > > > > Same as Stephen: > > > > 3) give hints of capabilities, do not exit, then user app does whatever > > it wants (including exit if needed). > > I would tend to apply this patch but as it was discussed we need some > clear acknowledgement. > Huawei?