From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A320FC433DB for ; Thu, 25 Mar 2021 14:55:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F283661A01 for ; Thu, 25 Mar 2021 14:55:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F283661A01 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPROD-0002Ht-4m for qemu-devel@archiver.kernel.org; Thu, 25 Mar 2021 10:55:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPRN4-0001Pf-4v for qemu-devel@nongnu.org; Thu, 25 Mar 2021 10:54:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21581) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPRN1-0007fB-W9 for qemu-devel@nongnu.org; Thu, 25 Mar 2021 10:54:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616684038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iquOW80TbbetYKVYTIUZAABbeD14OTvhz8yE35+x9RI=; b=BepiSyxcWEh2bPM9ZYk/NO9qwc7D2t7dgPikJDed1nGff6uP6zTqkVWYB+LnpBQewF3z+1 EOXk+/pCLXKxv/UC1oySJhBSJfcTKW7KXtfsq30Y4da3OK4kG0CjtnH3BkoF6CSTPndCvZ xi29wLedsaOhunQf6ng0kNZC8dDbdug= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-294-rkuYM5S-NnSuXNKl50u_6w-1; Thu, 25 Mar 2021 10:53:56 -0400 X-MC-Unique: rkuYM5S-NnSuXNKl50u_6w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1C53B81744F; Thu, 25 Mar 2021 14:53:55 +0000 (UTC) Received: from wainer-laptop.localdomain (ovpn-116-73.gru2.redhat.com [10.97.116.73]) by smtp.corp.redhat.com (Postfix) with ESMTP id CD05A6E401; Thu, 25 Mar 2021 14:53:38 +0000 (UTC) Subject: Re: [PATCH v2 07/10] Acceptance Tests: set up SSH connection by default after boot for LinuxTest From: Wainer dos Santos Moschetta To: Cleber Rosa , qemu-devel@nongnu.org References: <20210323221539.3532660-1-crosa@redhat.com> <20210323221539.3532660-8-crosa@redhat.com> <629927fd-ce1e-a501-0e35-15360a81cc07@redhat.com> Message-ID: <633f3eb4-dbf1-3a4f-7bb0-ee202ac0f201@redhat.com> Date: Thu, 25 Mar 2021 11:53:35 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <629927fd-ce1e-a501-0e35-15360a81cc07@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wainersm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=170.10.133.124; envelope-from=wainersm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Aleksandar Rikalo , Eduardo Habkost , =?UTF-8?Q?Alex_Benn=c3=a9e?= , John Snow , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Max Reitz , Willian Rampazzo , Eric Auger , Willian Rampazzo , Thomas Huth , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Aurelien Jarno , Beraldo Leal Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/25/21 11:31 AM, Wainer dos Santos Moschetta wrote: > Hi, > > On 3/23/21 7:15 PM, Cleber Rosa wrote: >> The LinuxTest specifically targets users that need to interact with >> Linux >> guests.  So, it makes sense to give a connection by default, and avoid >> requiring it as boiler-plate code. >> >> Signed-off-by: Cleber Rosa >> --- >>   tests/acceptance/avocado_qemu/__init__.py | 5 ++++- >>   tests/acceptance/virtiofs_submounts.py    | 1 - >>   2 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/tests/acceptance/avocado_qemu/__init__.py >> b/tests/acceptance/avocado_qemu/__init__.py >> index 535f63a48d..4960142bcc 100644 >> --- a/tests/acceptance/avocado_qemu/__init__.py >> +++ b/tests/acceptance/avocado_qemu/__init__.py >> @@ -390,7 +390,7 @@ def set_up_cloudinit(self, ssh_pubkey=None): >>           cloudinit_iso = self.prepare_cloudinit(ssh_pubkey) >>           self.vm.add_args('-drive', 'file=%s,format=raw' % >> cloudinit_iso) >>   -    def launch_and_wait(self): >> +    def launch_and_wait(self, set_up_ssh_connection=True): >>           self.vm.set_console() >>           self.vm.launch() >>           console_drainer = >> datadrainer.LineLogger(self.vm.console_socket.fileno(), >> @@ -398,3 +398,6 @@ def launch_and_wait(self): >>           console_drainer.start() >>           self.log.info('VM launched, waiting for boot confirmation >> from guest') >>           cloudinit.wait_for_phone_home(('0.0.0.0', >> self.phone_home_port), self.name) >> +        if set_up_ssh_connection: >> +            self.log.info('Setting up the SSH connection') >> +            self.ssh_connect(self.username, self.ssh_key) > > Where is self.username set? Never mind, I missed patch 06. > > > - Wainer > >> diff --git a/tests/acceptance/virtiofs_submounts.py >> b/tests/acceptance/virtiofs_submounts.py >> index e10a935ac4..e019d3b896 100644 >> --- a/tests/acceptance/virtiofs_submounts.py >> +++ b/tests/acceptance/virtiofs_submounts.py >> @@ -136,7 +136,6 @@ def set_up_virtiofs(self): >>         def launch_vm(self): >>           self.launch_and_wait() >> -        self.ssh_connect('root', self.ssh_key) >>         def set_up_nested_mounts(self): >>           scratch_dir = os.path.join(self.shared_dir, 'scratch') > >