From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965032AbdAKD3P (ORCPT <rfc822;w@1wt.eu>);
        Tue, 10 Jan 2017 22:29:15 -0500
Received: from fllnx209.ext.ti.com ([198.47.19.16]:33120 "EHLO
        fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752999AbdAKD3O (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 10 Jan 2017 22:29:14 -0500
Subject: Re: [PATCH] net: netcp: correct netcp_get_stats function signature
To: David Miller <davem@davemloft.net>
References: <1484047585-16733-1-git-send-email-j-keerthy@ti.com>
 <20170110.115213.1856085394233309828.davem@davemloft.net>
CC: <w-kwok2@ti.com>, <m-karicheri2@ti.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <stephen@networkplumber.org>,
        <m-scherban@ti.com>
From: Keerthy <j-keerthy@ti.com>
Message-ID: <63403509-0dc6-42f3-4b77-897645d0cc71@ti.com>
Date: Wed, 11 Jan 2017 08:58:33 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <20170110.115213.1856085394233309828.davem@davemloft.net>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Tuesday 10 January 2017 10:22 PM, David Miller wrote:
> From: Keerthy <j-keerthy@ti.com>
> Date: Tue, 10 Jan 2017 16:56:25 +0530
>
>> @@ -1909,7 +1909,7 @@ static int netcp_setup_tc(struct net_device *dev, u32 handle, __be16 proto,
>>  	return 0;
>>  }
>>
>> -static struct rtnl_link_stats64 *
>> +void
>>  netcp_get_stats(struct net_device *ndev, struct rtnl_link_stats64 *stats)
>
> Please do not remove the static qualifier.

Sure. I will add that back.

>