All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Thomas Huth <thuth@redhat.com>,
	qemu-devel@nongnu.org, Cornelia Huck <cohuck@redhat.com>
Cc: Halil Pasic <pasic@linux.ibm.com>, qemu-s390x@nongnu.org
Subject: Re: [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes
Date: Wed, 18 Nov 2020 10:06:52 +0100	[thread overview]
Message-ID: <63561245-fea1-5e2c-7fcc-d18f7a857801@de.ibm.com> (raw)
In-Reply-To: <20201118090344.243117-1-thuth@redhat.com>



On 18.11.20 10:03, Thomas Huth wrote:
> Both headers, sysbus.h and module.h, are not required to compile this file.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

It is not a sysbus device and not a module.

Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>

> ---
>  hw/watchdog/wdt_diag288.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/hw/watchdog/wdt_diag288.c b/hw/watchdog/wdt_diag288.c
> index 71a945f0bd..4c4b6a6ab7 100644
> --- a/hw/watchdog/wdt_diag288.c
> +++ b/hw/watchdog/wdt_diag288.c
> @@ -14,12 +14,10 @@
>  #include "qemu/osdep.h"
>  #include "sysemu/reset.h"
>  #include "sysemu/watchdog.h"
> -#include "hw/sysbus.h"
>  #include "qemu/timer.h"
>  #include "hw/watchdog/wdt_diag288.h"
>  #include "migration/vmstate.h"
>  #include "qemu/log.h"
> -#include "qemu/module.h"
>  
>  static WatchdogTimerModel model = {
>      .wdt_name = TYPE_WDT_DIAG288,
> 


  reply	other threads:[~2020-11-18  9:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-18  9:03 [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes Thomas Huth
2020-11-18  9:06 ` Christian Borntraeger [this message]
2020-11-18 11:06 ` Philippe Mathieu-Daudé
2020-11-18 14:22   ` Markus Armbruster
2020-11-18 14:30     ` Peter Maydell
2020-11-23  8:16       ` Thomas Huth
2020-11-23 10:47         ` Markus Armbruster
2020-11-23 15:59           ` Cornelia Huck
2020-11-23 18:41             ` Thomas Huth
2020-11-24 11:02               ` Cornelia Huck
2020-11-24 11:03 ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63561245-fea1-5e2c-7fcc-d18f7a857801@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.