From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jPBuc-0001gd-6f for mharc-grub-devel@gnu.org; Thu, 16 Apr 2020 17:19:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38223) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPBuY-0001f5-I8 for grub-devel@gnu.org; Thu, 16 Apr 2020 17:19:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jPBuW-0004Is-Tp for grub-devel@gnu.org; Thu, 16 Apr 2020 17:19:01 -0400 Received: from mga17.intel.com ([192.55.52.151]:44309) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jPBuW-0004Gt-Jz for grub-devel@gnu.org; Thu, 16 Apr 2020 17:19:00 -0400 IronPort-SDR: xSU0Rt/KxlVs8EMtxAhL4ZWgWG5xAl5njEsp9KkBoi5+Xv26oKcyAaqocQzXph4/nKsCZrBiQn 9LCQKS5+RSfA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 14:18:57 -0700 IronPort-SDR: /TioLoCghYEAG9P6c1TpzQMPzUlh0zz3ZImfMrW8Xpkt297PHfK/nurvytdh77bku4ZijjXPMP 5p/U7WXM/Qdg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,392,1580803200"; d="scan'208";a="332984741" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by orsmga001.jf.intel.com with ESMTP; 16 Apr 2020 14:18:56 -0700 Received: from orsmsx162.amr.corp.intel.com (10.22.240.85) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Apr 2020 14:18:56 -0700 Received: from orsmsx102.amr.corp.intel.com ([169.254.3.107]) by ORSMSX162.amr.corp.intel.com ([169.254.3.22]) with mapi id 14.03.0439.000; Thu, 16 Apr 2020 14:18:56 -0700 From: "Chen, Zide" To: Daniel Kiper CC: "grub-devel@gnu.org" Subject: RE: [PATCH V4] multiboot2: Implement quirk-modules-after-kernel Thread-Topic: [PATCH V4] multiboot2: Implement quirk-modules-after-kernel Thread-Index: AQHWDSDJ853BRFpcc06Ak4xciv/VK6h5jEoA//+dC+CAAxebgP//w14ggABIDPA= Date: Thu, 16 Apr 2020 21:18:55 +0000 Message-ID: <636297D5EBADD745BF4BDD83AA58243931FE1FED@ORSMSX102.amr.corp.intel.com> References: <20200407210859.215-1-zide.chen@intel.com> <20200414200928.mh3vqbkisqftxk2v@tomti.i.net-space.pl> <636297D5EBADD745BF4BDD83AA58243931FDCD74@ORSMSX102.amr.corp.intel.com> <20200416132833.icr4xqfjrrh36uhg@tomti.i.net-space.pl> <636297D5EBADD745BF4BDD83AA58243931FE1CF8@ORSMSX102.amr.corp.intel.com> In-Reply-To: <636297D5EBADD745BF4BDD83AA58243931FE1CF8@ORSMSX102.amr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 192.55.52.151 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2020 21:19:03 -0000 Hi Daniel, > -----Original Message----- > From: Chen, Zide > Sent: Thursday, April 16, 2020 10:41 AM > To: 'Daniel Kiper' > Cc: grub-devel@gnu.org > Subject: RE: [PATCH V4] multiboot2: Implement quirk-modules-after-kernel >=20 > > > +------------------+ > > > u16 | type =3D 22 | > > > u16 | flags | > > > u32 | size =3D 20 | > > > u32 | min_addr | > > > > s/u32/u64/ >=20 > Currently modules are loaded at 32bit address only. But yes, I agree that= 'u64' would > make it more flexible. >=20 > > > u32 | max_addr | > > > > s/u32/u64/ > > > > > u32 | preference | > > > > Please put preference immediately behind the size. > Sure, will do. Just noticed that if we change min/max_addr to u64, and move preference rig= ht after size, it could have struct packing issue. For example: struct multiboot_header_tag_module_relocatable { multiboot_uint16_t type; multiboot_uint16_t flags; multiboot_uint32_t size; multiboot_uint32_t preference;=20 multiboot_uint64_t min_addr; // address is compiler dependent multiboot_uint64_t max_addr; }; So I still propose to put preference after max_addr. I wrote the code based= on this proposed new tag, and will send out the doc change and implementation for review shortly. -Zide