From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: Automatic dependencies are out of sync
Date: Thu, 6 Sep 2018 09:39:57 +0100 [thread overview]
Message-ID: <63716215-51f4-242d-15b4-a3eca28f70b2@citrix.com> (raw)
In-Reply-To: <02463da8-eeff-f254-b8c2-5c1e?= =?UTF-8?Q?5b96ab53@suse.com>
On 06/09/18 09:27, Juergen Gross wrote:
> On 06/09/18 10:10, Jan Beulich wrote:
>
>>> %: %.o
>>> gcc $< -o $@
>>>
>>> -include $(DEPS)
>>>
>>> -->8 snip here 8<--
>>>
>>> So the basic ideas are:
>>>
>>> - add a rule for constructing the .d files
>>> - let the build depend on the .d2 files
>> IOW I wonder whether this really is any different from what we
>> do now (minus bugs/quirks in make itself, of course). And from this
>> as well as your original mail I still don't understand what's actually
>> broken with the current approach.
> The main problem is that the .d2 files used for determining which object
> files need to be (re-)built are based on the build before the last one.
> I'm not sure this is always the case, but at least when starting with a
> clean tree I need two invocations of "make" to get all .d2 files built.
As an alternative, can we see about fixing the real bug and getting rid
of .d2 all together?
I still revert that change for some of my builds, because it completely
breaks the incremental build (by causing most things to be rebuilt).
Whatever the underlying issue is, fixing it by sed'ing the dependency
files is gross hack, rather than a fix.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-09-06 8:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 14:05 Automatic dependencies are out of sync Juergen Gross
2018-09-06 7:34 ` Juergen Gross
2018-09-06 8:10 ` Jan Beulich
[not found] ` <5B90E0DE02000078001E5D5A@suse.com>
2018-09-06 8:27 ` Juergen Gross
2018-09-06 10:26 ` Jan Beulich
[not found] ` <02463da8-eeff-f254-b8c2-5c1e?= =?UTF-8?Q?5b96ab53@suse.com>
2018-09-06 8:39 ` Andrew Cooper [this message]
[not found] ` <02463da8-eeff-f?= =?UTF-8?Q?254-b8c2-5c1e5b96ab53@suse.com>
[not found] ` <5B9100F302000078001E5E17@suse.co?= =?UTF-8?Q?m>
2018-09-06 12:21 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63716215-51f4-242d-15b4-a3eca28f70b2@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.