From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH 3/6] clk: Add driver for Maxim-8997 PMIC clocks Date: Mon, 7 Nov 2016 12:01:29 -0300 Message-ID: <63750c2f-35cb-91ab-276b-c788f51081cb@osg.samsung.com> References: <1478513376-14307-1-git-send-email-pankaj.dubey@samsung.com> <1478513376-14307-4-git-send-email-pankaj.dubey@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1478513376-14307-4-git-send-email-pankaj.dubey@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Pankaj Dubey , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: devicetree@vger.kernel.org, thomas.ab@samsung.com, kgene@kernel.org, Michael Turquette , krzk@kernel.org, Rob Herring , myungjoo.ham@samsung.com, linux-clk@vger.kernel.org List-Id: devicetree@vger.kernel.org Hello Pankaj, On 11/07/2016 07:09 AM, Pankaj Dubey wrote: > The MAX8997 PMIC has 32.786kHz crystal oscillator which provides an > accurate low frequency clock for MAX8997 internal circuit as well as > external circuit. This patch adds support for these two clocks. > > CC: Michael Turquette > CC: Rob Herring > CC: devicetree@vger.kernel.org > CC: linux-clk@vger.kernel.org > Signed-off-by: Pankaj Dubey > --- What kernel version are you basing this on? The Maxim common clock code is going away for v4.9 and instead the clk-max77686 driver supports both 77686 and 77802 clocks. See commit 8ad313fe4e00 ("clk: max77686: Combine Maxim max77686 and max77802 driver"). Since the 8997 clock IP looks very similar to 77802 AFAICT, you should also extend the clk-max77686 driver to have 8997 support. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 3/6] clk: Add driver for Maxim-8997 PMIC clocks To: Pankaj Dubey , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1478513376-14307-1-git-send-email-pankaj.dubey@samsung.com> <1478513376-14307-4-git-send-email-pankaj.dubey@samsung.com> From: Javier Martinez Canillas Cc: krzk@kernel.org, kgene@kernel.org, thomas.ab@samsung.com, myungjoo.ham@samsung.com, Michael Turquette , Rob Herring , devicetree@vger.kernel.org, linux-clk@vger.kernel.org Message-ID: <63750c2f-35cb-91ab-276b-c788f51081cb@osg.samsung.com> Date: Mon, 7 Nov 2016 12:01:29 -0300 MIME-Version: 1.0 In-Reply-To: <1478513376-14307-4-git-send-email-pankaj.dubey@samsung.com> Content-Type: text/plain; charset=windows-1252 List-ID: Hello Pankaj, On 11/07/2016 07:09 AM, Pankaj Dubey wrote: > The MAX8997 PMIC has 32.786kHz crystal oscillator which provides an > accurate low frequency clock for MAX8997 internal circuit as well as > external circuit. This patch adds support for these two clocks. > > CC: Michael Turquette > CC: Rob Herring > CC: devicetree@vger.kernel.org > CC: linux-clk@vger.kernel.org > Signed-off-by: Pankaj Dubey > --- What kernel version are you basing this on? The Maxim common clock code is going away for v4.9 and instead the clk-max77686 driver supports both 77686 and 77802 clocks. See commit 8ad313fe4e00 ("clk: max77686: Combine Maxim max77686 and max77802 driver"). Since the 8997 clock IP looks very similar to 77802 AFAICT, you should also extend the clk-max77686 driver to have 8997 support. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier@osg.samsung.com (Javier Martinez Canillas) Date: Mon, 7 Nov 2016 12:01:29 -0300 Subject: [PATCH 3/6] clk: Add driver for Maxim-8997 PMIC clocks In-Reply-To: <1478513376-14307-4-git-send-email-pankaj.dubey@samsung.com> References: <1478513376-14307-1-git-send-email-pankaj.dubey@samsung.com> <1478513376-14307-4-git-send-email-pankaj.dubey@samsung.com> Message-ID: <63750c2f-35cb-91ab-276b-c788f51081cb@osg.samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Pankaj, On 11/07/2016 07:09 AM, Pankaj Dubey wrote: > The MAX8997 PMIC has 32.786kHz crystal oscillator which provides an > accurate low frequency clock for MAX8997 internal circuit as well as > external circuit. This patch adds support for these two clocks. > > CC: Michael Turquette > CC: Rob Herring > CC: devicetree at vger.kernel.org > CC: linux-clk at vger.kernel.org > Signed-off-by: Pankaj Dubey > --- What kernel version are you basing this on? The Maxim common clock code is going away for v4.9 and instead the clk-max77686 driver supports both 77686 and 77802 clocks. See commit 8ad313fe4e00 ("clk: max77686: Combine Maxim max77686 and max77802 driver"). Since the 8997 clock IP looks very similar to 77802 AFAICT, you should also extend the clk-max77686 driver to have 8997 support. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America