From: Dan Williams <dan.j.williams@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jens Axboe <axboe@kernel.dk>,
Alison Schofield <alison.schofield@intel.com>,
"Vishal Verma" <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
"Ben Widawsky" <bwidawsk@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Jeremy Kerr <jk@ozlabs.org>, Joel Stanley <joel@jms.id.au>,
Alistar Popple <alistair@popple.id.au>,
Eddie James <eajames@linux.ibm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Jilin Yuan <yuanjilin@cdjrlc.com>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
Alan Stern <stern@rowland.harvard.edu>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Gunthorpe <jgg@ziepe.ca>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Won Chung <wonchung@google.com>, <linux-block@vger.kernel.org>,
<linux-cxl@vger.kernel.org>, <linux-fsi@lists.ozlabs.org>,
<linux-usb@vger.kernel.org>
Subject: RE: [PATCH 4/5] driver core: make struct device_type.devnode() take a const *
Date: Wed, 23 Nov 2022 11:23:36 -0800 [thread overview]
Message-ID: <637e733838b5f_12cdff29466@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20221123122523.1332370-4-gregkh@linuxfoundation.org>
Greg Kroah-Hartman wrote:
> The devnode() callback in struct device_type should not be modifying the
> device that is passed into it, so mark it as a const * and propagate the
> function signature changes out into all relevant subsystems that use
> this callback.
>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Alison Schofield <alison.schofield@intel.com>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Cc: Ira Weiny <ira.weiny@intel.com>
> Cc: Ben Widawsky <bwidawsk@kernel.org>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Jeremy Kerr <jk@ozlabs.org>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Alistar Popple <alistair@popple.id.au>
> Cc: Eddie James <eajames@linux.ibm.com>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Jilin Yuan <yuanjilin@cdjrlc.com>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> Cc: Won Chung <wonchung@google.com>
> Cc: linux-block@vger.kernel.org
> Cc: linux-cxl@vger.kernel.org
> Cc: linux-fsi@lists.ozlabs.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[..]
> diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
> index 20ce488a7754..6ae8d0bdc61b 100644
> --- a/drivers/cxl/core/memdev.c
> +++ b/drivers/cxl/core/memdev.c
> @@ -27,7 +27,7 @@ static void cxl_memdev_release(struct device *dev)
> kfree(cxlmd);
> }
>
> -static char *cxl_memdev_devnode(struct device *dev, umode_t *mode, kuid_t *uid,
> +static char *cxl_memdev_devnode(const struct device *dev, umode_t *mode, kuid_t *uid,
> kgid_t *gid)
> {
> return kasprintf(GFP_KERNEL, "cxl/%s", dev_name(dev));
For the CXL bit:
Acked-by: Dan Williams <dan.j.williams@intel.com>
next prev parent reply other threads:[~2022-11-23 19:23 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 12:25 [PATCH 1/5] driver core: make struct class.dev_uevent() take a const * Greg Kroah-Hartman
2022-11-23 12:25 ` [PATCH 2/5] driver core: make struct class.devnode() " Greg Kroah-Hartman
2022-11-23 12:25 ` Greg Kroah-Hartman
2022-11-23 12:25 ` Greg Kroah-Hartman
2022-11-23 12:25 ` Greg Kroah-Hartman
2022-11-25 11:55 ` Mauro Carvalho Chehab
2022-11-25 11:55 ` Mauro Carvalho Chehab
2022-11-25 11:55 ` Mauro Carvalho Chehab
2022-11-25 12:40 ` Sumit Semwal
2022-11-25 12:40 ` Sumit Semwal
2022-11-25 12:40 ` Sumit Semwal
2022-11-23 12:25 ` [PATCH 3/5] driver core: make struct device_type.uevent() " Greg Kroah-Hartman
2022-11-23 12:25 ` Greg Kroah-Hartman
2022-11-23 12:25 ` Greg Kroah-Hartman
2022-11-23 12:38 ` Rafael J. Wysocki
2022-11-23 12:38 ` Rafael J. Wysocki
2022-11-23 12:38 ` Rafael J. Wysocki
2023-01-11 9:51 ` Greg Kroah-Hartman
2023-01-11 9:51 ` Greg Kroah-Hartman
2023-01-11 9:51 ` Greg Kroah-Hartman
2022-11-23 13:14 ` Maximilian Luz
2022-11-23 13:14 ` Maximilian Luz
2022-11-23 13:14 ` Maximilian Luz
2022-11-23 13:34 ` Andy Shevchenko
2022-11-23 13:34 ` Andy Shevchenko
2022-11-23 13:34 ` Andy Shevchenko
2022-11-23 13:59 ` Maximilian Luz
2022-11-23 13:59 ` Maximilian Luz
2022-11-23 13:59 ` Maximilian Luz
2022-11-23 14:52 ` Matthew Wilcox
2022-11-23 14:52 ` Matthew Wilcox
2022-11-23 14:52 ` Matthew Wilcox
2022-11-23 15:14 ` Maximilian Luz
2022-11-23 15:14 ` Maximilian Luz
2022-11-23 15:14 ` Maximilian Luz
2022-11-23 15:37 ` Greg Kroah-Hartman
2022-11-23 15:37 ` Greg Kroah-Hartman
2022-11-23 15:37 ` Greg Kroah-Hartman
2022-11-23 15:48 ` Maximilian Luz
2022-11-23 15:48 ` Maximilian Luz
2022-11-23 15:48 ` Maximilian Luz
2022-11-23 15:52 ` Greg Kroah-Hartman
2022-11-23 15:52 ` Greg Kroah-Hartman
2022-11-23 15:52 ` Greg Kroah-Hartman
2022-11-23 16:25 ` Jason Gunthorpe
2022-11-23 16:25 ` Jason Gunthorpe
2022-11-23 16:25 ` Jason Gunthorpe
2022-11-23 17:01 ` Greg Kroah-Hartman
2022-11-23 17:01 ` Greg Kroah-Hartman
2022-11-23 17:01 ` Greg Kroah-Hartman
2022-11-23 17:29 ` Jason Gunthorpe
2022-11-23 17:29 ` Jason Gunthorpe
2022-11-23 17:29 ` Jason Gunthorpe
2022-11-23 17:49 ` Matthew Wilcox
2022-11-23 17:49 ` Matthew Wilcox
2022-11-23 17:49 ` Matthew Wilcox
2022-11-23 17:55 ` Jason Gunthorpe
2022-11-23 17:55 ` Jason Gunthorpe
2022-11-23 17:55 ` Jason Gunthorpe
2022-11-23 18:00 ` Matthew Wilcox
2022-11-23 18:00 ` Matthew Wilcox
2022-11-23 18:00 ` Matthew Wilcox
2022-12-01 18:43 ` Greg Kroah-Hartman
2022-12-01 18:43 ` Greg Kroah-Hartman
2022-12-01 18:43 ` Greg Kroah-Hartman
2022-11-23 18:10 ` Greg Kroah-Hartman
2022-11-23 18:10 ` Greg Kroah-Hartman
2022-11-23 18:10 ` Greg Kroah-Hartman
2022-11-23 18:25 ` Jason Gunthorpe
2022-11-23 18:25 ` Jason Gunthorpe
2022-11-23 18:25 ` Jason Gunthorpe
2022-11-23 19:06 ` Greg Kroah-Hartman
2022-11-23 19:06 ` Greg Kroah-Hartman
2022-11-23 19:06 ` Greg Kroah-Hartman
2022-11-23 23:24 ` Barnabás Pőcze
2022-11-23 23:24 ` Barnabás Pőcze
2022-11-23 23:24 ` Barnabás Pőcze
2022-11-23 13:56 ` Mika Westerberg
2022-11-23 13:56 ` Mika Westerberg
2022-11-23 13:56 ` Mika Westerberg
2023-01-11 9:52 ` Greg Kroah-Hartman
2023-01-11 9:52 ` Greg Kroah-Hartman
2023-01-11 9:52 ` Greg Kroah-Hartman
2022-11-25 11:56 ` Mauro Carvalho Chehab
2022-11-25 11:56 ` Mauro Carvalho Chehab
2022-11-25 11:56 ` Mauro Carvalho Chehab
2023-01-11 9:52 ` Greg Kroah-Hartman
2023-01-11 9:52 ` Greg Kroah-Hartman
2023-01-11 9:52 ` Greg Kroah-Hartman
2022-11-23 12:25 ` [PATCH 4/5] driver core: make struct device_type.devnode() " Greg Kroah-Hartman
2022-11-23 19:23 ` Dan Williams [this message]
2023-01-11 9:46 ` Greg Kroah-Hartman
2022-11-23 12:25 ` [PATCH 5/5] driver core: device_get_devnode() should " Greg Kroah-Hartman
2022-11-23 12:39 ` Rafael J. Wysocki
2022-11-23 13:36 ` Andy Shevchenko
2023-01-11 9:47 ` Greg Kroah-Hartman
2022-11-23 12:38 ` [PATCH 1/5] driver core: make struct class.dev_uevent() " Rafael J. Wysocki
2022-11-24 15:03 ` Sebastian Reichel
2022-11-25 11:54 ` Mauro Carvalho Chehab
2022-11-25 23:51 ` Bart Van Assche
2022-11-27 13:45 ` Greg Kroah-Hartman
2022-11-28 2:38 ` Bart Van Assche
2022-11-28 17:25 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=637e733838b5f_12cdff29466@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alison.schofield@intel.com \
--cc=alistair@popple.id.au \
--cc=andriy.shevchenko@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=bwidawsk@kernel.org \
--cc=eajames@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=ira.weiny@intel.com \
--cc=jgg@ziepe.ca \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linux-block@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=tglx@linutronix.de \
--cc=vishal.l.verma@intel.com \
--cc=wonchung@google.com \
--cc=yuanjilin@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.