From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88DBEC433E2 for ; Tue, 15 Sep 2020 08:34:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EF7F21D7B for ; Tue, 15 Sep 2020 08:34:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726133AbgIOIem (ORCPT ); Tue, 15 Sep 2020 04:34:42 -0400 Received: from mail-m1271.qiye.163.com ([115.236.127.1]:57096 "EHLO mail-m1271.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726130AbgIOIem (ORCPT ); Tue, 15 Sep 2020 04:34:42 -0400 Received: from [127.0.0.1] (unknown [157.0.31.124]) by mail-m1271.qiye.163.com (Hmail) with ESMTPA id 78A455822AE; Tue, 15 Sep 2020 16:34:38 +0800 (CST) Subject: Re: [PATCH] blk-mq: fix hang issue in blk_queue_enter() To: Markus Elfring Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Jens Axboe , onlyfever@icloud.com, linux-block@vger.kernel.org References: <11a3283f-7857-0448-7424-8840fb5f2ea7@web.de> From: Yang Yang Message-ID: <63816f52-4850-f586-ce73-3775ecc38da9@vivo.com> Date: Tue, 15 Sep 2020 16:34:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <11a3283f-7857-0448-7424-8840fb5f2ea7@web.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgYFAkeWUFZS1VLWVdZKFlBSE83V1ktWUFJV1kPCR oVCBIfWUFZSxpMHxkZGUlLTh4eVkpNS0tKTkNDTENNT01VEwETFhoSFyQUDg9ZV1kWGg8SFR0UWU FZT0tIVUpKS0hKQ1VKS0tZBg++ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6K1E6Iyo5Hj8sNBYzURgNUSEN LEwKCxBVSlVKTUtLSk5DQ0xCS01LVTMWGhIXVQIaFRxVAhoVHDsNEg0UVRgUFkVZV1kSC1lBWUpO TFVLVUhKVUpJT1lXWQgBWUFKTE9KNwY+ X-HM-Tid: 0a7490e6cb8398b6kuuu78a455822ae Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 2020/9/14 21:35, Markus Elfring wrote: > … >> The solution is to wake up the mq_freeze_wq after runtime suspend >> completed, make blk_pm_request_resume() reexamine the q->rpm_status flag. > > * Would an imperative wording become helpful for the change description? > > * How do you think about to add the tag “Fixes” to the commit message? > Thank you for your suggestions. -- Yang Yang From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yang Yang Date: Tue, 15 Sep 2020 08:34:38 +0000 Subject: Re: [PATCH] blk-mq: fix hang issue in blk_queue_enter() Message-Id: <63816f52-4850-f586-ce73-3775ecc38da9@vivo.com> List-Id: References: <11a3283f-7857-0448-7424-8840fb5f2ea7@web.de> In-Reply-To: <11a3283f-7857-0448-7424-8840fb5f2ea7@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Markus Elfring Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Jens Axboe , onlyfever@icloud.com, linux-block@vger.kernel.org On 2020/9/14 21:35, Markus Elfring wrote: > … >> The solution is to wake up the mq_freeze_wq after runtime suspend >> completed, make blk_pm_request_resume() reexamine the q->rpm_status flag. > > * Would an imperative wording become helpful for the change description? > > * How do you think about to add the tag “Fixes” to the commit message? > Thank you for your suggestions. -- Yang Yang