From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v8 3/9] pci: split match and probe function
Date: Wed, 18 Jan 2017 00:31:36 +0100
Message-ID: <6385545.1JoApMrEe4@xps13>
References: <1484647774-28984-1-git-send-email-shreyansh.jain@nxp.com>
 <1484660264-6531-1-git-send-email-shreyansh.jain@nxp.com>
 <1484660264-6531-4-git-send-email-shreyansh.jain@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id C096B1094
 for <dev@dpdk.org>; Wed, 18 Jan 2017 00:31:38 +0100 (CET)
Received: by mail-wm0-f52.google.com with SMTP id r144so247856443wme.1
 for <dev@dpdk.org>; Tue, 17 Jan 2017 15:31:38 -0800 (PST)
In-Reply-To: <1484660264-6531-4-git-send-email-shreyansh.jain@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-01-17 19:07, Shreyansh Jain:
> +static int
> +rte_eal_pci_detach_dev(struct rte_pci_driver *dr,
> +               struct rte_pci_device *dev)
> +{
> +       int ret;
> +       struct rte_pci_addr *loc;
> +
> +       if ((dr == NULL) || (dev == NULL))
> +               return -EINVAL;
> +
> +       ret = rte_pci_match(dr, dev);

I do not understand this function.
The driver should be known by the device at this stage.
Why specifying a driver as parameter?

I know it is not new in this series, but
pci_detach_all_drivers(struct rte_pci_device *dev) makes no sense to me.