From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Song Liu <song@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>, bpf <bpf@vger.kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>
Subject: Re: [PATCH bpf-next 1/3] samples/bpf: Fix building out of srctree
Date: Tue, 28 Jul 2020 23:37:22 +0200 [thread overview]
Message-ID: <6386aaf1ecbab2384bc64e5db5e64b1b4c11190e.camel@linux.ibm.com> (raw)
In-Reply-To: <561d45c27df34a412aed676293078bcac5c1d91a.camel@linux.ibm.com>
On Tue, 2020-07-28 at 23:12 +0200, Ilya Leoshkevich wrote:
> On Tue, 2020-07-28 at 13:48 -0700, Song Liu wrote:
> > On Tue, Jul 28, 2020 at 5:15 AM Ilya Leoshkevich <iii@linux.ibm.com
> > >
> > wrote:
> > > Building BPF samples out of srctree fails, because the output
> > > directory
> > > for progs shared with selftests (CGROUP_HELPERS, TRACE_HELPERS)
> > > is
> > > missing and the compiler cannot create output files.
> > >
> > > Fix by creating the output directory in Makefile.
> >
> > What is the make command line we use here? I am trying:
> >
> > make M=samples/bpf O=./xxx
> >
> > w/o this patch, make created ./xxx/samples/bpf.
> >
> > Did I miss something?
>
> I'm using
>
> make O=$HOME/linux-build 'CC=ccache gcc' M=samples/bpf -j12
>
> My make version is GNU Make 4.2.1.
Hmm, I wanted to elaborate a little bit more on why this fix should
work, and realized that it works only by accident: cgroup_helpers
and trace_helpers are userspace code, and my fix modifies the recipe
for building bpf programs.
Please disregard this patch - I will have to come up with a better fix.
next prev parent reply other threads:[~2020-07-28 21:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 12:00 [PATCH bpf-next 0/3] samples/bpf: A couple s390 fixes Ilya Leoshkevich
2020-07-28 12:00 ` [PATCH bpf-next 1/3] samples/bpf: Fix building out of srctree Ilya Leoshkevich
2020-07-28 20:48 ` Song Liu
2020-07-28 21:12 ` Ilya Leoshkevich
2020-07-28 21:37 ` Ilya Leoshkevich [this message]
2020-07-28 12:00 ` [PATCH bpf-next 2/3] samples/bpf: Fix test_map_in_map on s390 Ilya Leoshkevich
2020-07-28 20:59 ` Song Liu
2020-07-28 22:05 ` Ilya Leoshkevich
2020-07-28 12:00 ` [PATCH bpf-next 3/3] libbpf: Use bpf_probe_read_kernel Ilya Leoshkevich
2020-07-28 19:11 ` Andrii Nakryiko
2020-07-28 21:16 ` Daniel Borkmann
2020-07-29 4:06 ` Andrii Nakryiko
2020-07-29 21:01 ` Daniel Borkmann
2020-07-29 21:36 ` Andrii Nakryiko
2020-07-29 21:54 ` Daniel Borkmann
2020-07-29 22:05 ` Andrii Nakryiko
2020-07-29 22:12 ` Daniel Borkmann
2020-07-29 22:17 ` Andrii Nakryiko
2020-07-31 17:41 ` Andrii Nakryiko
2020-07-31 20:34 ` Daniel Borkmann
2020-08-05 18:32 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6386aaf1ecbab2384bc64e5db5e64b1b4c11190e.camel@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.