All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: buildroot@busybox.net
Subject: [Buildroot] [Bug 13586] New: grub failure with BR2_OPTIMIZE_3
Date: Thu, 27 May 2021 16:28:29 +0000	[thread overview]
Message-ID: <638b4284c5ac4639b393d2ade58994dc@AcuMS.aculab.com> (raw)
In-Reply-To: <20210527154435.GV3208066@scaer>

From: Yann E. MORIN
> Sent: 27 May 2021 16:45
> 
> Andreas, All,
> 
> On 2021-05-27 17:33 +0200, Andreas Hilse via buildroot spake thusly:
> > following up on this because I also encountered this error.
> >
> > There is a bug report on the grub bug tracker by Tony Battersby who
> > bisected the error down to a certain patch/bugfix:
> > https://savannah.gnu.org/bugs/?60458
> >
> > The mentioned patch has also been included in buildroot as
> > boot/grub2/0132-kern-parser-Fix-a-stack-buffer-overflow.patch with
> > commit e840f2d469.
> >
> > I can also confirm, that removing that patch fixes the issue of grub
> > loop of endless rebooting.
> 
> Thanks for the report.
> 
> However, this patch is a security fix, so reverting it is not so nice
> either.
> 
> Since it seems that using another optimisation level works arorund the
> issue, I would be more inclined to change that, e.g. to -Os, as the
> reporter seems to imply it works for them.
> 
> Would you please send a patch with such a workaround, please?

Hmmmm if the code fails to compile with -O2 it is probably broken.
(Unlike -O3 which tends to be a compiler bug!)

So they may have replaced one security bug with another one.
The patch is too big to eyeball for errors.

I did manage to build grub with AVX support.
Spent ages working out why it wouldn't boot a kernel on an Atom.
(I knew userspace was broken.)
It is probably worth passing -mno-avx when building grub.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

  reply	other threads:[~2021-05-27 16:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-07 21:46 bugzilla at busybox.net
2021-05-27 15:33 ` Andreas Hilse
2021-05-27 15:44   ` Yann E. MORIN
2021-05-27 16:28     ` David Laight [this message]
2021-05-27 20:37       ` Yann E. MORIN
2021-05-28 13:48         ` Andreas Hilse
2021-05-28 21:42           ` Yann E. MORIN
2021-05-31 10:22             ` Andreas Hilse
2021-06-04 20:52               ` Yann E. MORIN
2021-06-02 20:33 ` [Buildroot] [Bug 13586] " bugzilla at busybox.net

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=638b4284c5ac4639b393d2ade58994dc@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=buildroot@busybox.net \
    --subject='Re: [Buildroot] [Bug 13586] New: grub failure with BR2_OPTIMIZE_3' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.