From mboxrd@z Thu Jan 1 00:00:00 1970 From: kernel@martin.sperl.org Subject: Re: [PATCH V2 9/9] spi: bcm2835aux: make the polling duration limits configurable Date: Mon, 25 Mar 2019 10:49:48 +0100 Message-ID: <63AAA1F6-25FB-4C58-9F9B-9377E94CB3B2@martin.sperl.org> References: <20190324175002.28969-1-kernel@martin.sperl.org> <20190324175002.28969-10-kernel@martin.sperl.org> <4da737f4-acf2-c70d-59cd-0efdf2ec21d4@i2se.com> Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-spi@vger.kernel.org, Eric Anholt , Mark Brown , linux-rpi-kernel@lists.infradead.org, Hubert Denkmair , linux-arm-kernel@lists.infradead.org To: Stefan Wahren Return-path: In-Reply-To: <4da737f4-acf2-c70d-59cd-0efdf2ec21d4@i2se.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org > On 25.03.2019, at 10:44, Stefan Wahren wrote: > > Hi Martin, > > Am 24.03.19 um 18:50 schrieb kernel@martin.sperl.org: >> From: Martin Sperl >> >> +/* define polling limits */ >> +unsigned int polling_limit_us = 30; >> +module_param(polling_limit_us, uint, 0664); >> +MODULE_PARM_DESC(polling_limit_us, >> + "time in us to run a transfer in polling mode\n"); >> + > could you please document the case polling_limit_us = 0 ? Means no polling under any circumstances - I can add it as a comment in V3. martin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3683AC4360F for ; Mon, 25 Mar 2019 09:50:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 084B420870 for ; Mon, 25 Mar 2019 09:50:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kg1CJU3o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 084B420870 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=martin.sperl.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Date: In-Reply-To:From:Subject:Mime-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NUW3fajL9LGQAcIy67AgU0dipJ1xiTpHqixPOGFz1uc=; b=kg1CJU3oOMlsJq VuZWGNgD/aPD7NUZweMAF2h6Gyii20vbrMB66heoIh6Kx4rCtb01dY9B9icUo/lIQ9gMSk8muAUTJ loYUFhGkyT3O6DeUxWnSw+a1/wlex22RjN1btveZlXXm13MIXmSieH04BqVrSVDgAcsv1jWXk8IgP bZ46POXEj27HREjuRVAI8Ao5yIjHYgzX0okZd+ae6BVB95czg0ZV3RiY0ZA3jGF//6CusioigW6gl jVV4oCyYt414amOvImXcGTp7sLhJjxREKNKnZfXle2HT0mP3PmiUd4Vei9QvVapK0H98SwW6rcr0p PtTEuUTAgU0BG8FF24zA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8MFJ-0007AD-J3; Mon, 25 Mar 2019 09:50:21 +0000 Received: from 212-186-180-163.static.upcbusiness.at ([212.186.180.163] helo=cgate.sperl.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8MF3-0005Q9-2I; Mon, 25 Mar 2019 09:50:10 +0000 Received: from msmac.intern.sperl.org (account martin@sperl.org [10.10.10.11] verified) by sperl.org (CommuniGate Pro SMTP 6.2.1 _community_) with ESMTPSA id 7759494; Mon, 25 Mar 2019 09:49:49 +0000 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH V2 9/9] spi: bcm2835aux: make the polling duration limits configurable From: kernel@martin.sperl.org In-Reply-To: <4da737f4-acf2-c70d-59cd-0efdf2ec21d4@i2se.com> Date: Mon, 25 Mar 2019 10:49:48 +0100 Message-Id: <63AAA1F6-25FB-4C58-9F9B-9377E94CB3B2@martin.sperl.org> References: <20190324175002.28969-1-kernel@martin.sperl.org> <20190324175002.28969-10-kernel@martin.sperl.org> <4da737f4-acf2-c70d-59cd-0efdf2ec21d4@i2se.com> To: Stefan Wahren X-Mailer: Apple Mail (2.3124) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190325_025006_154311_2CEDE750 X-CRM114-Status: UNSURE ( 5.78 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-spi@vger.kernel.org, Eric Anholt , Mark Brown , linux-rpi-kernel@lists.infradead.org, Hubert Denkmair , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On 25.03.2019, at 10:44, Stefan Wahren wrote: > > Hi Martin, > > Am 24.03.19 um 18:50 schrieb kernel@martin.sperl.org: >> From: Martin Sperl >> >> +/* define polling limits */ >> +unsigned int polling_limit_us = 30; >> +module_param(polling_limit_us, uint, 0664); >> +MODULE_PARM_DESC(polling_limit_us, >> + "time in us to run a transfer in polling mode\n"); >> + > could you please document the case polling_limit_us = 0 ? Means no polling under any circumstances - I can add it as a comment in V3. martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel