From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ammGL-0003a5-Oy for qemu-devel@nongnu.org; Sun, 03 Apr 2016 13:56:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ammGI-00040u-Hp for qemu-devel@nongnu.org; Sun, 03 Apr 2016 13:56:37 -0400 Received: from mail-lb0-x233.google.com ([2a00:1450:4010:c04::233]:35801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ammGI-00040q-6M for qemu-devel@nongnu.org; Sun, 03 Apr 2016 13:56:34 -0400 Received: by mail-lb0-x233.google.com with SMTP id bc4so129247075lbc.2 for ; Sun, 03 Apr 2016 10:56:33 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: Liviu Ionescu In-Reply-To: Date: Sun, 3 Apr 2016 20:56:30 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <63AEB8A6-929B-48B2-B6D1-13FC80F8888F@livius.net> References: <0F59BEF3-8BDD-434B-9EC4-3DECF9465A44@livius.net> Subject: Re: [Qemu-devel] segmentation fault in object.c:type_initialize_interface() if interface not defined List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers > On 03 Apr 2016, at 20:01, Peter Maydell = wrote: >=20 > ... This is you changing QEMU to not compile a file that was > previously always compiled. If you do that then it's > not surprising if things might break when you move to an > upstream version, that's all. well, to summarise, I notified you that in certain conditions, due to an = non-obvious dependency that does not break the build when not met, the = existing code crashes at run time with a segmentation fault, and I = suggested that an assert might help developers to save some debugging = time.=20 if you want to add this assert, ok; if you don't, and prefer to = permanently blame my fork for various reasons, it's also fine, I don't = mind, I fix it in my fork and move forward. regards, Liviu