All of lore.kernel.org
 help / color / mirror / Atom feed
From: guido@trentalancia.net (Guido Trentalancia)
To: refpolicy@oss.tresys.com
Subject: [refpolicy] [PATCH] Fix the Reference Policy integration with the SELinux testsuite
Date: Fri, 26 Aug 2016 00:56:02 +0200	[thread overview]
Message-ID: <63D2A507-4F79-4C30-BB69-E7E7C77A33FA@trentalancia.net> (raw)
In-Reply-To: <1ac6edd9-1df9-08cc-38ee-338460a47fdf@ieee.org>

Hello Christopher! 

Thanks for getting back. 

We can change the destination directory from <policy_name> to "devel", keep the Makefile in the "include" subdirectory (they also have such subdirectory) and create a symbolic link to it in the parent directory (i.e. "devel").

As far as I remember, the SELinux testsuite only sources some variables from the Makefile, it doesn't run it through make. 

On the other end, removing it from the "include" subdirectory at the moment, might break something, I suppose. 

Should I create a patch or what? 

Regards, 

Guido 

On the 26th of August 2016 00:36:40 CEST, Chris PeBenito <pebenito@ieee.org> wrote:
>On 08/24/16 09:39, Guido Trentalancia via refpolicy wrote:
>> The SELinux testsuite expects the Makefile.devel file to be installed
>> in the top level share directory and not in its include subdirectory.
>>
>> Such file is installed by the Makefile target "install-headers".
>>
>> Signed-off-by: Guido Trentalancia <guido@trentalancia.net>
>> ---
>>  Makefile |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> --- refpolicy-git-06082016-orig/Makefile	2016-08-06
>21:26:43.257773849 +0200
>> +++ refpolicy-git-06082016/Makefile	2016-08-24 15:33:34.936218176
>+0200
>> @@ -70,6 +70,7 @@ SECHECK ?= $(BINDIR)/sechecker
>>  AWK ?= gawk
>>  GREP ?= egrep
>>  INSTALL ?= install
>> +LN ?= ln
>>  M4 ?= m4
>>  PYTHON ?= python
>>  SED ?= sed
>> @@ -532,6 +533,7 @@ endif
>>  	$(verbose) echo "override MLS_CATS := $(MLS_CATS)" >>
>$(headerdir)/build.conf
>>  	$(verbose) echo "override MCS_CATS := $(MCS_CATS)" >>
>$(headerdir)/build.conf
>>  	$(verbose) $(INSTALL) -m 644 $(support)/Makefile.devel
>$(headerdir)/Makefile
>> +	$(verbose) $(LN) -sf $(headerdir)/Makefile $(modpkgdir)/Makefile
>
>I think instead we should update the header install structure to be in 
>line with what the distributions have done for years, i.e. install into
>
>/usr/share/selinux/devel.

  reply	other threads:[~2016-08-25 22:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24 13:39 [refpolicy] [PATCH] Fix the Reference Policy integration with the SELinux testsuite Guido Trentalancia
2016-08-25 22:36 ` Chris PeBenito
2016-08-25 22:56   ` Guido Trentalancia [this message]
2016-08-28 18:23     ` Chris PeBenito
2016-08-30 17:52       ` Paul Moore
2016-08-30 18:07         ` Guido Trentalancia
2016-08-30 18:17           ` Paul Moore
2016-08-30 19:05             ` Guido Trentalancia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63D2A507-4F79-4C30-BB69-E7E7C77A33FA@trentalancia.net \
    --to=guido@trentalancia.net \
    --cc=refpolicy@oss.tresys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.