From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH 3/7] eal: move virtual device probing into a bus Date: Wed, 15 Feb 2017 19:50:16 +0530 Message-ID: <63a008be-1386-9080-c846-e305eea44c38@nxp.com> References: <1487152929-23627-1-git-send-email-jblunck@infradead.org> <1487152929-23627-4-git-send-email-jblunck@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: dev To: Jan Blunck Return-path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0084.outbound.protection.outlook.com [104.47.34.84]) by dpdk.org (Postfix) with ESMTP id 8B4C8201 for ; Wed, 15 Feb 2017 15:15:28 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wednesday 15 February 2017 07:43 PM, Jan Blunck wrote: > On Wed, Feb 15, 2017 at 3:11 PM, Shreyansh Jain wrote: >> On Wednesday 15 February 2017 03:32 PM, Jan Blunck wrote: >>> >> >>> + >>> +static struct rte_bus rte_vdev_bus = { >>> + .scan = vdev_scan, >>> + .probe = vdev_probe, >>> +}; >>> + >>> +RTE_REGISTER_BUS_LATE(virtual, rte_vdev_bus); >>> >> >> Does it matter if VDEV buses are registered before or after other >> buses? > > Yes, it does. Also see commit f4ce209a ("eal: postpone vdev initialization"). > >> Either way, the callbacks would be called in the order specified >> in EAL. > > They are called in order of registration. That is why this defers the > registration of the vdev bus. Agree - I realized the problem in my statement after I had sent the email.