From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9F27C64ED8 for ; Mon, 27 Feb 2023 11:51:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229550AbjB0LvY (ORCPT ); Mon, 27 Feb 2023 06:51:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjB0LvW (ORCPT ); Mon, 27 Feb 2023 06:51:22 -0500 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2053.outbound.protection.outlook.com [40.107.243.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B06FFB478; Mon, 27 Feb 2023 03:51:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PeYnzvaRSJrtSRrEQQtcYXgAhMZCwwRU53M+G4jN7jQT+ULKEUPTYvJJiIAeWASNkIMtIih3xNEcjTHg5F1e9fhMZkE9nfaWvHqjk8o/fZ8CXO3zL7SZg/3SB4PShsIxVOBO33Db19GGtOAo8I2yhS2NCEOsprWMs7yFDnLuz2bjsO9auUsFcRnnBZweIdv3LytrzkVJnleXX0y8gmMbIl9OKlyXVR6i6cSMnWpBUFZ30fEa+4kir0cEPIB7JlXVLtXVT4NaytwulWXhz7oO4RQL8ODvgVpgpb2DiET+NmAKQswEiek/c1OijWCzIDWajVHYoKHI/TOqhPDk2kOa8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qz9d4GHIyl/2e/+kDSNyFWm2K9Eir6xd8a74AAXVUSE=; b=UhigetlSdaUwqTPriHTekgcDN8DJ00GREMH61lLB8PPyeMgBpUJrRVoMhq+Gcio7mWl7AwsPzc5xAwVIgvrcCl4DLGjwFctMAVd4Pcex8RglGhsnQDM5+b7ciks2Q493RVVUQLawnZXXhoPAk1YhR0zBNyWQNBVoQnXRL93MmS3Kro2+ebVDPUjX/dvo810pWq/TG14g2uzielNJYzyTSk9cWE9Y4AfaRN6h5QzY8mIVP1VC7vPskN4kYWkGu4RZ3DMf31SXLGOQnDcNgOH5W8C7AaHR9iY+k/fmO9EpsjorvI8lFMkmDBvQ3lgIMuF1qdzOvW9v0XFh3XJAniTorw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=oracle.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qz9d4GHIyl/2e/+kDSNyFWm2K9Eir6xd8a74AAXVUSE=; b=JMrzB3h3vmFCZhRrgAWAQTbaYAQMitCq7xKiR4c+gw+Q0DJ3hgZd3sHksBvKqwgSi6CCMFkeKV5tI2IYmcIxATsaDD8xSPt3BkBouUwFfQXmKo4oK0448fJoDdvEie17CKRPgNLD2IQJvss5vSf//d2ecHF3kShpf3HY9peD8lc= Received: from DM6PR11CA0041.namprd11.prod.outlook.com (2603:10b6:5:14c::18) by IA1PR12MB8537.namprd12.prod.outlook.com (2603:10b6:208:453::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Mon, 27 Feb 2023 11:51:19 +0000 Received: from DM6NAM11FT100.eop-nam11.prod.protection.outlook.com (2603:10b6:5:14c:cafe::16) by DM6PR11CA0041.outlook.office365.com (2603:10b6:5:14c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.28 via Frontend Transport; Mon, 27 Feb 2023 11:51:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT100.mail.protection.outlook.com (10.13.172.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6156.16 via Frontend Transport; Mon, 27 Feb 2023 11:51:18 +0000 Received: from [10.254.241.51] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 27 Feb 2023 05:51:16 -0600 Message-ID: <63a98249-3c6d-dd50-b523-64c69173d447@amd.com> Date: Mon, 27 Feb 2023 12:51:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 24/27] firmware: xilinx: remove MODULE_LICENSE in non-modules Content-Language: en-US To: Nick Alcock , CC: , , Hitomi Hasegawa , Srinivas Kandagatla , Michal Simek , References: <20230224150811.80316-1-nick.alcock@oracle.com> <20230224150811.80316-25-nick.alcock@oracle.com> From: Michal Simek In-Reply-To: <20230224150811.80316-25-nick.alcock@oracle.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT100:EE_|IA1PR12MB8537:EE_ X-MS-Office365-Filtering-Correlation-Id: c4d5f333-ce41-45a1-110f-08db18b8f072 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tuw6dbjsSTzLEZ1YuyEstJkYvcX+BjCgBzwYhlLltXNSnAk5JRudGbwBxjFQIXUSjYDCPzMWXxB7nsG1LmVgg70QiY37kvpzfmEdgzpkcGeKOniKNBUATI7+fhteMeutLnm60p6iFwkC/uq4Y8mbRHUhPqxKL0Yjnn264mOCGdvbKwDuuWnC8VneGl3bjO92+ccFHH9ai1ypJIST/jAQxj3aOwlETVkM3T5oklX8yC6zJmg7geU5asEQOKG//piiztNHwdK/KSkMbC4z8aUb/mIhvmAFEY6+NrwrxLObxGwLDudjrPtNzKw5QRc2YEicizDcSSuKyLkG7lZCZkB7zS3sHlAnFUdCcj+aJ5L7F0f7LlFTkJTqjB0LRgI0dEQAHIum4ZyPq6kc4p1jVQ6K6+3/DHW9BnA1GmUgfhEAbYZoPJH/kyFs5+zus3IbaLQ2Bst8mWPk9MnoQgOE9nXM1Y+UGxq6EBHsllmd6bja9PmxdfDH4lfYM5Ei/mIq9eQS4Vyowc4xIXvi0hYg5Agl7s9/thtjW+fy/Z50xvyOHcG2vXzQYaTHaOzB2gmYfiqDOW66rC8JqgUfxx5/TX1A0D/Rl2X6WIuqiyhmgWEB4N2a1BtImQi1cFvAK6aoR4zAy9Dv5UlhChM/49i2Rj+Bd46ntxbsJOtkGB5xOcluTJ26Dw26Kk4PnRRIuDhzPijIMQzpPVdrg6iPwxhxWe2+0AwvLoLK2+vsxK2LaZP8HEbC500SBEvfz0Pp99wGr/HaIE6v2Gnc97PJYBAdF85h0g== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(376002)(39860400002)(396003)(136003)(346002)(451199018)(40470700004)(46966006)(36840700001)(426003)(70586007)(47076005)(40480700001)(4326008)(6666004)(70206006)(26005)(478600001)(16526019)(36756003)(186003)(53546011)(40460700003)(2616005)(110136005)(86362001)(81166007)(316002)(336012)(82740400003)(82310400005)(8936002)(31696002)(54906003)(16576012)(8676002)(356005)(44832011)(31686004)(5660300002)(41300700001)(2906002)(83380400001)(36860700001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 11:51:18.9488 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c4d5f333-ce41-45a1-110f-08db18b8f072 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT100.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8537 Precedence: bulk List-ID: On 2/24/23 16:08, Nick Alcock wrote: > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock > Suggested-by: Luis Chamberlain > Cc: Luis Chamberlain > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa > Cc: Srinivas Kandagatla > Cc: Michal Simek > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/nvmem/zynqmp_nvmem.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/nvmem/zynqmp_nvmem.c b/drivers/nvmem/zynqmp_nvmem.c > index e28d7b133e11..844c1d861dea 100644 > --- a/drivers/nvmem/zynqmp_nvmem.c > +++ b/drivers/nvmem/zynqmp_nvmem.c > @@ -78,4 +78,3 @@ module_platform_driver(zynqmp_nvmem_driver); > > MODULE_AUTHOR("Michal Simek , Nava kishore Manne "); > MODULE_DESCRIPTION("ZynqMP NVMEM driver"); > -MODULE_LICENSE("GPL"); > -- > 2.39.1.268.g9de2f9a303 > I would prefer to fix this by changing Kconfig symbol from bool to tristate. Thanks, Michal From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17BEBC64ED8 for ; Mon, 27 Feb 2023 11:53:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AunMvwyJpyYPRx67LT2XBhAtOSqRKvPM27Kfy5xHKuQ=; b=iqqwKWPOiNhC76 e93NBLSvv7hakQvmFmyhwnRK8X2PX3NuCPYHQLDUk/ehhB/ZNGWMlaG4PDyX31d8mnstZ1HHV3BBJ bYtG3SXcZKYUCf8Eivk0X61KxINgND4/UCi5p+JpmY7EwD8fgvUseKk4Il5dYN8t3JcTkcaKtqPKD I6MvUrIX/HNpipFpLQx2ukVAQfEQykajG90uj4N0nJVWJrZkhnVRD+92dFgBxI6JclQrpq0YZ0DwH udbCcuN7anvtB1xtaIV5hY0ki7g7GalCkO5y9nLgUsvYxF2y4sClktvlm+y5kin4n+hUj7p0XBpJn HXnJj3C0hj448v0K8wng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWc2z-009SNP-G9; Mon, 27 Feb 2023 11:52:02 +0000 Received: from mail-dm6nam12on20615.outbound.protection.outlook.com ([2a01:111:f400:fe59::615] helo=NAM12-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWc2N-009S9d-U2 for linux-arm-kernel@lists.infradead.org; Mon, 27 Feb 2023 11:51:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PeYnzvaRSJrtSRrEQQtcYXgAhMZCwwRU53M+G4jN7jQT+ULKEUPTYvJJiIAeWASNkIMtIih3xNEcjTHg5F1e9fhMZkE9nfaWvHqjk8o/fZ8CXO3zL7SZg/3SB4PShsIxVOBO33Db19GGtOAo8I2yhS2NCEOsprWMs7yFDnLuz2bjsO9auUsFcRnnBZweIdv3LytrzkVJnleXX0y8gmMbIl9OKlyXVR6i6cSMnWpBUFZ30fEa+4kir0cEPIB7JlXVLtXVT4NaytwulWXhz7oO4RQL8ODvgVpgpb2DiET+NmAKQswEiek/c1OijWCzIDWajVHYoKHI/TOqhPDk2kOa8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qz9d4GHIyl/2e/+kDSNyFWm2K9Eir6xd8a74AAXVUSE=; b=UhigetlSdaUwqTPriHTekgcDN8DJ00GREMH61lLB8PPyeMgBpUJrRVoMhq+Gcio7mWl7AwsPzc5xAwVIgvrcCl4DLGjwFctMAVd4Pcex8RglGhsnQDM5+b7ciks2Q493RVVUQLawnZXXhoPAk1YhR0zBNyWQNBVoQnXRL93MmS3Kro2+ebVDPUjX/dvo810pWq/TG14g2uzielNJYzyTSk9cWE9Y4AfaRN6h5QzY8mIVP1VC7vPskN4kYWkGu4RZ3DMf31SXLGOQnDcNgOH5W8C7AaHR9iY+k/fmO9EpsjorvI8lFMkmDBvQ3lgIMuF1qdzOvW9v0XFh3XJAniTorw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=oracle.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qz9d4GHIyl/2e/+kDSNyFWm2K9Eir6xd8a74AAXVUSE=; b=JMrzB3h3vmFCZhRrgAWAQTbaYAQMitCq7xKiR4c+gw+Q0DJ3hgZd3sHksBvKqwgSi6CCMFkeKV5tI2IYmcIxATsaDD8xSPt3BkBouUwFfQXmKo4oK0448fJoDdvEie17CKRPgNLD2IQJvss5vSf//d2ecHF3kShpf3HY9peD8lc= Received: from DM6PR11CA0041.namprd11.prod.outlook.com (2603:10b6:5:14c::18) by IA1PR12MB8537.namprd12.prod.outlook.com (2603:10b6:208:453::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Mon, 27 Feb 2023 11:51:19 +0000 Received: from DM6NAM11FT100.eop-nam11.prod.protection.outlook.com (2603:10b6:5:14c:cafe::16) by DM6PR11CA0041.outlook.office365.com (2603:10b6:5:14c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.28 via Frontend Transport; Mon, 27 Feb 2023 11:51:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT100.mail.protection.outlook.com (10.13.172.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6156.16 via Frontend Transport; Mon, 27 Feb 2023 11:51:18 +0000 Received: from [10.254.241.51] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 27 Feb 2023 05:51:16 -0600 Message-ID: <63a98249-3c6d-dd50-b523-64c69173d447@amd.com> Date: Mon, 27 Feb 2023 12:51:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 24/27] firmware: xilinx: remove MODULE_LICENSE in non-modules Content-Language: en-US To: Nick Alcock , CC: , , Hitomi Hasegawa , Srinivas Kandagatla , Michal Simek , References: <20230224150811.80316-1-nick.alcock@oracle.com> <20230224150811.80316-25-nick.alcock@oracle.com> From: Michal Simek In-Reply-To: <20230224150811.80316-25-nick.alcock@oracle.com> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT100:EE_|IA1PR12MB8537:EE_ X-MS-Office365-Filtering-Correlation-Id: c4d5f333-ce41-45a1-110f-08db18b8f072 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tuw6dbjsSTzLEZ1YuyEstJkYvcX+BjCgBzwYhlLltXNSnAk5JRudGbwBxjFQIXUSjYDCPzMWXxB7nsG1LmVgg70QiY37kvpzfmEdgzpkcGeKOniKNBUATI7+fhteMeutLnm60p6iFwkC/uq4Y8mbRHUhPqxKL0Yjnn264mOCGdvbKwDuuWnC8VneGl3bjO92+ccFHH9ai1ypJIST/jAQxj3aOwlETVkM3T5oklX8yC6zJmg7geU5asEQOKG//piiztNHwdK/KSkMbC4z8aUb/mIhvmAFEY6+NrwrxLObxGwLDudjrPtNzKw5QRc2YEicizDcSSuKyLkG7lZCZkB7zS3sHlAnFUdCcj+aJ5L7F0f7LlFTkJTqjB0LRgI0dEQAHIum4ZyPq6kc4p1jVQ6K6+3/DHW9BnA1GmUgfhEAbYZoPJH/kyFs5+zus3IbaLQ2Bst8mWPk9MnoQgOE9nXM1Y+UGxq6EBHsllmd6bja9PmxdfDH4lfYM5Ei/mIq9eQS4Vyowc4xIXvi0hYg5Agl7s9/thtjW+fy/Z50xvyOHcG2vXzQYaTHaOzB2gmYfiqDOW66rC8JqgUfxx5/TX1A0D/Rl2X6WIuqiyhmgWEB4N2a1BtImQi1cFvAK6aoR4zAy9Dv5UlhChM/49i2Rj+Bd46ntxbsJOtkGB5xOcluTJ26Dw26Kk4PnRRIuDhzPijIMQzpPVdrg6iPwxhxWe2+0AwvLoLK2+vsxK2LaZP8HEbC500SBEvfz0Pp99wGr/HaIE6v2Gnc97PJYBAdF85h0g== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(376002)(39860400002)(396003)(136003)(346002)(451199018)(40470700004)(46966006)(36840700001)(426003)(70586007)(47076005)(40480700001)(4326008)(6666004)(70206006)(26005)(478600001)(16526019)(36756003)(186003)(53546011)(40460700003)(2616005)(110136005)(86362001)(81166007)(316002)(336012)(82740400003)(82310400005)(8936002)(31696002)(54906003)(16576012)(8676002)(356005)(44832011)(31686004)(5660300002)(41300700001)(2906002)(83380400001)(36860700001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 11:51:18.9488 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c4d5f333-ce41-45a1-110f-08db18b8f072 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT100.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8537 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230227_035124_144280_739216A5 X-CRM114-Status: GOOD ( 19.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/24/23 16:08, Nick Alcock wrote: > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock > Suggested-by: Luis Chamberlain > Cc: Luis Chamberlain > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa > Cc: Srinivas Kandagatla > Cc: Michal Simek > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/nvmem/zynqmp_nvmem.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/nvmem/zynqmp_nvmem.c b/drivers/nvmem/zynqmp_nvmem.c > index e28d7b133e11..844c1d861dea 100644 > --- a/drivers/nvmem/zynqmp_nvmem.c > +++ b/drivers/nvmem/zynqmp_nvmem.c > @@ -78,4 +78,3 @@ module_platform_driver(zynqmp_nvmem_driver); > > MODULE_AUTHOR("Michal Simek , Nava kishore Manne "); > MODULE_DESCRIPTION("ZynqMP NVMEM driver"); > -MODULE_LICENSE("GPL"); > -- > 2.39.1.268.g9de2f9a303 > I would prefer to fix this by changing Kconfig symbol from bool to tristate. Thanks, Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel