From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lCvpH-0006Km-F8 for mharc-grub-devel@gnu.org; Thu, 18 Feb 2021 21:47:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCvpF-0006Jn-GO for grub-devel@gnu.org; Thu, 18 Feb 2021 21:47:26 -0500 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]:42982) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCvpB-00005o-Sv for grub-devel@gnu.org; Thu, 18 Feb 2021 21:47:25 -0500 Received: by mail-qk1-x734.google.com with SMTP id z190so4303639qka.9 for ; Thu, 18 Feb 2021 18:47:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SMFQqs1lgrd0rIgO85u3MkNerKYEVVo2qfwvc+S8f7k=; b=qbT7IfQ9vhtA/VnoEgrZcNvgfXpkzGxFvsSzcbr9K4rauA0dttRKvHOceqxbbEcUut bG9pmlRhVafHwsa1PAreZVQ0QUUlnp6vbvAebKoDoc4cdKNxfdaScWmTos97BZgFpLX9 S2fR0AY3RP8kO3NkEupJkkUvI7HBlCJgBdnpKXdD+HYf5YqhWooHrtrYMW+m+1r14nR3 MrIvVlQElPzkSS0za36wClrVBPTU2eM1NrkyN8dKReSRN38OmeX2jYwvnY5CQ3LzeI0n KNsGcbGYf3SeJH63VR0ATyjg7LQCI2f9anEZbR0N9l3WSuQbHtFykOyutFW7+XsSLG/c eDFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SMFQqs1lgrd0rIgO85u3MkNerKYEVVo2qfwvc+S8f7k=; b=TMiY9qNYu+4vxtLRTkL0NVx67kWMEf7rJKfqAf60aOqgIY6LeYIau6kaS4YN/ZJnIu EUhL77YuJvXjxCpoG7JUCWog7YB7QJjYb4wLeqiLDneYyDzL3WdMbF6nB7itZifn6ogo Sj/A8Ry1xvM012kYGJYB7J3rX5gXftzb3ZBHPFLYR2rFFf7UOn7MYace1Fx1sUDAf3MD nivM5xjKN42JUokX7O30IPezs3FL+cLBr2K6TEEWJcAYqKM6UuRrcf0HmKU90XK5RUY2 5/UlyBKlyIsEf/hbE1c2dRdcCNWDIn30IQTbK4t5ymWLzxHWU7uTt2Za1ImJrHZVlg4q MrYA== X-Gm-Message-State: AOAM533AZtvTQ0N90uTIHmPPg92TpS32dVmlEblHZNoDFg5p+fcAOcwo 4K3fNZPkg+H0T2N+AH+2emLALSeAdNcR5Q== X-Google-Smtp-Source: ABdhPJyGRmqNmdvPKjFR2Zbyr75syUZDd766YtXn/od65tcDqKB2RdcfoumLznFKE7HIG1u5wHdt/Q== X-Received: by 2002:a37:46c7:: with SMTP id t190mr7411067qka.478.1613702840674; Thu, 18 Feb 2021 18:47:20 -0800 (PST) Received: from localhost.localdomain ([2605:a601:aac5:3700:c323:c101:d96b:34f1]) by smtp.gmail.com with ESMTPSA id y2sm5341515qkj.56.2021.02.18.18.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Feb 2021 18:47:20 -0800 (PST) From: Glenn Washburn To: grub-devel@gnu.org Cc: Daniel Kiper , Glenn Washburn Subject: [PATCH v4 02/13] error: grub_error missing format string argument Date: Thu, 18 Feb 2021 20:47:03 -0600 Message-Id: <63bf8353bf7b0813227f6a58d89e8a48622bbef6.1613700218.git.development@efficientek.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::734; envelope-from=development@efficientek.com; helo=mail-qk1-x734.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 02:47:26 -0000 Its obvious from the error message that the variable named "type" was accidentally omitted. Signed-off-by: Glenn Washburn --- grub-core/parttool/msdospart.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/grub-core/parttool/msdospart.c b/grub-core/parttool/msdospart.c index dcbf74e3b..2e2e9d527 100644 --- a/grub-core/parttool/msdospart.c +++ b/grub-core/parttool/msdospart.c @@ -127,8 +127,8 @@ static grub_err_t grub_pcpart_type (const grub_device_t dev, { dev->disk->partition = part; return grub_error (GRUB_ERR_BAD_ARGUMENT, - N_("the partition type 0x%x isn't " - "valid")); + N_("the partition type 0x%x isn't valid"), + type); } mbr.entries[index].type = type; -- 2.27.0