From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 767D4C433F5 for ; Sat, 29 Jan 2022 08:21:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345329AbiA2IVI (ORCPT ); Sat, 29 Jan 2022 03:21:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345045AbiA2IVF (ORCPT ); Sat, 29 Jan 2022 03:21:05 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB494C061714 for ; Sat, 29 Jan 2022 00:21:04 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B6E65B80EAC for ; Sat, 29 Jan 2022 08:21:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EFA5C340E5; Sat, 29 Jan 2022 08:21:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643444461; bh=CAJBVX/NO0EYaGHu33IuNaB4gDWZ0pLFcxx3BDZzQyU=; h=Date:Subject:To:References:From:In-Reply-To:From; b=W+fOa/G08L4jsxDoLowFyjiYXgrV6/k+25fjszD83xeGfFRDWHsQ3JpTXYG13hU8u MrI1wUZgvvwQnikhf/7JdyE8vU6mpjH5Mwe4XyWg6zYGLKV8xcE+JmYcfWdebbPYtW 3X9jtRprBfHABk79BEyc9RK1nwgROth6SdvGRrhXdu7SeJQR6k2s2sn4ZmV3DMTNIN NMyUDvSNXV3M99QWNQIzZB1r4NIZh1QQowPwhtTvFZILuQuxwH6hIJSTTJotleON8v brs385W5UmsCdUmxLnDnnT5ZLnu/OU833W+x0I3VfXQyT0rdc51adcSxMmaxKq1GnI vmiVAe7TfeTkA== Message-ID: <63cd175a-d2ae-7808-a894-4fd57cc4fce0@kernel.org> Date: Sat, 29 Jan 2022 16:20:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [f2fs-dev] [PATCH] f2fs: add a way to limit roll forward recovery time Content-Language: en-US To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20220127214102.2040254-1-jaegeuk@kernel.org> From: Chao Yu In-Reply-To: <20220127214102.2040254-1-jaegeuk@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/1/28 5:41, Jaegeuk Kim wrote: > This adds a sysfs entry to call checkpoint during fsync() in order to avoid > long elapsed time to run roll-forward recovery when booting the device. > > Signed-off-by: Jaegeuk Kim > --- > Documentation/ABI/testing/sysfs-fs-f2fs | 6 ++++++ > fs/f2fs/checkpoint.c | 1 + > fs/f2fs/f2fs.h | 3 +++ > fs/f2fs/node.c | 2 ++ > fs/f2fs/node.h | 3 +++ > fs/f2fs/recovery.c | 3 +++ > fs/f2fs/sysfs.c | 2 ++ > 7 files changed, 20 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs > index 87d3884c90ea..ce8103f522cb 100644 > --- a/Documentation/ABI/testing/sysfs-fs-f2fs > +++ b/Documentation/ABI/testing/sysfs-fs-f2fs > @@ -567,3 +567,9 @@ Contact: "Daeho Jeong" > Description: You can set the trial count limit for GC urgent high mode with this value. > If GC thread gets to the limit, the mode will turn back to GC normal mode. > By default, the value is zero, which means there is no limit like before. > + > +What: /sys/fs/f2fs//max_roll_forward_node_blocks > +Date: January 2022 > +Contact: "Jaegeuk Kim" > +Description: Controls max # of node block writes to be used for roll forward > + recovery. This can limit the roll forward recovery time. > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index deeda95688f0..57a2d9164bee 100644 > --- a/fs/f2fs/checkpoint.c > +++ b/fs/f2fs/checkpoint.c > @@ -1543,6 +1543,7 @@ static int do_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc) > /* update user_block_counts */ > sbi->last_valid_block_count = sbi->total_valid_block_count; > percpu_counter_set(&sbi->alloc_valid_block_count, 0); > + percpu_counter_set(&sbi->rf_node_block_count, 0); > > /* Here, we have one bio having CP pack except cp pack 2 page */ > f2fs_sync_meta_pages(sbi, META, LONG_MAX, FS_CP_META_IO); > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index 63c90416364b..6ddb98ff0b7c 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -913,6 +913,7 @@ struct f2fs_nm_info { > nid_t max_nid; /* maximum possible node ids */ > nid_t available_nids; /* # of available node ids */ > nid_t next_scan_nid; /* the next nid to be scanned */ > + nid_t max_rf_node_blocks; /* max # of nodes for recovery */ > unsigned int ram_thresh; /* control the memory footprint */ > unsigned int ra_nid_pages; /* # of nid pages to be readaheaded */ > unsigned int dirty_nats_ratio; /* control dirty nats ratio threshold */ > @@ -1684,6 +1685,8 @@ struct f2fs_sb_info { > atomic_t nr_pages[NR_COUNT_TYPE]; > /* # of allocated blocks */ > struct percpu_counter alloc_valid_block_count; > + /* # of node block writes as roll forward recovery */ > + struct percpu_counter rf_node_block_count; > > /* writeback control */ > atomic_t wb_sync_req[META]; /* count # of WB_SYNC threads */ > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index 93512f8859d5..0d9883457579 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -1782,6 +1782,7 @@ int f2fs_fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode, > > if (!atomic || page == last_page) { > set_fsync_mark(page, 1); > + percpu_counter_inc(&sbi->rf_node_block_count); > if (IS_INODE(page)) { > if (is_inode_flag_set(inode, > FI_DIRTY_INODE)) > @@ -3218,6 +3219,7 @@ static int init_node_manager(struct f2fs_sb_info *sbi) > nm_i->ram_thresh = DEF_RAM_THRESHOLD; > nm_i->ra_nid_pages = DEF_RA_NID_PAGES; > nm_i->dirty_nats_ratio = DEF_DIRTY_NAT_RATIO_THRESHOLD; > + nm_i->max_rf_node_blocks = DEF_RF_NODE_BLOCKS; > > INIT_RADIX_TREE(&nm_i->free_nid_root, GFP_ATOMIC); > INIT_LIST_HEAD(&nm_i->free_nid_list); > diff --git a/fs/f2fs/node.h b/fs/f2fs/node.h > index 18b98cf0465b..fe56fd29c0d3 100644 > --- a/fs/f2fs/node.h > +++ b/fs/f2fs/node.h > @@ -31,6 +31,9 @@ > /* control total # of nats */ > #define DEF_NAT_CACHE_THRESHOLD 100000 > > +/* control total # of node writes used for roll-fowrad recovery */ > +#define DEF_RF_NODE_BLOCKS 100 Will we suffer performance regression issue in some scenarios in where user triggers fsync/fdatasync frequently? e.g. performance test. If this issue is a corner case, it's better to increase DEF_RF_NODE_BLOCKS to avoid affecting common case AMSP? Thanks, > + > /* vector size for gang look-up from nat cache that consists of radix tree */ > #define NATVEC_SIZE 64 > #define SETVEC_SIZE 32 > diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c > index 10d152cfa58d..f69b685fb2b2 100644 > --- a/fs/f2fs/recovery.c > +++ b/fs/f2fs/recovery.c > @@ -53,9 +53,12 @@ extern struct kmem_cache *f2fs_cf_name_slab; > bool f2fs_space_for_roll_forward(struct f2fs_sb_info *sbi) > { > s64 nalloc = percpu_counter_sum_positive(&sbi->alloc_valid_block_count); > + u32 rf_node = percpu_counter_sum_positive(&sbi->rf_node_block_count); > > if (sbi->last_valid_block_count + nalloc > sbi->user_block_count) > return false; > + if (rf_node >= NM_I(sbi)->max_rf_node_blocks) > + return false; > return true; > } > > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c > index 281bc0133ee6..47efcf233afd 100644 > --- a/fs/f2fs/sysfs.c > +++ b/fs/f2fs/sysfs.c > @@ -732,6 +732,7 @@ F2FS_RW_ATTR(SM_INFO, f2fs_sm_info, min_ssr_sections, min_ssr_sections); > F2FS_RW_ATTR(NM_INFO, f2fs_nm_info, ram_thresh, ram_thresh); > F2FS_RW_ATTR(NM_INFO, f2fs_nm_info, ra_nid_pages, ra_nid_pages); > F2FS_RW_ATTR(NM_INFO, f2fs_nm_info, dirty_nats_ratio, dirty_nats_ratio); > +F2FS_RW_ATTR(NM_INFO, f2fs_nm_info, max_roll_forward_node_blocks, max_rf_node_blocks); > F2FS_RW_ATTR(F2FS_SBI, f2fs_sb_info, max_victim_search, max_victim_search); > F2FS_RW_ATTR(F2FS_SBI, f2fs_sb_info, migration_granularity, migration_granularity); > F2FS_RW_ATTR(F2FS_SBI, f2fs_sb_info, dir_level, dir_level); > @@ -855,6 +856,7 @@ static struct attribute *f2fs_attrs[] = { > ATTR_LIST(ram_thresh), > ATTR_LIST(ra_nid_pages), > ATTR_LIST(dirty_nats_ratio), > + ATTR_LIST(max_roll_forward_node_blocks), > ATTR_LIST(cp_interval), > ATTR_LIST(idle_interval), > ATTR_LIST(discard_idle_interval), From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73C4DC433EF for ; Sat, 29 Jan 2022 08:21:14 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nDiyv-00044n-JW; Sat, 29 Jan 2022 08:21:12 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nDiyu-000447-DQ for linux-f2fs-devel@lists.sourceforge.net; Sat, 29 Jan 2022 08:21:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mWAjhPfZQNAWEOEJMZW59v3atzXA2dS67VxbUDLDmAw=; b=lA5KJrgAyQWKe0kB49yYXVT+GN YhKZ7jvcvTfcvisf6C9M5EJNatwpg9gPywsssGaWdNgsIi0G96TTKvF+YmD9pZ+8glq1K/o/YTJb/ 7J9UVU1arI4/uq90TGgTEhiOEQIghW+7b++pg7iiB9/pNc8P9viFB1ow9qnEKXrdTx0M=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mWAjhPfZQNAWEOEJMZW59v3atzXA2dS67VxbUDLDmAw=; b=fngSimacwiQRUHORO4bueQ80s/ SYLgCTWjYQzdXpkFpedEmvXTmOVhMuU2ieyBuebQGYW/5cwbbBueH4hAeb0kh/nyrJRLbOEcPNDtJ ryHOJk1k4z8bIINmjZMCVJFsb8Jx9N0Imarht0R8ZlCN2uQKw7Kt4wQDMlA+Qofd3Z00=; Received: from ams.source.kernel.org ([145.40.68.75]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nDiyr-002O3S-0V for linux-f2fs-devel@lists.sourceforge.net; Sat, 29 Jan 2022 08:21:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AFFF3B80CA0 for ; Sat, 29 Jan 2022 08:21:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EFA5C340E5; Sat, 29 Jan 2022 08:21:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643444461; bh=CAJBVX/NO0EYaGHu33IuNaB4gDWZ0pLFcxx3BDZzQyU=; h=Date:Subject:To:References:From:In-Reply-To:From; b=W+fOa/G08L4jsxDoLowFyjiYXgrV6/k+25fjszD83xeGfFRDWHsQ3JpTXYG13hU8u MrI1wUZgvvwQnikhf/7JdyE8vU6mpjH5Mwe4XyWg6zYGLKV8xcE+JmYcfWdebbPYtW 3X9jtRprBfHABk79BEyc9RK1nwgROth6SdvGRrhXdu7SeJQR6k2s2sn4ZmV3DMTNIN NMyUDvSNXV3M99QWNQIzZB1r4NIZh1QQowPwhtTvFZILuQuxwH6hIJSTTJotleON8v brs385W5UmsCdUmxLnDnnT5ZLnu/OU833W+x0I3VfXQyT0rdc51adcSxMmaxKq1GnI vmiVAe7TfeTkA== Message-ID: <63cd175a-d2ae-7808-a894-4fd57cc4fce0@kernel.org> Date: Sat, 29 Jan 2022 16:20:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Content-Language: en-US To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20220127214102.2040254-1-jaegeuk@kernel.org> From: Chao Yu In-Reply-To: <20220127214102.2040254-1-jaegeuk@kernel.org> X-Headers-End: 1nDiyr-002O3S-0V Subject: Re: [f2fs-dev] [PATCH] f2fs: add a way to limit roll forward recovery time X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2022/1/28 5:41, Jaegeuk Kim wrote: > This adds a sysfs entry to call checkpoint during fsync() in order to avoid > long elapsed time to run roll-forward recovery when booting the device. > > Signed-off-by: Jaegeuk Kim > --- > Documentation/ABI/testing/sysfs-fs-f2fs | 6 ++++++ > fs/f2fs/checkpoint.c | 1 + > fs/f2fs/f2fs.h | 3 +++ > fs/f2fs/node.c | 2 ++ > fs/f2fs/node.h | 3 +++ > fs/f2fs/recovery.c | 3 +++ > fs/f2fs/sysfs.c | 2 ++ > 7 files changed, 20 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs > index 87d3884c90ea..ce8103f522cb 100644 > --- a/Documentation/ABI/testing/sysfs-fs-f2fs > +++ b/Documentation/ABI/testing/sysfs-fs-f2fs > @@ -567,3 +567,9 @@ Contact: "Daeho Jeong" > Description: You can set the trial count limit for GC urgent high mode with this value. > If GC thread gets to the limit, the mode will turn back to GC normal mode. > By default, the value is zero, which means there is no limit like before. > + > +What: /sys/fs/f2fs//max_roll_forward_node_blocks > +Date: January 2022 > +Contact: "Jaegeuk Kim" > +Description: Controls max # of node block writes to be used for roll forward > + recovery. This can limit the roll forward recovery time. > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index deeda95688f0..57a2d9164bee 100644 > --- a/fs/f2fs/checkpoint.c > +++ b/fs/f2fs/checkpoint.c > @@ -1543,6 +1543,7 @@ static int do_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc) > /* update user_block_counts */ > sbi->last_valid_block_count = sbi->total_valid_block_count; > percpu_counter_set(&sbi->alloc_valid_block_count, 0); > + percpu_counter_set(&sbi->rf_node_block_count, 0); > > /* Here, we have one bio having CP pack except cp pack 2 page */ > f2fs_sync_meta_pages(sbi, META, LONG_MAX, FS_CP_META_IO); > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index 63c90416364b..6ddb98ff0b7c 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -913,6 +913,7 @@ struct f2fs_nm_info { > nid_t max_nid; /* maximum possible node ids */ > nid_t available_nids; /* # of available node ids */ > nid_t next_scan_nid; /* the next nid to be scanned */ > + nid_t max_rf_node_blocks; /* max # of nodes for recovery */ > unsigned int ram_thresh; /* control the memory footprint */ > unsigned int ra_nid_pages; /* # of nid pages to be readaheaded */ > unsigned int dirty_nats_ratio; /* control dirty nats ratio threshold */ > @@ -1684,6 +1685,8 @@ struct f2fs_sb_info { > atomic_t nr_pages[NR_COUNT_TYPE]; > /* # of allocated blocks */ > struct percpu_counter alloc_valid_block_count; > + /* # of node block writes as roll forward recovery */ > + struct percpu_counter rf_node_block_count; > > /* writeback control */ > atomic_t wb_sync_req[META]; /* count # of WB_SYNC threads */ > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index 93512f8859d5..0d9883457579 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -1782,6 +1782,7 @@ int f2fs_fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode, > > if (!atomic || page == last_page) { > set_fsync_mark(page, 1); > + percpu_counter_inc(&sbi->rf_node_block_count); > if (IS_INODE(page)) { > if (is_inode_flag_set(inode, > FI_DIRTY_INODE)) > @@ -3218,6 +3219,7 @@ static int init_node_manager(struct f2fs_sb_info *sbi) > nm_i->ram_thresh = DEF_RAM_THRESHOLD; > nm_i->ra_nid_pages = DEF_RA_NID_PAGES; > nm_i->dirty_nats_ratio = DEF_DIRTY_NAT_RATIO_THRESHOLD; > + nm_i->max_rf_node_blocks = DEF_RF_NODE_BLOCKS; > > INIT_RADIX_TREE(&nm_i->free_nid_root, GFP_ATOMIC); > INIT_LIST_HEAD(&nm_i->free_nid_list); > diff --git a/fs/f2fs/node.h b/fs/f2fs/node.h > index 18b98cf0465b..fe56fd29c0d3 100644 > --- a/fs/f2fs/node.h > +++ b/fs/f2fs/node.h > @@ -31,6 +31,9 @@ > /* control total # of nats */ > #define DEF_NAT_CACHE_THRESHOLD 100000 > > +/* control total # of node writes used for roll-fowrad recovery */ > +#define DEF_RF_NODE_BLOCKS 100 Will we suffer performance regression issue in some scenarios in where user triggers fsync/fdatasync frequently? e.g. performance test. If this issue is a corner case, it's better to increase DEF_RF_NODE_BLOCKS to avoid affecting common case AMSP? Thanks, > + > /* vector size for gang look-up from nat cache that consists of radix tree */ > #define NATVEC_SIZE 64 > #define SETVEC_SIZE 32 > diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c > index 10d152cfa58d..f69b685fb2b2 100644 > --- a/fs/f2fs/recovery.c > +++ b/fs/f2fs/recovery.c > @@ -53,9 +53,12 @@ extern struct kmem_cache *f2fs_cf_name_slab; > bool f2fs_space_for_roll_forward(struct f2fs_sb_info *sbi) > { > s64 nalloc = percpu_counter_sum_positive(&sbi->alloc_valid_block_count); > + u32 rf_node = percpu_counter_sum_positive(&sbi->rf_node_block_count); > > if (sbi->last_valid_block_count + nalloc > sbi->user_block_count) > return false; > + if (rf_node >= NM_I(sbi)->max_rf_node_blocks) > + return false; > return true; > } > > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c > index 281bc0133ee6..47efcf233afd 100644 > --- a/fs/f2fs/sysfs.c > +++ b/fs/f2fs/sysfs.c > @@ -732,6 +732,7 @@ F2FS_RW_ATTR(SM_INFO, f2fs_sm_info, min_ssr_sections, min_ssr_sections); > F2FS_RW_ATTR(NM_INFO, f2fs_nm_info, ram_thresh, ram_thresh); > F2FS_RW_ATTR(NM_INFO, f2fs_nm_info, ra_nid_pages, ra_nid_pages); > F2FS_RW_ATTR(NM_INFO, f2fs_nm_info, dirty_nats_ratio, dirty_nats_ratio); > +F2FS_RW_ATTR(NM_INFO, f2fs_nm_info, max_roll_forward_node_blocks, max_rf_node_blocks); > F2FS_RW_ATTR(F2FS_SBI, f2fs_sb_info, max_victim_search, max_victim_search); > F2FS_RW_ATTR(F2FS_SBI, f2fs_sb_info, migration_granularity, migration_granularity); > F2FS_RW_ATTR(F2FS_SBI, f2fs_sb_info, dir_level, dir_level); > @@ -855,6 +856,7 @@ static struct attribute *f2fs_attrs[] = { > ATTR_LIST(ram_thresh), > ATTR_LIST(ra_nid_pages), > ATTR_LIST(dirty_nats_ratio), > + ATTR_LIST(max_roll_forward_node_blocks), > ATTR_LIST(cp_interval), > ATTR_LIST(idle_interval), > ATTR_LIST(discard_idle_interval), _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel