All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Subject: Re: [Patch net v4 5/7] net_sched: convert tcf_exts from list to pointer array
Date: Sun, 14 Aug 2016 07:04:00 -0400	[thread overview]
Message-ID: <63d6a947-a367-88bd-4988-f59b51bcda48@mojatatu.com> (raw)
In-Reply-To: <1471152902-12444-6-git-send-email-xiyou.wangcong@gmail.com>

On 16-08-14 01:35 AM, Cong Wang wrote:
> As pointed out by Jamal, an action could be shared by
> multiple filters, so we can't use list to chain them
> any more after we get rid of the original tc_action.
> Instead, we could just save pointers to these actions
> in tcf_exts, since they are refcount'ed, so convert
> the list to an array of pointers.
>
> The "ugly" part is the action API still accepts list
> as a parameter, I just introduce a helper function to
> convert the array of pointers to a list, instead of
> relying on the C99 feature to iterate the array.
>
> Fixes: a85a970af265 ("net_sched: move tc_action into tcf_common")
> Reported-by: Jamal Hadi Salim <jhs@mojatatu.com>
> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>


cheers,
jamal

  reply	other threads:[~2016-08-14 11:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-14  5:34 [Patch net v4 0/7] net_sched: tc action fixes and updates Cong Wang
2016-08-14  5:34 ` [Patch net v4 1/7] net_sched: remove the leftover cleanup_a() Cong Wang
2016-08-14 11:01   ` Jamal Hadi Salim
2016-08-14  5:34 ` [Patch net v4 2/7] net_sched: remove an unnecessary list_del() Cong Wang
2016-08-14 11:01   ` Jamal Hadi Salim
2016-08-14  5:34 ` [Patch net v4 3/7] net_sched: fix a typo in tc_for_each_action() Cong Wang
2016-08-14 11:02   ` Jamal Hadi Salim
2016-08-14  5:34 ` [Patch net v4 4/7] net_sched: move tc offload macros to pkt_cls.h Cong Wang
2016-08-14 11:03   ` Jamal Hadi Salim
2016-08-14  5:35 ` [Patch net v4 5/7] net_sched: convert tcf_exts from list to pointer array Cong Wang
2016-08-14 11:04   ` Jamal Hadi Salim [this message]
2016-08-14  5:35 ` [Patch net v4 6/7] net_sched: unify the init logic for act_police Cong Wang
2016-08-14 11:04   ` Jamal Hadi Salim
2016-08-14  5:35 ` [Patch net v4 7/7] net_sched: allow flushing tc police actions Cong Wang
2016-08-14 11:05   ` Jamal Hadi Salim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63d6a947-a367-88bd-4988-f59b51bcda48@mojatatu.com \
    --to=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.