From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82603C32789 for ; Tue, 6 Nov 2018 08:17:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C35120862 for ; Tue, 6 Nov 2018 08:17:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=yandex-team.ru header.i=@yandex-team.ru header.b="Swm9Y6Cv"; dkim=pass (1024-bit key) header.d=yandex-team.ru header.i=@yandex-team.ru header.b="adgg1oID" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C35120862 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=yandex-team.ru Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729994AbeKFRlK (ORCPT ); Tue, 6 Nov 2018 12:41:10 -0500 Received: from forwardcorp1o.cmail.yandex.net ([37.9.109.47]:44813 "EHLO forwardcorp1o.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728133AbeKFRlJ (ORCPT ); Tue, 6 Nov 2018 12:41:09 -0500 Received: from mxbackcorp1g.mail.yandex.net (mxbackcorp1g.mail.yandex.net [IPv6:2a02:6b8:0:1402::301]) by forwardcorp1o.cmail.yandex.net (Yandex) with ESMTP id 63BAC20F63; Tue, 6 Nov 2018 11:17:04 +0300 (MSK) Received: from smtpcorp1o.mail.yandex.net (smtpcorp1o.mail.yandex.net [2a02:6b8:0:1a2d::30]) by mxbackcorp1g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id YnaxRn5qqW-H3J0diq5; Tue, 06 Nov 2018 11:17:04 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1541492224; bh=VtYABd+o6/lUcLdkhNhck1zV6aEVEq8TNIgLCi2keEg=; h=Subject:To:References:From:Message-ID:Date:In-Reply-To; b=Swm9Y6Cvp3SUFjbYYHT23XOMcP+W594YoQc+Fo3Lg27WVR43wQfoBHHcYAuJI4xya bowUr7UKusQvSmjhxxp/qocYaGGuyCchMuTbtozFEgF2RMBJGTXb+xbz/iPZeqQI/h 9m/ZS/4Z07iytr9uy1rWfoEzhU/7QUUxE1UaVNZU= Received: from dynamic-red.dhcp.yndx.net (dynamic-red.dhcp.yndx.net [2a02:6b8:0:40c:2501:1cc0:44e4:e39a]) by smtpcorp1o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id sxIx9PMn5E-H3oOSIjd; Tue, 06 Nov 2018 11:17:03 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1541492223; bh=VtYABd+o6/lUcLdkhNhck1zV6aEVEq8TNIgLCi2keEg=; h=Subject:To:References:From:Message-ID:Date:In-Reply-To; b=adgg1oID1Z5lg91bVlJ/Fbyz6Jn7F2LUEOpzTz03Te1BuArY73zziXC4bfZdLeec4 28DVKAfOHMMYR36FOn6MUSV97pmJKGNyuF8pDy4i4yQqncdTl/cKIgB2HscFWnpRAu 9PI0j3JE7raQRu0UOuTjEHwZyLduxxkkZKVP5KA4= Authentication-Results: smtpcorp1o.mail.yandex.net; dkim=pass header.i=@yandex-team.ru Subject: Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic To: Arun KS , keescook@chromium.org, minchan@kernel.org, getarunks@gmail.com, gregkh@linuxfoundation.org, akpm@linux-foundation.org, mhocko@kernel.org, vbabka@suse.cz, linux-kernel@vger.kernel.org, linux-mm@kvack.org, julia.lawall@lip6.fr References: <1540551662-26458-1-git-send-email-arunks@codeaurora.org> <9b210d4cc9925caf291412d7d45f16d7@codeaurora.org> From: Konstantin Khlebnikov Message-ID: <63d9f48c-e39f-d345-0fb6-2f04afe769a2@yandex-team.ru> Date: Tue, 6 Nov 2018 11:17:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <9b210d4cc9925caf291412d7d45f16d7@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-CA Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06.11.2018 8:38, Arun KS wrote: > Any comments? Looks good. Except unclear motivation behind this change. This should be in comment of one of patch. Reviewed-by: Konstantin Khlebnikov > > Regards, > Arun > > On 2018-10-26 16:30, Arun KS wrote: >> This series convert totalram_pages, totalhigh_pages and >> zone->managed_pages to atomic variables. >> >> The patch was comiple tested on x86(x86_64_defconfig & i386_defconfig) >> on tip of linux-mmotm. And memory hotplug tested on arm64, but on an >> older version of kernel. >> >> Arun KS (4): >>   mm: Fix multiple evaluvations of totalram_pages and managed_pages >>   mm: Convert zone->managed_pages to atomic variable >>   mm: convert totalram_pages and totalhigh_pages variables to atomic >>   mm: Remove managed_page_count spinlock >> >>  arch/csky/mm/init.c                           |  4 +- >>  arch/powerpc/platforms/pseries/cmm.c          | 10 ++-- >>  arch/s390/mm/init.c                           |  2 +- >>  arch/um/kernel/mem.c                          |  3 +- >>  arch/x86/kernel/cpu/microcode/core.c          |  5 +- >>  drivers/char/agp/backend.c                    |  4 +- >>  drivers/gpu/drm/amd/amdkfd/kfd_crat.c         |  2 +- >>  drivers/gpu/drm/i915/i915_gem.c               |  2 +- >>  drivers/gpu/drm/i915/selftests/i915_gem_gtt.c |  4 +- >>  drivers/hv/hv_balloon.c                       | 19 +++---- >>  drivers/md/dm-bufio.c                         |  2 +- >>  drivers/md/dm-crypt.c                         |  2 +- >>  drivers/md/dm-integrity.c                     |  2 +- >>  drivers/md/dm-stats.c                         |  2 +- >>  drivers/media/platform/mtk-vpu/mtk_vpu.c      |  2 +- >>  drivers/misc/vmw_balloon.c                    |  2 +- >>  drivers/parisc/ccio-dma.c                     |  4 +- >>  drivers/parisc/sba_iommu.c                    |  4 +- >>  drivers/staging/android/ion/ion_system_heap.c |  2 +- >>  drivers/xen/xen-selfballoon.c                 |  6 +-- >>  fs/ceph/super.h                               |  2 +- >>  fs/file_table.c                               |  7 +-- >>  fs/fuse/inode.c                               |  2 +- >>  fs/nfs/write.c                                |  2 +- >>  fs/nfsd/nfscache.c                            |  2 +- >>  fs/ntfs/malloc.h                              |  2 +- >>  fs/proc/base.c                                |  2 +- >>  include/linux/highmem.h                       | 28 ++++++++++- >>  include/linux/mm.h                            | 27 +++++++++- >>  include/linux/mmzone.h                        | 15 +++--- >>  include/linux/swap.h                          |  1 - >>  kernel/fork.c                                 |  5 +- >>  kernel/kexec_core.c                           |  5 +- >>  kernel/power/snapshot.c                       |  2 +- >>  lib/show_mem.c                                |  2 +- >>  mm/highmem.c                                  |  4 +- >>  mm/huge_memory.c                              |  2 +- >>  mm/kasan/quarantine.c                         |  2 +- >>  mm/memblock.c                                 |  6 +-- >>  mm/memory_hotplug.c                           |  4 +- >>  mm/mm_init.c                                  |  2 +- >>  mm/oom_kill.c                                 |  2 +- >>  mm/page_alloc.c                               | 71 +++++++++++++-------------- >>  mm/shmem.c                                    |  7 +-- >>  mm/slab.c                                     |  2 +- >>  mm/swap.c                                     |  2 +- >>  mm/util.c                                     |  2 +- >>  mm/vmalloc.c                                  |  4 +- >>  mm/vmstat.c                                   |  4 +- >>  mm/workingset.c                               |  2 +- >>  mm/zswap.c                                    |  4 +- >>  net/dccp/proto.c                              |  7 +-- >>  net/decnet/dn_route.c                         |  2 +- >>  net/ipv4/tcp_metrics.c                        |  2 +- >>  net/netfilter/nf_conntrack_core.c             |  7 +-- >>  net/netfilter/xt_hashlimit.c                  |  5 +- >>  net/sctp/protocol.c                           |  7 +-- >>  security/integrity/ima/ima_kexec.c            |  2 +- >>  58 files changed, 195 insertions(+), 144 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by kanga.kvack.org (Postfix) with ESMTP id AD1A76B02C8 for ; Tue, 6 Nov 2018 03:17:06 -0500 (EST) Received: by mail-lf1-f72.google.com with SMTP id z14-v6so1525851lfh.13 for ; Tue, 06 Nov 2018 00:17:06 -0800 (PST) Received: from forwardcorp1o.cmail.yandex.net (forwardcorp1o.cmail.yandex.net. [37.9.109.47]) by mx.google.com with ESMTPS id c22si36071773lfd.129.2018.11.06.00.17.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 00:17:04 -0800 (PST) Subject: Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic References: <1540551662-26458-1-git-send-email-arunks@codeaurora.org> <9b210d4cc9925caf291412d7d45f16d7@codeaurora.org> From: Konstantin Khlebnikov Message-ID: <63d9f48c-e39f-d345-0fb6-2f04afe769a2@yandex-team.ru> Date: Tue, 6 Nov 2018 11:17:02 +0300 MIME-Version: 1.0 In-Reply-To: <9b210d4cc9925caf291412d7d45f16d7@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-CA Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Arun KS , keescook@chromium.org, minchan@kernel.org, getarunks@gmail.com, gregkh@linuxfoundation.org, akpm@linux-foundation.org, mhocko@kernel.org, vbabka@suse.cz, linux-kernel@vger.kernel.org, linux-mm@kvack.org, julia.lawall@lip6.fr On 06.11.2018 8:38, Arun KS wrote: > Any comments? Looks good. Except unclear motivation behind this change. This should be in comment of one of patch. Reviewed-by: Konstantin Khlebnikov > > Regards, > Arun > > On 2018-10-26 16:30, Arun KS wrote: >> This series convert totalram_pages, totalhigh_pages and >> zone->managed_pages to atomic variables. >> >> The patch was comiple tested on x86(x86_64_defconfig & i386_defconfig) >> on tip of linux-mmotm. And memory hotplug tested on arm64, but on an >> older version of kernel. >> >> Arun KS (4): >> A mm: Fix multiple evaluvations of totalram_pages and managed_pages >> A mm: Convert zone->managed_pages to atomic variable >> A mm: convert totalram_pages and totalhigh_pages variables to atomic >> A mm: Remove managed_page_count spinlock >> >> A arch/csky/mm/init.cA A A A A A A A A A A A A A A A A A A A A A A A A A |A 4 +- >> A arch/powerpc/platforms/pseries/cmm.cA A A A A A A A A | 10 ++-- >> A arch/s390/mm/init.cA A A A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A arch/um/kernel/mem.cA A A A A A A A A A A A A A A A A A A A A A A A A |A 3 +- >> A arch/x86/kernel/cpu/microcode/core.cA A A A A A A A A |A 5 +- >> A drivers/char/agp/backend.cA A A A A A A A A A A A A A A A A A A |A 4 +- >> A drivers/gpu/drm/amd/amdkfd/kfd_crat.cA A A A A A A A |A 2 +- >> A drivers/gpu/drm/i915/i915_gem.cA A A A A A A A A A A A A A |A 2 +- >> A drivers/gpu/drm/i915/selftests/i915_gem_gtt.c |A 4 +- >> A drivers/hv/hv_balloon.cA A A A A A A A A A A A A A A A A A A A A A | 19 +++---- >> A drivers/md/dm-bufio.cA A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A drivers/md/dm-crypt.cA A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A drivers/md/dm-integrity.cA A A A A A A A A A A A A A A A A A A A |A 2 +- >> A drivers/md/dm-stats.cA A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A drivers/media/platform/mtk-vpu/mtk_vpu.cA A A A A |A 2 +- >> A drivers/misc/vmw_balloon.cA A A A A A A A A A A A A A A A A A A |A 2 +- >> A drivers/parisc/ccio-dma.cA A A A A A A A A A A A A A A A A A A A |A 4 +- >> A drivers/parisc/sba_iommu.cA A A A A A A A A A A A A A A A A A A |A 4 +- >> A drivers/staging/android/ion/ion_system_heap.c |A 2 +- >> A drivers/xen/xen-selfballoon.cA A A A A A A A A A A A A A A A |A 6 +-- >> A fs/ceph/super.hA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A fs/file_table.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 7 +-- >> A fs/fuse/inode.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A fs/nfs/write.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A fs/nfsd/nfscache.cA A A A A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A fs/ntfs/malloc.hA A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A fs/proc/base.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A include/linux/highmem.hA A A A A A A A A A A A A A A A A A A A A A | 28 ++++++++++- >> A include/linux/mm.hA A A A A A A A A A A A A A A A A A A A A A A A A A A | 27 +++++++++- >> A include/linux/mmzone.hA A A A A A A A A A A A A A A A A A A A A A A | 15 +++--- >> A include/linux/swap.hA A A A A A A A A A A A A A A A A A A A A A A A A |A 1 - >> A kernel/fork.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 5 +- >> A kernel/kexec_core.cA A A A A A A A A A A A A A A A A A A A A A A A A A |A 5 +- >> A kernel/power/snapshot.cA A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A lib/show_mem.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A mm/highmem.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 4 +- >> A mm/huge_memory.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A mm/kasan/quarantine.cA A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A mm/memblock.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 6 +-- >> A mm/memory_hotplug.cA A A A A A A A A A A A A A A A A A A A A A A A A A |A 4 +- >> A mm/mm_init.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A mm/oom_kill.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A mm/page_alloc.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A | 71 +++++++++++++-------------- >> A mm/shmem.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 7 +-- >> A mm/slab.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A mm/swap.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A mm/util.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A mm/vmalloc.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 4 +- >> A mm/vmstat.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 4 +- >> A mm/workingset.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A mm/zswap.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 4 +- >> A net/dccp/proto.cA A A A A A A A A A A A A A A A A A A A A A A A A A A A A |A 7 +-- >> A net/decnet/dn_route.cA A A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A net/ipv4/tcp_metrics.cA A A A A A A A A A A A A A A A A A A A A A A |A 2 +- >> A net/netfilter/nf_conntrack_core.cA A A A A A A A A A A A |A 7 +-- >> A net/netfilter/xt_hashlimit.cA A A A A A A A A A A A A A A A A |A 5 +- >> A net/sctp/protocol.cA A A A A A A A A A A A A A A A A A A A A A A A A A |A 7 +-- >> A security/integrity/ima/ima_kexec.cA A A A A A A A A A A |A 2 +- >> A 58 files changed, 195 insertions(+), 144 deletions(-)