From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 807B2C07E96 for ; Thu, 15 Jul 2021 08:43:00 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C60CF611AB for ; Thu, 15 Jul 2021 08:42:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C60CF611AB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F2E5181FC6; Thu, 15 Jul 2021 10:42:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1626338578; bh=qgQypEMfLoRmm2mPVJZ//CStR//s8rvpLMVp5SAfcgc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Iz3XSeOPtdyTxd/LiHNl/q8ybThuVaSauoVsk72oX0mTBlC82/0zHfA1PneItIKUr /A8AYFaQdXXx8zkNayquz0Zg3bapgFzRl1fM727nCfXygmbzq9BfTaREKOj/NMjE08 RcBVMhpda0Zo1qy+iMoqD8K/GQP4THX1Z8csCBbcicdDXQQcoanyxP4be8hFDrECP1 c+8Q1FNnKJKzTLhbF77U3VsyaUZMjKYjUtlu2aS1fF7VJttQlDsiLCPvzQOaNP7zLB nnWovRiT5svVvnl0/sVx4UpEPNvlctWJv08fcKHThPFs2OMeLTg6RBdCe3MzcJcr+v mwo4zVo3XW4PA== Received: by phobos.denx.de (Postfix, from userid 109) id 1E2EE81FC6; Thu, 15 Jul 2021 10:42:56 +0200 (CEST) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [IPv6:2001:67c:2050:1::465:204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8013281E53 for ; Thu, 15 Jul 2021 10:42:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4GQSYn2040zQkBD; Thu, 15 Jul 2021 10:42:53 +0200 (CEST) Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id F-gpkA_LzNgT; Thu, 15 Jul 2021 10:42:50 +0200 (CEST) Subject: Re: [PATCH u-boot-mvebu 18/31] arm: mvebu: Fix return_to_bootrom() To: =?UTF-8?Q?Marek_Beh=c3=ban?= , u-boot@lists.denx.de, Chris Packham , Baruch Siach , Dirk Eibach , Chris Packham Cc: Dennis Gilmore , Mario Six , Jon Nettleton , =?UTF-8?Q?Pali_Roh=c3=a1r?= References: <20210708173032.27999-1-marek.behun@nic.cz> <20210708173032.27999-19-marek.behun@nic.cz> From: Stefan Roese Message-ID: <63dbd188-fb3c-ca47-0deb-af10e990a1f2@denx.de> Date: Thu, 15 Jul 2021 10:42:49 +0200 MIME-Version: 1.0 In-Reply-To: <20210708173032.27999-19-marek.behun@nic.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-MBO-SPAM-Probability: X-Rspamd-Score: -5.06 / 15.00 / 15.00 X-Rspamd-Queue-Id: 5B3EF1833 X-Rspamd-UID: fc36c2 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 08.07.21 19:30, Marek Behún wrote: > From: Pali Rohár > > Register r0 should be set to return value 0x0 - NO_ERR. > > Set r0 with return value after all registers are restored from the > stack, so that the return value is always correct. > > Signed-off-by: Pali Rohár > Fixes: 944c7a317675 ("arm: mvebu: Add option to use UART xmodem protocol via kwboot") > Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan > --- > arch/arm/mach-mvebu/lowlevel_spl.S | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-mvebu/lowlevel_spl.S b/arch/arm/mach-mvebu/lowlevel_spl.S > index 8718d7a43e..dde77b7652 100644 > --- a/arch/arm/mach-mvebu/lowlevel_spl.S > +++ b/arch/arm/mach-mvebu/lowlevel_spl.S > @@ -13,8 +13,9 @@ ENDPROC(save_boot_params) > ENTRY(return_to_bootrom) > ldr r12, =CONFIG_SPL_BOOTROM_SAVE > ldr sp, [r12] > + ldmfd sp!, {r0 - r12, lr} /* @ restore registers from stack */ > mov r0, #0x0 /* @ return value: 0x0 NO_ERR */ > - ldmfd sp!, {r0 - r12, pc} /* @ restore regs and return */ > + bx lr /* @ return to bootrom */ > ENDPROC(return_to_bootrom) > > /* > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de