On 15.02.21 22:35, Boris Ostrovsky wrote: > > On 2/11/21 5:16 AM, Juergen Gross wrote: > >> @@ -622,6 +623,7 @@ static void xen_irq_lateeoi_locked(struct irq_info *info, bool spurious) >> } >> >> info->eoi_time = 0; >> + smp_store_release(&info->is_active, 0); > > > Can this be done in lateeoi_ack_dynirq()/lateeoi_mask_ack_dynirq(), after we've masked the channel? Then it will be consistent with how how other chips do it, especially with the new helper. Yes, I think this should work. Juergen