From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5E02C4363A for ; Tue, 20 Oct 2020 14:55:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50A2E22251 for ; Tue, 20 Oct 2020 14:55:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cK9G7+OH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731470AbgJTOzt (ORCPT ); Tue, 20 Oct 2020 10:55:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728489AbgJTOzt (ORCPT ); Tue, 20 Oct 2020 10:55:49 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27817C0613D1 for ; Tue, 20 Oct 2020 07:55:49 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id d81so2106005wmc.1 for ; Tue, 20 Oct 2020 07:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uf/L+N0SXiT5GxWzSMpW76s8MjBMaRe3gnVIlCSIR5M=; b=cK9G7+OH/TUQCyR8rfJv0QoQ3SjEQsnF9XCjVN6xqr/O8yU3IlDfbvmsbTfkhxQ06f q4IpVZ8VlQ3fVXlWWHGSfLpylD2IH5P4NE25315km3BTplz4wROeM/cLeRnrZhnHb/v5 PyAaPitLsRWmdVTipbLqX4Out+F21VmQJ/X09y763klLznhk8Wjph5Dm6ltToTwu1GKi 6cF9SRXzSOe+CnDRgo2LkN4n5tkvfZ7EpQsA7EkHbGt3NkoE1mD/PmAfdxkXt8UbFE9X RN1mqjge119zJMoJpTqXMa+rN2apg4iQxVK+dpL4RLHKRIlCnNkTt3EAvl5wmXLl4Uz1 eT1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uf/L+N0SXiT5GxWzSMpW76s8MjBMaRe3gnVIlCSIR5M=; b=LQgHi4VVFAdKDQER0OT4kitjkRtse/gY3UFAg9WiAhz4I25N1zIFASKWumHhLvifMw +OewHp5Vyp3NoEgiN/c4Z9BugOU/oGTuZT/1Ctkf54A30sddtDmIfO2YmvJ3fE2GRqzK qQqMgnzR/Odgbhzka7lzTH+HipSOzpWR3KXe2MfIgUUzg1LgSiQerQW0vW2Ks/MGyMva NTXqOyuhdQ+pBThI3t1Ska+tf9qsVZ6kjkfaRs5h+LxnrNYsMgW6YHSNby/oyGwIH1He H+gWd4QVHmhgyezyiKWadXXcAcQrPCyN3ZR5RB9P8lXB3FCpIlkGeH+XeJOykGwapB2m WN0w== X-Gm-Message-State: AOAM533A5pbTcGkq2CIMEhEd9zJKT675hd5tliKvn+/iS1nBfMI74hnh UEhrhbfpKGXH/ndpE/vYhPaQTw== X-Google-Smtp-Source: ABdhPJwZTIfXIjPLWWjL97y1NfJTXN0Y2s/to/X10G0kOS41vqvGeaVeSXPhf5OZA0t9DHJLkiPgNg== X-Received: by 2002:a7b:ce8f:: with SMTP id q15mr3351776wmj.88.1603205747699; Tue, 20 Oct 2020 07:55:47 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id 1sm3868599wre.61.2020.10.20.07.55.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2020 07:55:46 -0700 (PDT) Subject: Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings To: Mark Brown , Cheng-yi Chiang Cc: linux-kernel , Taniya Das , Rohit kumar , Banajit Goswami , Patrick Lai , Andy Gross , Bjorn Andersson , Liam Girdwood , Rob Herring , Jaroslav Kysela , Takashi Iwai , Stephan Gerhold , Matthias Brugger , Heiko Stuebner , Srinivasa Rao , Doug Anderson , Dylan Reid , Tzung-Bi Shih , Linux ARM , linux-arm-msm , Kuninori Morimoto , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , "moderated list:ARM/Mediatek SoC support" , "open list:ARM/Rockchip SoC..." , Ajye Huang References: <20200914080619.4178587-1-cychiang@chromium.org> <20200914080619.4178587-3-cychiang@chromium.org> <7bdc0d63-27b1-f99e-c5f8-65f880733d16@linaro.org> <20201015161251.GF4390@sirena.org.uk> <20201020143711.GC9448@sirena.org.uk> From: Srinivas Kandagatla Message-ID: <63f1a29c-0758-97b8-ce80-fe43d91630fa@linaro.org> Date: Tue, 20 Oct 2020 15:55:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20201020143711.GC9448@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 20/10/2020 15:37, Mark Brown wrote: > I don't understand what "logic scattered in various dtsi files" means, > sorry. > >> Yes, that should work to describe the dailink we are using. >> But a more tricky issue is how to do calls like setting PLL in dai startup ops. > ... > >> I think that asking a generic machine driver to do configuration like >> this with only a limited interface of device property >> might be too much of an ask for the machine driver. > Richard was looking at some basic configuration for PLLs. > >> Would you mind if I simplify the compatible string like Srinivas >> suggested, and send a v12? >> As for other two kinds of variations that I am aware of: >> 1. front mic / rear mic >> 2. replace alc5682 with adau7002 > The CODEC change is going to be described in the DT no matter what - > you'll have a reference to the CODEC node but it may make sense if > there's enough custom code around it. For front vs rear mic the > simplest thing would just be to not mention which if this is a hardware > fixed thing, otherwise a control. > >> We can set different board names and different compatible strings to >> achieve such variation. >> So that it would make sense to describe configuration in compatible >> strings like you suggested, and also provides UCM a way to distinguish >> different boards. > I don't recall having suggested distinguishing these things with a > compatible string, especially not the microphones. UCM can already use > the display names for the boards to distinguish things. Not with the compatible string! Currently card name, and long name are exactly same in all Qualcomm soundcards, which makes it very difficult to identify how those boards re wired up at UCM2 level. So the plan is to properly populate card long name with "model" property which can include details on how things are wiredup on that board. --srini From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FB30C4363A for ; Tue, 20 Oct 2020 14:56:51 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B2562222C for ; Tue, 20 Oct 2020 14:56:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="k0NijiG4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cK9G7+OH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B2562222C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B183116F0; Tue, 20 Oct 2020 16:55:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B183116F0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1603205806; bh=+RVX4b8B9a0PTXNSim83hRWmrjf6URtR5fzGQj2Ddns=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=k0NijiG4mTJLLcUlv65HPZX1OirNLb1CpyJteT4zqDRvvdDAohRZu/xA25Wl3dowx 2LtnL8bfDiWfylitu87oqdFui98wKDUY5NlvOkuhW0glEDPmJwBCZ6SUJLfbQf64ye sX4KaYvr1WZY4jxMn497VREGXbwHC0gA5oeBtff0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 30108F8010F; Tue, 20 Oct 2020 16:55:56 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A1422F801F2; Tue, 20 Oct 2020 16:55:53 +0200 (CEST) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E46A2F8010F for ; Tue, 20 Oct 2020 16:55:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E46A2F8010F Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cK9G7+OH" Received: by mail-wm1-x344.google.com with SMTP id a72so2106597wme.5 for ; Tue, 20 Oct 2020 07:55:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uf/L+N0SXiT5GxWzSMpW76s8MjBMaRe3gnVIlCSIR5M=; b=cK9G7+OH/TUQCyR8rfJv0QoQ3SjEQsnF9XCjVN6xqr/O8yU3IlDfbvmsbTfkhxQ06f q4IpVZ8VlQ3fVXlWWHGSfLpylD2IH5P4NE25315km3BTplz4wROeM/cLeRnrZhnHb/v5 PyAaPitLsRWmdVTipbLqX4Out+F21VmQJ/X09y763klLznhk8Wjph5Dm6ltToTwu1GKi 6cF9SRXzSOe+CnDRgo2LkN4n5tkvfZ7EpQsA7EkHbGt3NkoE1mD/PmAfdxkXt8UbFE9X RN1mqjge119zJMoJpTqXMa+rN2apg4iQxVK+dpL4RLHKRIlCnNkTt3EAvl5wmXLl4Uz1 eT1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uf/L+N0SXiT5GxWzSMpW76s8MjBMaRe3gnVIlCSIR5M=; b=ZKTVmCjd1q/O81awJm36hwyfU6Gz4aQJmfRdPXD9G4LwRZ4Si2nkceSUB03iYES98i m2vyADZM5MxGtSpLm3652wpFLa4nern7eWcZxwa/7f2JExEhss1Woa3dQWa/EsGMBaHU HVompljNzfN9Oq+5onBz7ezin8h2wv2rcEt9wvqpw5Nw773L0wsBfLhB5sVD4HP4HjaH S915kmvO8R5PYboio/9hi+OJ/b/fgwbk5XxjtzsxM/BRaJew/+JYam5sFWS12+R/PWx3 dNFWTZUg1FEg88GBmt2xVmF+FeWlDbJ1KsawvqEPIQuyZIXpMjOIM7+q0q31wy1pDPWw fbMw== X-Gm-Message-State: AOAM531Cg86ohqaJJ7ayCxiQR43m5KRX0C1+BPbtVdygfziUSOh34e1n rcPD8MyWuAn08jMMwKPVm8eE8w== X-Google-Smtp-Source: ABdhPJwZTIfXIjPLWWjL97y1NfJTXN0Y2s/to/X10G0kOS41vqvGeaVeSXPhf5OZA0t9DHJLkiPgNg== X-Received: by 2002:a7b:ce8f:: with SMTP id q15mr3351776wmj.88.1603205747699; Tue, 20 Oct 2020 07:55:47 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id 1sm3868599wre.61.2020.10.20.07.55.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2020 07:55:46 -0700 (PDT) Subject: Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings To: Mark Brown , Cheng-yi Chiang References: <20200914080619.4178587-1-cychiang@chromium.org> <20200914080619.4178587-3-cychiang@chromium.org> <7bdc0d63-27b1-f99e-c5f8-65f880733d16@linaro.org> <20201015161251.GF4390@sirena.org.uk> <20201020143711.GC9448@sirena.org.uk> From: Srinivas Kandagatla Message-ID: <63f1a29c-0758-97b8-ce80-fe43d91630fa@linaro.org> Date: Tue, 20 Oct 2020 15:55:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20201020143711.GC9448@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Taniya Das , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Banajit Goswami , Heiko Stuebner , Kuninori Morimoto , Takashi Iwai , Rohit kumar , Ajye Huang , Patrick Lai , "open list:ARM/Rockchip SoC..." , Andy Gross , Dylan Reid , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Tzung-Bi Shih , Srinivasa Rao , Stephan Gerhold , linux-arm-msm , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Bjorn Andersson , Linux ARM , Doug Anderson , Liam Girdwood , linux-kernel X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 20/10/2020 15:37, Mark Brown wrote: > I don't understand what "logic scattered in various dtsi files" means, > sorry. > >> Yes, that should work to describe the dailink we are using. >> But a more tricky issue is how to do calls like setting PLL in dai startup ops. > ... > >> I think that asking a generic machine driver to do configuration like >> this with only a limited interface of device property >> might be too much of an ask for the machine driver. > Richard was looking at some basic configuration for PLLs. > >> Would you mind if I simplify the compatible string like Srinivas >> suggested, and send a v12? >> As for other two kinds of variations that I am aware of: >> 1. front mic / rear mic >> 2. replace alc5682 with adau7002 > The CODEC change is going to be described in the DT no matter what - > you'll have a reference to the CODEC node but it may make sense if > there's enough custom code around it. For front vs rear mic the > simplest thing would just be to not mention which if this is a hardware > fixed thing, otherwise a control. > >> We can set different board names and different compatible strings to >> achieve such variation. >> So that it would make sense to describe configuration in compatible >> strings like you suggested, and also provides UCM a way to distinguish >> different boards. > I don't recall having suggested distinguishing these things with a > compatible string, especially not the microphones. UCM can already use > the display names for the boards to distinguish things. Not with the compatible string! Currently card name, and long name are exactly same in all Qualcomm soundcards, which makes it very difficult to identify how those boards re wired up at UCM2 level. So the plan is to properly populate card long name with "model" property which can include details on how things are wiredup on that board. --srini From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACFFBC4363D for ; Tue, 20 Oct 2020 14:56:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEF2321741 for ; Tue, 20 Oct 2020 14:55:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Sxjgy7ZI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cK9G7+OH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEF2321741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=d7WmqZob0V/PtcMFsrXP3QoFuqmaCtLKjyzeIuzzAIM=; b=Sxjgy7ZIWFfAVz/N4d5Q+u98B 6KK3m/dcxwf1pV7ceecINWf6yDP+poIyyDrYsmjroxcXNy/tpW+0lhzQlkUDcEuyoDIn2LRmd8Ngx 3mz5D3EIxVzfO+KznxzVH8tWqle3EWdmaPXVzut/4M+wPOWwS9AK6im1pr30/vUCB9gObtj6JeAtQ +wbOyzLh52Vf0hIL4iHV8mD31rDcUBpl9LGkwTj5CtGy1iAutuCgvRHCeQL4q1CPtPQ1PpMAe1MGK Qd5vFOcJ0BPljiBJhZpasMCFxtco26NRwYH3b8O5M2keCVUVTI28jsV4v95jg6DRO3L+2f9Uboj// lQhgaTiSw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUt3K-0001mM-31; Tue, 20 Oct 2020 14:55:54 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUt3G-0001kW-92 for linux-rockchip@lists.infradead.org; Tue, 20 Oct 2020 14:55:51 +0000 Received: by mail-wm1-x341.google.com with SMTP id a72so2106596wme.5 for ; Tue, 20 Oct 2020 07:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uf/L+N0SXiT5GxWzSMpW76s8MjBMaRe3gnVIlCSIR5M=; b=cK9G7+OH/TUQCyR8rfJv0QoQ3SjEQsnF9XCjVN6xqr/O8yU3IlDfbvmsbTfkhxQ06f q4IpVZ8VlQ3fVXlWWHGSfLpylD2IH5P4NE25315km3BTplz4wROeM/cLeRnrZhnHb/v5 PyAaPitLsRWmdVTipbLqX4Out+F21VmQJ/X09y763klLznhk8Wjph5Dm6ltToTwu1GKi 6cF9SRXzSOe+CnDRgo2LkN4n5tkvfZ7EpQsA7EkHbGt3NkoE1mD/PmAfdxkXt8UbFE9X RN1mqjge119zJMoJpTqXMa+rN2apg4iQxVK+dpL4RLHKRIlCnNkTt3EAvl5wmXLl4Uz1 eT1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uf/L+N0SXiT5GxWzSMpW76s8MjBMaRe3gnVIlCSIR5M=; b=iE3YSM5mafvJ3Kq4GZfQe5PBVGKGKFtlm1gTDWSPxg1Cgh5L8ZSLZJXE8wCGXi6D2T ucqlpGpOjOtJkBvGGFdMsI754mnhERZH/7gF7Z9HSRDf2Ma0iBCwZYCwgEVsOFaGW8yu stLPT8Lsc7pUdA2u4aSOy4aw29+OaT1LWRjrB+FQGgZTQ7GVMoY2lGICt3CLM1roey9D Z+cTauFy8ptAOvNbsr7zq3+PcThGuXwttU8cCRg9oZ5SKF5hIYYCpw5zzpF+GNndIzKB pA2EQCugBsakusb+NdxMR76xbAdtJOF0i40VBoX4oi60UNOWIh3XeVjPLucbvcRRx/MI MoLQ== X-Gm-Message-State: AOAM53393ivg2H8qzLTXBbimohPwr0VZrxG2xg7uwVGKUy9BYPSGz/Tf a7XHgon82ohGkVdeyYWpki2UUw== X-Google-Smtp-Source: ABdhPJwZTIfXIjPLWWjL97y1NfJTXN0Y2s/to/X10G0kOS41vqvGeaVeSXPhf5OZA0t9DHJLkiPgNg== X-Received: by 2002:a7b:ce8f:: with SMTP id q15mr3351776wmj.88.1603205747699; Tue, 20 Oct 2020 07:55:47 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id 1sm3868599wre.61.2020.10.20.07.55.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2020 07:55:46 -0700 (PDT) Subject: Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings To: Mark Brown , Cheng-yi Chiang References: <20200914080619.4178587-1-cychiang@chromium.org> <20200914080619.4178587-3-cychiang@chromium.org> <7bdc0d63-27b1-f99e-c5f8-65f880733d16@linaro.org> <20201015161251.GF4390@sirena.org.uk> <20201020143711.GC9448@sirena.org.uk> From: Srinivas Kandagatla Message-ID: <63f1a29c-0758-97b8-ce80-fe43d91630fa@linaro.org> Date: Tue, 20 Oct 2020 15:55:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20201020143711.GC9448@sirena.org.uk> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201020_105550_345816_9AA864A5 X-CRM114-Status: GOOD ( 22.39 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Taniya Das , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Banajit Goswami , Heiko Stuebner , Kuninori Morimoto , Takashi Iwai , Rohit kumar , Ajye Huang , Patrick Lai , "open list:ARM/Rockchip SoC..." , Andy Gross , Dylan Reid , Jaroslav Kysela , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Tzung-Bi Shih , Srinivasa Rao , Stephan Gerhold , linux-arm-msm , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Bjorn Andersson , Linux ARM , Doug Anderson , Liam Girdwood , linux-kernel Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 20/10/2020 15:37, Mark Brown wrote: > I don't understand what "logic scattered in various dtsi files" means, > sorry. > >> Yes, that should work to describe the dailink we are using. >> But a more tricky issue is how to do calls like setting PLL in dai startup ops. > ... > >> I think that asking a generic machine driver to do configuration like >> this with only a limited interface of device property >> might be too much of an ask for the machine driver. > Richard was looking at some basic configuration for PLLs. > >> Would you mind if I simplify the compatible string like Srinivas >> suggested, and send a v12? >> As for other two kinds of variations that I am aware of: >> 1. front mic / rear mic >> 2. replace alc5682 with adau7002 > The CODEC change is going to be described in the DT no matter what - > you'll have a reference to the CODEC node but it may make sense if > there's enough custom code around it. For front vs rear mic the > simplest thing would just be to not mention which if this is a hardware > fixed thing, otherwise a control. > >> We can set different board names and different compatible strings to >> achieve such variation. >> So that it would make sense to describe configuration in compatible >> strings like you suggested, and also provides UCM a way to distinguish >> different boards. > I don't recall having suggested distinguishing these things with a > compatible string, especially not the microphones. UCM can already use > the display names for the boards to distinguish things. Not with the compatible string! Currently card name, and long name are exactly same in all Qualcomm soundcards, which makes it very difficult to identify how those boards re wired up at UCM2 level. So the plan is to properly populate card long name with "model" property which can include details on how things are wiredup on that board. --srini _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 599AEC4363A for ; Tue, 20 Oct 2020 14:56:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C98EE21741 for ; Tue, 20 Oct 2020 14:56:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P6Amm/E0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cK9G7+OH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C98EE21741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=O3vzFZZj+9bqDXCGJG320VVUEwA219r0CT16IU7spqg=; b=P6Amm/E06jYuejNwEjl9MU01p M9WZ0Q8iypDYR1pn4KSgIqTNHV+/3vG/SX1yIxPl7GfUd/07cmwXS5yzQC5pgyocDaOPApgZRenWz hmfvx4p0o3o/L3qIYWOrF42GyqSUUs6iuJfL73K15rVNdNwfNQnwdgAaCph08Gv7p2xVFCIv71kxr +C3n9FM402qbsccmYnKaqfEkkm5vp+a2M69DoV9Kgo1SnD8p4NDL7YR+zYo918MGvzQSfVcF5zGvv qjAa3d5Uz4xcPBRGGLw5Dcs2qk+sXF3LlceTSZtxZtuWv9AJcx81QjBhugS+CKuo3rTg3Emwt5dO2 ioFqIWwqA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUt3I-0001mD-VP; Tue, 20 Oct 2020 14:55:53 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUt3G-0001kV-4a for linux-mediatek@lists.infradead.org; Tue, 20 Oct 2020 14:55:51 +0000 Received: by mail-wm1-x343.google.com with SMTP id 13so2117031wmf.0 for ; Tue, 20 Oct 2020 07:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uf/L+N0SXiT5GxWzSMpW76s8MjBMaRe3gnVIlCSIR5M=; b=cK9G7+OH/TUQCyR8rfJv0QoQ3SjEQsnF9XCjVN6xqr/O8yU3IlDfbvmsbTfkhxQ06f q4IpVZ8VlQ3fVXlWWHGSfLpylD2IH5P4NE25315km3BTplz4wROeM/cLeRnrZhnHb/v5 PyAaPitLsRWmdVTipbLqX4Out+F21VmQJ/X09y763klLznhk8Wjph5Dm6ltToTwu1GKi 6cF9SRXzSOe+CnDRgo2LkN4n5tkvfZ7EpQsA7EkHbGt3NkoE1mD/PmAfdxkXt8UbFE9X RN1mqjge119zJMoJpTqXMa+rN2apg4iQxVK+dpL4RLHKRIlCnNkTt3EAvl5wmXLl4Uz1 eT1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uf/L+N0SXiT5GxWzSMpW76s8MjBMaRe3gnVIlCSIR5M=; b=cJ5Ax4UK+piyRn6lLdG39gJ5vNfs1xZ7XRm7n0D9uaDPjWz0U5OkuBb++IHYFIPRva Tf6UlqBlfa5HVnDVktyWbwLGAsQx5tLGfpYbZFrgigQZlKAIzj92b8FAUm4PjzgNp2M+ kAAK9gz8YvZSMXIkiGKGlFhsI+tKjfyDZtg4f/3Fd4Htfk9hLIGXgSYx3S6/zSWKDuR0 aDSv0y6uS7ToiedX7wPkyqDX21k/iudXY360GAcScRvR+YdfldvevByldYINDPha0ir6 kFY5p0NuvRtvjL78JN82v0jMyKWUsdHjh8TiE37gVivUeb2pLDCZ/FKXrjQolCzy6sKH Imng== X-Gm-Message-State: AOAM5329fTm7skG2/o8hRRlK7zbX9+Qr5g+TMIHdD6gTf446Wfm7i6nX xdsI/CM7e9/ipUE8JTFu18Mn5g== X-Google-Smtp-Source: ABdhPJwZTIfXIjPLWWjL97y1NfJTXN0Y2s/to/X10G0kOS41vqvGeaVeSXPhf5OZA0t9DHJLkiPgNg== X-Received: by 2002:a7b:ce8f:: with SMTP id q15mr3351776wmj.88.1603205747699; Tue, 20 Oct 2020 07:55:47 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id 1sm3868599wre.61.2020.10.20.07.55.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2020 07:55:46 -0700 (PDT) Subject: Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings To: Mark Brown , Cheng-yi Chiang References: <20200914080619.4178587-1-cychiang@chromium.org> <20200914080619.4178587-3-cychiang@chromium.org> <7bdc0d63-27b1-f99e-c5f8-65f880733d16@linaro.org> <20201015161251.GF4390@sirena.org.uk> <20201020143711.GC9448@sirena.org.uk> From: Srinivas Kandagatla Message-ID: <63f1a29c-0758-97b8-ce80-fe43d91630fa@linaro.org> Date: Tue, 20 Oct 2020 15:55:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20201020143711.GC9448@sirena.org.uk> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201020_105550_188712_A18F269C X-CRM114-Status: GOOD ( 22.18 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Taniya Das , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Banajit Goswami , Heiko Stuebner , Kuninori Morimoto , Takashi Iwai , Rohit kumar , Ajye Huang , Patrick Lai , "open list:ARM/Rockchip SoC..." , Andy Gross , Dylan Reid , Jaroslav Kysela , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Tzung-Bi Shih , Srinivasa Rao , Stephan Gerhold , linux-arm-msm , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Bjorn Andersson , Linux ARM , Doug Anderson , Liam Girdwood , linux-kernel Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 20/10/2020 15:37, Mark Brown wrote: > I don't understand what "logic scattered in various dtsi files" means, > sorry. > >> Yes, that should work to describe the dailink we are using. >> But a more tricky issue is how to do calls like setting PLL in dai startup ops. > ... > >> I think that asking a generic machine driver to do configuration like >> this with only a limited interface of device property >> might be too much of an ask for the machine driver. > Richard was looking at some basic configuration for PLLs. > >> Would you mind if I simplify the compatible string like Srinivas >> suggested, and send a v12? >> As for other two kinds of variations that I am aware of: >> 1. front mic / rear mic >> 2. replace alc5682 with adau7002 > The CODEC change is going to be described in the DT no matter what - > you'll have a reference to the CODEC node but it may make sense if > there's enough custom code around it. For front vs rear mic the > simplest thing would just be to not mention which if this is a hardware > fixed thing, otherwise a control. > >> We can set different board names and different compatible strings to >> achieve such variation. >> So that it would make sense to describe configuration in compatible >> strings like you suggested, and also provides UCM a way to distinguish >> different boards. > I don't recall having suggested distinguishing these things with a > compatible string, especially not the microphones. UCM can already use > the display names for the boards to distinguish things. Not with the compatible string! Currently card name, and long name are exactly same in all Qualcomm soundcards, which makes it very difficult to identify how those boards re wired up at UCM2 level. So the plan is to properly populate card long name with "model" property which can include details on how things are wiredup on that board. --srini _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1865BC4363A for ; Tue, 20 Oct 2020 14:57:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89545206DB for ; Tue, 20 Oct 2020 14:57:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oGYKSdZg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cK9G7+OH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89545206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qa47ZDYVda8X5fZ+1RSP0X6kq6CI9vTy5s3nFNCALDo=; b=oGYKSdZg8K8P2rWapsjLl2ndW AHsK86klNGfSVF7u/bhJLdLuiG/6Uk7Kk5FnWbWcXCj8zjm1jwnUQBdPe4IVIpXOP5/f5J6f9raFB 9TBaRmS731HcejscQie0gbi04g83ilIgCJ8VQqkJ5A7RZWDnt2IyHBJXwl37FgnV5eK8w5Oa8v8Cw BEk0pJMMbXmfh4ywhwgzf1TxtTzKsnQtdwmAgoCE3MvoDhO8B9jQBsTQeWazTwa4BHve55gnOP3f5 5lgF9qHmSVRpyI3m774OzIWu4d+n9gPGFq6XDdw3dqpjppnDUTgoGrqgch9IrsPUZtOvhepyYdtw0 lzT6mk0Mg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUt3L-0001mc-01; Tue, 20 Oct 2020 14:55:55 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUt3G-0001kX-A8 for linux-arm-kernel@lists.infradead.org; Tue, 20 Oct 2020 14:55:52 +0000 Received: by mail-wm1-x341.google.com with SMTP id d81so2106007wmc.1 for ; Tue, 20 Oct 2020 07:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uf/L+N0SXiT5GxWzSMpW76s8MjBMaRe3gnVIlCSIR5M=; b=cK9G7+OH/TUQCyR8rfJv0QoQ3SjEQsnF9XCjVN6xqr/O8yU3IlDfbvmsbTfkhxQ06f q4IpVZ8VlQ3fVXlWWHGSfLpylD2IH5P4NE25315km3BTplz4wROeM/cLeRnrZhnHb/v5 PyAaPitLsRWmdVTipbLqX4Out+F21VmQJ/X09y763klLznhk8Wjph5Dm6ltToTwu1GKi 6cF9SRXzSOe+CnDRgo2LkN4n5tkvfZ7EpQsA7EkHbGt3NkoE1mD/PmAfdxkXt8UbFE9X RN1mqjge119zJMoJpTqXMa+rN2apg4iQxVK+dpL4RLHKRIlCnNkTt3EAvl5wmXLl4Uz1 eT1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uf/L+N0SXiT5GxWzSMpW76s8MjBMaRe3gnVIlCSIR5M=; b=XtDmul8MyUvykPdPSIjCwuiV++JSrDJbeBNL2u+mfpIV4qScPd3D8b75cB1P5dH7Ny +ed/IojZJmlxwVHEJR5o3JjoZD3KCgXG01CuO01DwY/6ZDCauKRVqgtFphrdAeXrdShH gF4Xj/A+2v8su8JkmXd5DXwXB0BpIgOZiuZhcsIY0k7c6/H2tmfIffzxD8IJStJwPcAX hT+KrD76hu4bx9kEnSQKNSb/TiadyteZyzyx5XV0yAnd143fCQcjZEXY82+JvtkGFDR3 K9N1HO/wO5rT4SLbkFEFHhB4tcjOJ8BaHSoDoYrBk89bT8/9qZUNMsBg1sM3ShtScLJA O46g== X-Gm-Message-State: AOAM533S/CX87tH37ygL/I+c/LDAcXRLagKKgwJZba9AhNpnggGrR6Rk AZzFaSUx2cjg0jeB7UCbi0Fmbw== X-Google-Smtp-Source: ABdhPJwZTIfXIjPLWWjL97y1NfJTXN0Y2s/to/X10G0kOS41vqvGeaVeSXPhf5OZA0t9DHJLkiPgNg== X-Received: by 2002:a7b:ce8f:: with SMTP id q15mr3351776wmj.88.1603205747699; Tue, 20 Oct 2020 07:55:47 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id 1sm3868599wre.61.2020.10.20.07.55.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2020 07:55:46 -0700 (PDT) Subject: Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings To: Mark Brown , Cheng-yi Chiang References: <20200914080619.4178587-1-cychiang@chromium.org> <20200914080619.4178587-3-cychiang@chromium.org> <7bdc0d63-27b1-f99e-c5f8-65f880733d16@linaro.org> <20201015161251.GF4390@sirena.org.uk> <20201020143711.GC9448@sirena.org.uk> From: Srinivas Kandagatla Message-ID: <63f1a29c-0758-97b8-ce80-fe43d91630fa@linaro.org> Date: Tue, 20 Oct 2020 15:55:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20201020143711.GC9448@sirena.org.uk> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201020_105550_375738_08341C11 X-CRM114-Status: GOOD ( 23.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Taniya Das , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Banajit Goswami , Heiko Stuebner , Kuninori Morimoto , Takashi Iwai , Rohit kumar , Ajye Huang , Patrick Lai , "open list:ARM/Rockchip SoC..." , Andy Gross , Dylan Reid , Jaroslav Kysela , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Tzung-Bi Shih , Srinivasa Rao , Stephan Gerhold , linux-arm-msm , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Bjorn Andersson , Linux ARM , Doug Anderson , Liam Girdwood , linux-kernel Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/10/2020 15:37, Mark Brown wrote: > I don't understand what "logic scattered in various dtsi files" means, > sorry. > >> Yes, that should work to describe the dailink we are using. >> But a more tricky issue is how to do calls like setting PLL in dai startup ops. > ... > >> I think that asking a generic machine driver to do configuration like >> this with only a limited interface of device property >> might be too much of an ask for the machine driver. > Richard was looking at some basic configuration for PLLs. > >> Would you mind if I simplify the compatible string like Srinivas >> suggested, and send a v12? >> As for other two kinds of variations that I am aware of: >> 1. front mic / rear mic >> 2. replace alc5682 with adau7002 > The CODEC change is going to be described in the DT no matter what - > you'll have a reference to the CODEC node but it may make sense if > there's enough custom code around it. For front vs rear mic the > simplest thing would just be to not mention which if this is a hardware > fixed thing, otherwise a control. > >> We can set different board names and different compatible strings to >> achieve such variation. >> So that it would make sense to describe configuration in compatible >> strings like you suggested, and also provides UCM a way to distinguish >> different boards. > I don't recall having suggested distinguishing these things with a > compatible string, especially not the microphones. UCM can already use > the display names for the boards to distinguish things. Not with the compatible string! Currently card name, and long name are exactly same in all Qualcomm soundcards, which makes it very difficult to identify how those boards re wired up at UCM2 level. So the plan is to properly populate card long name with "model" property which can include details on how things are wiredup on that board. --srini _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel