From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v7 5/6] perf report: support time percent and multiple time ranges
Date: Tue, 9 Jan 2018 10:02:32 +0800 [thread overview]
Message-ID: <63f2abf4-9a3e-a655-dbb7-301ad42a78f3@linux.intel.com> (raw)
In-Reply-To: <20180108150451.GH25476@kernel.org>
On 1/8/2018 11:04 PM, Arnaldo Carvalho de Melo wrote:
> One more thing to consider:
>
> When you use:
>
> perf report --time 10%/1
>
> it will do what is asked but there is no indication of what percentage
> ranges are in place, it would be nice to have this in the first line in
> the TUI, right after this:
>
> Samples: 128 of event 'cycles:ppp', Event count (approx.): 21386169 (10%/1)
>
> - Arnaldo
>
Hi Arnaldo,
Thanks for merging this feature and thanks so much for providing
comments for how to improve this feature in next step.
Please let me summarize what the follow-up patch needs to do:
1. Improve the error message, something like:
"HINT: use 'perf record --foobar' to record the first/last sample
timestamps in the perf.data file header or enable build-id processing."
2. Currently it uses magic number 10 to limit the number of time slices.
But it's not good. The best thing would be to have no such limitations,
i.e. to lift this limitation from the code and docs.
3. 'perf report --time 10%' should be equivalent to 'perf report --time
10%/1'. Or at least say something like:
"percent slices need an index to specify which one is wanted" when
you notice a % in the --time string, etc.
4. Add an indication of what percentage ranges are being used. For example,
Samples: 128 of event 'cycles:ppp', Event count (approx.): 21386169 (10%/1)
I will develop a follow-up patchset to improve this feature.
Thanks
Jin Yao
next prev parent reply other threads:[~2018-01-09 2:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 13:13 [PATCH v7 0/6] perf report/script: Support percent and multiple range in --time option Jin Yao
2017-12-08 13:13 ` [PATCH v7 1/6] perf header: Record first sample time and last sample time in perf file header Jin Yao
2018-01-11 6:21 ` [tip:perf/core] perf header: Add infrastructure to record first and last sample time tip-bot for Jin Yao
2017-12-08 13:13 ` [PATCH v7 2/6] perf record: Get the first sample time " Jin Yao
2018-01-04 19:09 ` Arnaldo Carvalho de Melo
2018-01-05 1:15 ` Jin, Yao
2018-01-05 12:53 ` Arnaldo Carvalho de Melo
2018-01-05 22:55 ` Jin, Yao
2018-01-11 6:22 ` [tip:perf/core] perf record: Record the first and last sample time in the header tip-bot for Jin Yao
2017-12-08 13:13 ` [PATCH v7 3/6] perf util: Create function to parse time percent Jin Yao
2018-01-08 14:31 ` Arnaldo Carvalho de Melo
2018-01-08 14:38 ` Arnaldo Carvalho de Melo
2018-01-09 1:18 ` Jin, Yao
2018-01-11 6:22 ` [tip:perf/core] perf tools: " tip-bot for Jin Yao
2017-12-08 13:13 ` [PATCH v7 4/6] perf util: Create function to perform multiple time range checking Jin Yao
2018-01-11 6:22 ` [tip:perf/core] perf tools: " tip-bot for Jin Yao
2017-12-08 13:13 ` [PATCH v7 5/6] perf report: support time percent and multiple time ranges Jin Yao
2018-01-08 14:45 ` Arnaldo Carvalho de Melo
2018-01-08 14:48 ` Arnaldo Carvalho de Melo
2018-01-08 14:53 ` Arnaldo Carvalho de Melo
2018-01-08 15:02 ` Arnaldo Carvalho de Melo
2018-01-08 15:04 ` Arnaldo Carvalho de Melo
2018-01-09 2:02 ` Jin, Yao [this message]
2018-01-11 6:23 ` [tip:perf/core] perf report: Support " tip-bot for Jin Yao
2017-12-08 13:13 ` [PATCH v7 6/6] perf script: support " Jin Yao
2018-01-11 6:23 ` [tip:perf/core] perf script: Support " tip-bot for Jin Yao
2017-12-13 14:28 ` [PATCH v7 0/6] perf report/script: Support percent and multiple range in --time option Arnaldo Carvalho de Melo
2017-12-14 0:48 ` Jin, Yao
2017-12-14 14:08 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63f2abf4-9a3e-a655-dbb7-301ad42a78f3@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.