From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD6E8C0502C for ; Thu, 1 Sep 2022 13:43:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233829AbiIANnK (ORCPT ); Thu, 1 Sep 2022 09:43:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234133AbiIANmq (ORCPT ); Thu, 1 Sep 2022 09:42:46 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1000586041; Thu, 1 Sep 2022 06:42:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662039721; x=1693575721; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=+lQKwXNZpAuQINVUmfj0tEtA/2ipPtcHfyLg00xvWMk=; b=QOi018ZCl2QTywhk5uQQ4n7B5CRnq3i9M/k1naMfs4SAs2SU8isFaez+ iZz8DBiJCqPV6fJXWvBN6hHDXOCpRgsdPxL8rGAj5R5s6ZdjwFD1lYl+F oXztNCM/lP2CtMvFFkKrg/hDxGRG8KvsWjPDAQMFqMJMCzdZmllmsWWvN 37RWHr3+jqYYn4oGxQLOlxg4QP4FRBGHFvTGnS6pknljsX6tRceCBX9Re h0Ruo4kfNXlzG894buUyH3UkLLI2hxuiBs+SdiyNKjVgKuhWtY6prNF04 qrNQiT54cxJ3buOqH9+UgWtnZm5qyzdVtyZLw+LXXeIr2rx0QRR3HHpQn w==; X-IronPort-AV: E=McAfee;i="6500,9779,10457"; a="296500268" X-IronPort-AV: E=Sophos;i="5.93,280,1654585200"; d="scan'208";a="296500268" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2022 06:41:59 -0700 X-IronPort-AV: E=Sophos;i="5.93,280,1654585200"; d="scan'208";a="673852409" Received: from rmalliu-mobl.amr.corp.intel.com ([10.249.44.65]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2022 06:41:54 -0700 Date: Thu, 1 Sep 2022 16:41:48 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Kumaravel.Thiagarajan@microchip.com cc: andy.shevchenko@gmail.com, Greg Kroah-Hartman , Jiri Slaby , u.kleine-koenig@pengutronix.de, johan@kernel.org, wander@redhat.com, etremblay@distech-controls.com, macro@orcam.me.uk, geert+renesas@glider.be, jk@ozlabs.org, phil.edworthy@renesas.com, Lukas Wunner , LKML , linux-serial , UNGLinuxDriver@microchip.com Subject: RE: [PATCH v1 tty-next 1/2] 8250: microchip: pci1xxxx: Add driver for the quad-uart function in the multi-function endpoint of pci1xxxx device. In-Reply-To: Message-ID: <63f48d1-f716-5040-c8d1-486087bd1c5e@linux.intel.com> References: <20220830180054.1998296-1-kumaravel.thiagarajan@microchip.com> <20220830180054.1998296-2-kumaravel.thiagarajan@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Sep 2022, Kumaravel.Thiagarajan@microchip.com wrote: > > > + const unsigned int standard_baud_list[] = {50, 75, 110, 134, 150, 300, > > > + 600, 1200, 1800, 2000, 2400, 3600, > > > + 4800, 7200, 9600, 19200, 38400, 57600, > > > + 115200, 125000, 136400, 150000, 166700, > > > + 187500, 214300, 250000, 300000, 375000, > > > + 500000, 750000, > > > + 1000000, 1500000}; > > > > Why?! > > The standard baud rates are handled within serial8250_do_set_termios > which is invoked from within mchp_pci1xxxx_set_termios in first place. > Hence if it matches with any of the standard baudrates, > it can return immediately. Care to explain why the baudrates in your table don't match those in tty_baudrate.c? ...It makes no sense to me that you call these "standard baud rates". -- i.