From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hoegeun Kwon Subject: Re: [PATCH 2/3] drm/panel: S6E3HA2 needs backlight code Date: Thu, 20 Apr 2017 10:34:29 +0900 Message-ID: <64032ac6-4985-b415-4c38-a392cd2b0a73@samsung.com> References: <20170419175939.189098-1-arnd@arndb.de> <20170419175939.189098-2-arnd@arndb.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1103121347==" Return-path: Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1349C8915E for ; Thu, 20 Apr 2017 01:34:28 +0000 (UTC) Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by mailout4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OOO00MJ5PPD78C0@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 20 Apr 2017 10:34:26 +0900 (KST) In-reply-to: <20170419175939.189098-2-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arnd Bergmann , Thierry Reding , David Airlie Cc: Vinay Simha BN , Laurent Pinchart , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Hoegeun Kwon List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --===============1103121347== Content-type: multipart/alternative; boundary=------------7683D7F9E209D429652D297A This is a multi-part message in MIME format. --------------7683D7F9E209D429652D297A Content-Type: text/plain; charset="windows-1252"; format="flowed" Content-Transfer-Encoding: 7bit Hi Arnd, Thanks for your patch. On 04/20/2017 02:59 AM, Arnd Bergmann wrote: > The new S6E3HA2 driver fails to link when backlight is disabled: > > ERROR: "backlight_device_register" [drivers/gpu/drm/panel/panel-samsung-s6e3ha2.ko] undefined! > ERROR: "backlight_device_unregister" [drivers/gpu/drm/panel/panel-samsung-s6e3ha2.ko] undefined! > > This adds a Kconfig dependency like we have it for some other panel drivers. > > Fixes: ed29f9426d9b ("drm/panel: Add support for S6E3HA2 panel driver on TM2 board") > Signed-off-by: Arnd Bergmann Reviewed-by: Hoegeun Kwon Best regards, Hoegeun --------------7683D7F9E209D429652D297A Content-Type: text/html; charset="windows-1252" Content-Transfer-Encoding: 7bit Hi Arnd,

Thanks for your patch.

On 04/20/2017 02:59 AM, Arnd Bergmann wrote:
The new S6E3HA2 driver fails to link when backlight is disabled:

ERROR: "backlight_device_register" [drivers/gpu/drm/panel/panel-samsung-s6e3ha2.ko] undefined!
ERROR: "backlight_device_unregister" [drivers/gpu/drm/panel/panel-samsung-s6e3ha2.ko] undefined!

This adds a Kconfig dependency like we have it for some other panel drivers.

Fixes: ed29f9426d9b ("drm/panel: Add support for S6E3HA2 panel driver on TM2 board")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>

Best regards,
Hoegeun

--------------7683D7F9E209D429652D297A-- --===============1103121347== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1103121347==--