From: Florian Fainelli <f.fainelli@gmail.com>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: davem@davemloft.net, zambrano@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] b44: add calls to phy_{start,stop}
Date: Sun, 02 Mar 2014 10:53:10 -0800 [thread overview]
Message-ID: <6403851.S1rVbK2KGG@lenovo> (raw)
In-Reply-To: <1393777774-7400-1-git-send-email-hauke@hauke-m.de>
Le dimanche 2 mars 2014, 17:29:33 Hauke Mehrtens a écrit :
> When support for external phys was added to b44, the calls to start and
> stop the phy were missing in the mac driver. This adds the calls to
> phy_start() and phy_stop().
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/net/ethernet/broadcom/b44.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/ethernet/broadcom/b44.c
> b/drivers/net/ethernet/broadcom/b44.c index 1f7b5aa..e8046e1 100644
> --- a/drivers/net/ethernet/broadcom/b44.c
> +++ b/drivers/net/ethernet/broadcom/b44.c
> @@ -1484,6 +1484,10 @@ static int b44_open(struct net_device *dev)
> add_timer(&bp->timer);
>
> b44_enable_ints(bp);
> +
> + if (bp->flags & B44_FLAG_EXTERNAL_PHY)
> + phy_start(bp->phydev);
> +
> netif_start_queue(dev);
> out:
> return err;
> @@ -1646,6 +1650,9 @@ static int b44_close(struct net_device *dev)
>
> netif_stop_queue(dev);
>
> + if (bp->flags & B44_FLAG_EXTERNAL_PHY)
> + phy_stop(bp->phydev);
> +
> napi_disable(&bp->napi);
>
> del_timer_sync(&bp->timer);
--
Florian
next prev parent reply other threads:[~2014-03-02 18:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 16:29 [PATCH 1/2] b44: add calls to phy_{start,stop} Hauke Mehrtens
2014-03-02 16:29 ` [PATCH 2/2] b44: always set duplex mode why phy changes Hauke Mehrtens
2014-03-02 18:53 ` Florian Fainelli
2014-03-03 0:06 ` David Miller
2014-03-02 18:53 ` Florian Fainelli [this message]
2014-03-03 0:05 ` [PATCH 1/2] b44: add calls to phy_{start,stop} David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6403851.S1rVbK2KGG@lenovo \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=hauke@hauke-m.de \
--cc=netdev@vger.kernel.org \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.