From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BD17C433E1 for ; Tue, 26 May 2020 02:27:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6328B207CB for ; Tue, 26 May 2020 02:27:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=massaru-org.20150623.gappssmtp.com header.i=@massaru-org.20150623.gappssmtp.com header.b="YofJeHnd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388499AbgEZC1J (ORCPT ); Mon, 25 May 2020 22:27:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388469AbgEZC1G (ORCPT ); Mon, 25 May 2020 22:27:06 -0400 Received: from mail-qv1-xf43.google.com (mail-qv1-xf43.google.com [IPv6:2607:f8b0:4864:20::f43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33930C061A0E for ; Mon, 25 May 2020 19:27:05 -0700 (PDT) Received: by mail-qv1-xf43.google.com with SMTP id fb16so8825367qvb.5 for ; Mon, 25 May 2020 19:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=massaru-org.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=kKvMAjzc/mEVTpZO8ep+V3zBScPaHmRXXweb2vJv3c8=; b=YofJeHnd5o7d5GTI0OypeNRdeu1ysq06NK8fGtCfoqf2KIQMXQGY26AXERewokEcjL MJBHsjTp5z2X5GNsib9ioA1rDrpCTQVSSaECiaR+lAIsyvGWWUxYaFDdJVwBZLQxyk4U /6OcMbI5aTRG6FplB+K8V1hh+HCtp1kH8NX6uuV/o/oMzrmET4XxIzhTwPNmK/SNFnoN Z0gWhM7pheDTr0BXFpX9Bs6SLWwmlvNz+pife1jxnpVI7icDP9iL6FjavwOsSaPaMQj3 h3hVsvcs4Q5uxmrCzwIA8EQabb+9i+gj6J7ZU9jivDR7/FabYirEjJ/CfSFzFio+9C5c uY2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=kKvMAjzc/mEVTpZO8ep+V3zBScPaHmRXXweb2vJv3c8=; b=gLr7wsb6MaCUkqsqUuDFpzSFQ8pgpGTOW+DGsnEKPyX+r3jqjWkERLYxCWkosmK1v8 aOck96GhTFMTdFeqVGQcHx0AA5nsmSIwrwzN4i1nOXKANK5/mPLj0fvh9GEILcr7g0qW 5UAZ8F3ckenUwTPq2yo3lJ0DWxhvhq4vPgwjbllCrK0vFie9mABqoM5YIFztRbQeR9yn OLKYm/NlZTgjNzwbB3OsiQ9Siw2mcUrk+DNg1nuDhENsfUH2bsiV24PjsfRq2WW4GJ5i rA26tWu2Dyhj2H54a4Ja0BUnzTv4I2mmNiSicFJDZ7bVCym9WmuknsA9z6ZUHQyzwlep eCrQ== X-Gm-Message-State: AOAM5307ncPeBJDmpj0zik5aA7VZY4PjbgB/NY42WWWZHNOOOdHS06fG Y2s8QvpDOKxIRAJI/KlA4ppyQQ== X-Google-Smtp-Source: ABdhPJzBt+Vgk2wXJ8UAQjptPRf86v1VsR74Foleh0D4S5xZtJUZ0VsVSMKeEBXoY0/loY/P8Yhh3g== X-Received: by 2002:a0c:fc4e:: with SMTP id w14mr18133773qvp.147.1590460024208; Mon, 25 May 2020 19:27:04 -0700 (PDT) Received: from bbking.lan ([2804:14c:4a5:36c::cd2]) by smtp.gmail.com with ESMTPSA id n7sm15523719qtr.40.2020.05.25.19.27.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2020 19:27:03 -0700 (PDT) Message-ID: <6403abc0c60fcb5069e1cdea0bb7f25b6dc8070f.camel@massaru.org> Subject: Re: [RESEND] kunit: use --build_dir=.kunit as default From: Vitor Massaru Iha To: shuah , Brendan Higgins Cc: KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , Shuah Khan , linux-kernel-mentees@lists.linuxfoundation.org, David Gow Date: Mon, 25 May 2020 23:27:00 -0300 In-Reply-To: References: <20200414230950.83665-1-vitor@massaru.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.2 (3.36.2-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-05-25 at 22:52 -0300, Vitor Massaru Iha wrote: > Hi Shuah, > > On Fri, 2020-05-22 at 16:40 -0600, shuah wrote: > > On 4/16/20 5:11 PM, Brendan Higgins wrote: > > > On Tue, Apr 14, 2020 at 4:09 PM Vitor Massaru Iha < > > > vitor@massaru.org> wrote: > > > > To make KUnit easier to use, and to avoid overwriting object > > > > and > > > > .config files, the default KUnit build directory is set to > > > > .kunit > > > > > > > > * Related bug: > > > > https://bugzilla.kernel.org/show_bug.cgi?id=205221 > > > > > > > > Signed-off-by: Vitor Massaru Iha > > > > > > Reviewed-by: Brendan Higgins > > > > > > > Applied the patch to kselftest/kunit on top of > > > > 45ba7a893ad89114e773b3dc32f6431354c465d6 > > kunit: kunit_tool: Separate out config/build/exec/parse > > > > from David's work resolving merge conflicts. Please check if it is > > sane. > > > > thanks, > > -- Shuah > > The kunit branch had some problems related to identation. KUnit's > code > has mixed identation, and with that, in conflict correction, it ended > up breaking python. > > In addition I found a bug: related to the creation of the > .kunitconfig > file inside the default build directory. This is actually related to the other patch "kunit: use KUnit defconfig by default" > Should I send the patch again? > Or do I make a bugfix patch? > > BR, > Vitor > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E780C433DF for ; Tue, 26 May 2020 02:27:09 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDE9E207CB for ; Tue, 26 May 2020 02:27:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=massaru-org.20150623.gappssmtp.com header.i=@massaru-org.20150623.gappssmtp.com header.b="YofJeHnd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDE9E207CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=massaru.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 74C0185CFE; Tue, 26 May 2020 02:27:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8p3IBb1YFij1; Tue, 26 May 2020 02:27:07 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id DCAD185CA8; Tue, 26 May 2020 02:27:07 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C12C2C0865; Tue, 26 May 2020 02:27:07 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id D66F0C016F for ; Tue, 26 May 2020 02:27:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id BEF34879FF for ; Tue, 26 May 2020 02:27:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4R8Bo+dhdbFe for ; Tue, 26 May 2020 02:27:05 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-qv1-f67.google.com (mail-qv1-f67.google.com [209.85.219.67]) by hemlock.osuosl.org (Postfix) with ESMTPS id 73273877A0 for ; Tue, 26 May 2020 02:27:05 +0000 (UTC) Received: by mail-qv1-f67.google.com with SMTP id v15so8818496qvr.8 for ; Mon, 25 May 2020 19:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=massaru-org.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=kKvMAjzc/mEVTpZO8ep+V3zBScPaHmRXXweb2vJv3c8=; b=YofJeHnd5o7d5GTI0OypeNRdeu1ysq06NK8fGtCfoqf2KIQMXQGY26AXERewokEcjL MJBHsjTp5z2X5GNsib9ioA1rDrpCTQVSSaECiaR+lAIsyvGWWUxYaFDdJVwBZLQxyk4U /6OcMbI5aTRG6FplB+K8V1hh+HCtp1kH8NX6uuV/o/oMzrmET4XxIzhTwPNmK/SNFnoN Z0gWhM7pheDTr0BXFpX9Bs6SLWwmlvNz+pife1jxnpVI7icDP9iL6FjavwOsSaPaMQj3 h3hVsvcs4Q5uxmrCzwIA8EQabb+9i+gj6J7ZU9jivDR7/FabYirEjJ/CfSFzFio+9C5c uY2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=kKvMAjzc/mEVTpZO8ep+V3zBScPaHmRXXweb2vJv3c8=; b=qZ6A97qB9X0hyQEfTepTndEG43bxdCn4guFOzmYiDY+3ZDlPGztnNERecvyzCBhO/t OgvHcOj+tj+LTfA3lNHSLeZ33ft+sJhmyAaHhiIyQt4vkk5afFsvhvOIt3/iAF9SBLX9 eF/5KjsT6C0teXyjol9sms3xM/Ss3TwLnGFUoHPSPmHsKM/tEhqBE+xbitcBIldOiSGv CEl7AbpmOrEqJzlkRBGwv877a54boBpEnOzLwUzlrLzelBVFessQl3kROo8Bmp042jM2 Z5enXYRkw8eGrUTaROSsLaOOAIWg1Jr/GSMIPFLqFUE8l43nTz2So9rk7HubAckkLd0L VUBQ== X-Gm-Message-State: AOAM531D5q4Ndrpw2f6UmQGk4tL4TaSLxhSit/gJJf748JM9XXGtiuyz ItrQ8r7eri0hoLTWWi0QXSqD7A== X-Google-Smtp-Source: ABdhPJzBt+Vgk2wXJ8UAQjptPRf86v1VsR74Foleh0D4S5xZtJUZ0VsVSMKeEBXoY0/loY/P8Yhh3g== X-Received: by 2002:a0c:fc4e:: with SMTP id w14mr18133773qvp.147.1590460024208; Mon, 25 May 2020 19:27:04 -0700 (PDT) Received: from bbking.lan ([2804:14c:4a5:36c::cd2]) by smtp.gmail.com with ESMTPSA id n7sm15523719qtr.40.2020.05.25.19.27.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2020 19:27:03 -0700 (PDT) Message-ID: <6403abc0c60fcb5069e1cdea0bb7f25b6dc8070f.camel@massaru.org> From: Vitor Massaru Iha To: shuah , Brendan Higgins Date: Mon, 25 May 2020 23:27:00 -0300 In-Reply-To: References: <20200414230950.83665-1-vitor@massaru.org> User-Agent: Evolution 3.36.2 (3.36.2-1.fc32) MIME-Version: 1.0 Cc: "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , David Gow , linux-kernel-mentees@lists.linuxfoundation.org, KUnit Development Subject: Re: [Linux-kernel-mentees] [RESEND] kunit: use --build_dir=.kunit as default X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Mon, 2020-05-25 at 22:52 -0300, Vitor Massaru Iha wrote: > Hi Shuah, > > On Fri, 2020-05-22 at 16:40 -0600, shuah wrote: > > On 4/16/20 5:11 PM, Brendan Higgins wrote: > > > On Tue, Apr 14, 2020 at 4:09 PM Vitor Massaru Iha < > > > vitor@massaru.org> wrote: > > > > To make KUnit easier to use, and to avoid overwriting object > > > > and > > > > .config files, the default KUnit build directory is set to > > > > .kunit > > > > > > > > * Related bug: > > > > https://bugzilla.kernel.org/show_bug.cgi?id=205221 > > > > > > > > Signed-off-by: Vitor Massaru Iha > > > > > > Reviewed-by: Brendan Higgins > > > > > > > Applied the patch to kselftest/kunit on top of > > > > 45ba7a893ad89114e773b3dc32f6431354c465d6 > > kunit: kunit_tool: Separate out config/build/exec/parse > > > > from David's work resolving merge conflicts. Please check if it is > > sane. > > > > thanks, > > -- Shuah > > The kunit branch had some problems related to identation. KUnit's > code > has mixed identation, and with that, in conflict correction, it ended > up breaking python. > > In addition I found a bug: related to the creation of the > .kunitconfig > file inside the default build directory. This is actually related to the other patch "kunit: use KUnit defconfig by default" > Should I send the patch again? > Or do I make a bugfix patch? > > BR, > Vitor > _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees