From: Christian Lindig <christian.lindig@citrix.com>
To: Igor Druzhinin <igor.druzhinin@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Ian Jackson" <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
George Dunlap <George.Dunlap@citrix.com>,
"Jan Beulich" <jbeulich@suse.com>,
"julien@xen.org" <julien@xen.org>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
"jgross@suse.com" <jgross@suse.com>,
"dave@recoil.org" <dave@recoil.org>
Subject: Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission
Date: Wed, 7 Jul 2021 08:48:40 +0000 [thread overview]
Message-ID: <640E969C-62AA-44C8-9CA6-F393E7038E0E@citrix.com> (raw)
In-Reply-To: <1625619764-23537-1-git-send-email-igor.druzhinin@citrix.com>
[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]
On 7 Jul 2021, at 02:02, Igor Druzhinin <igor.druzhinin@citrix.com<mailto:igor.druzhinin@citrix.com>> wrote:
Current unit8_t for pirq argument in this interface is too restrictive
causing failures on modern hardware with lots of GSIs. That extends down to
XEN_DOMCTL_irq_permission ABI structure where it needs to be fixed up
as well. Internal Xen structures appear to be fine. Existing users of
the interface in tree (libxl, ocaml and python bindings) are already using
int for pirq representation that should be wide enough.
Domctl interface version is needed to be bumped with this change but that
was already done by 918b8842a8 ("arm64: Change type of hsr, cpsr, spsr_el1
to uint64_t") in this release cycle.
Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com<mailto:igor.druzhinin@citrix.com>>
---
tools/include/xenctrl.h | 2 +-
tools/libs/ctrl/xc_domain.c | 2 +-
tools/ocaml/libs/xc/xenctrl_stubs.c | 2 +-
xen/include/public/domctl.h | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
Acked-by: Christian Lindig <christian.lindig@citrix.com<mailto:christian.lindig@citrix.com>>
[-- Attachment #2: Type: text/html, Size: 2554 bytes --]
next prev parent reply other threads:[~2021-07-07 8:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 1:02 [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission Igor Druzhinin
2021-07-07 7:46 ` Jan Beulich
2021-07-07 9:19 ` Andrew Cooper
2021-07-08 1:08 ` Igor Druzhinin
2021-07-08 1:11 ` Andrew Cooper
2021-07-08 1:14 ` Igor Druzhinin
2021-07-08 1:26 ` Andrew Cooper
2021-07-08 1:30 ` Igor Druzhinin
2021-07-07 8:48 ` Christian Lindig [this message]
2021-07-07 12:51 ` Julien Grall
2021-07-07 12:54 ` Jan Beulich
2021-07-07 12:59 ` Julien Grall
2021-07-07 13:14 ` Jan Beulich
2021-07-07 13:21 ` Julien Grall
2021-07-07 13:25 ` Jan Beulich
2021-07-08 2:06 ` Igor Druzhinin
2021-07-12 8:59 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=640E969C-62AA-44C8-9CA6-F393E7038E0E@citrix.com \
--to=christian.lindig@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=George.Dunlap@citrix.com \
--cc=dave@recoil.org \
--cc=igor.druzhinin@citrix.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.