From: Florian Fainelli <f.fainelli@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>,
stable@vger.kernel.org
Subject: Re: [PATCH net 2/2] net: dsa: b53: Set correct number of ports in the DSA struct
Date: Wed, 1 Sep 2021 18:38:47 -0700 [thread overview]
Message-ID: <6411c7dd-79b4-3659-020b-aaa929447d50@gmail.com> (raw)
In-Reply-To: <20210901163657.74f39079@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 9/1/2021 4:36 PM, Jakub Kicinski wrote:
> On Wed, 1 Sep 2021 10:21:55 -0700 Florian Fainelli wrote:
>> On 9/1/2021 2:21 AM, Rafał Miłecki wrote:
>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>
>>> Setting DSA_MAX_PORTS caused DSA to call b53 callbacks (e.g.
>>> b53_disable_port() during dsa_register_switch()) for invalid
>>> (non-existent) ports. That made b53 modify unrelated registers and is
>>> one of reasons for a broken BCM5301x support.
>>>
>>> This problem exists for years but DSA_MAX_PORTS usage has changed few
>>> times so it's hard to specify a single commit this change fixes.
>>
>> You should still try to identify the relevant tags that this is fixing
>> such that this gets back ported to the appropriate trees. We could use
>> Fixes: 7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper"), to
>> minimize the amount of work doing the back port.
>
> To be clear are you okay with the fixes tag you provided or should we
> wait for Rafał to double check?
That Fixes tag is correct and won't cause conflicts AFAICT with
backports all the way down to that commit.
--
Florian
next prev parent reply other threads:[~2021-09-02 1:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 9:21 [PATCH net 1/2] net: dsa: b53: Fix calculating number of switch ports Rafał Miłecki
2021-09-01 9:21 ` [PATCH net 2/2] net: dsa: b53: Set correct number of ports in the DSA struct Rafał Miłecki
2021-09-01 17:21 ` Florian Fainelli
2021-09-01 23:36 ` Jakub Kicinski
2021-09-02 1:38 ` Florian Fainelli [this message]
2021-09-01 17:16 ` [PATCH net 1/2] net: dsa: b53: Fix calculating number of switch ports Florian Fainelli
2021-09-02 8:30 ` [PATCH V2 " Rafał Miłecki
2021-09-02 8:30 ` [PATCH V2 net 2/2] net: dsa: b53: Set correct number of ports in the DSA struct Rafał Miłecki
2021-09-02 12:40 ` [PATCH V2 net 1/2] net: dsa: b53: Fix calculating number of switch ports patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6411c7dd-79b4-3659-020b-aaa929447d50@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rafal@milecki.pl \
--cc=stable@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.