Re: Warn on macros with flow control statements

From: Ira Weiny <ira.weiny@intel.com>
To: Julia Lawall <julia.lawall@inria.fr>, Ira Weiny <ira.weiny@intel.com>
Cc: Sumitra Sharma <sumitraartsy@gmail.com>, <outreachy@lists.linux.dev>
Subject: Re: Warn on macros with flow control statements
Date: Fri, 17 Mar 2023 23:19:12 -0700	[thread overview]
Message-ID: <641557e06a958_28dc5f294d7@iweiny-mobl.notmuch> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2303180703470.3122@hadrien>

Julia Lawall wrote:
> > Based on the flow control I would do something like this.  It is a bit more
> > verbose but is very clear what is happening.
> >
> 
> Ira, what do you think of my suggestion of
> 
> err = err || qlge_fill_seg_(...);
> 
> It would avoid 40 lines of ifs, and would still avoid calling
> qlge_fill_seg_ as soon as there is a failure.  On ther other hand, I don't
> recall this being done elsewhere, so maybe all the ifs would be
> preferable.

Oh sorry.  I miss read your suggestion and I thought it was going to
continue running qlge_fill_seg_() for all the other calls.  I read this
as:

err = err | qlge_fill_seg_(...);

Not sure why.  Just late I guess.

Yes your suggestion would work.  I do think it is a bit odd though.

Ira