From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752986AbbLaOMZ (ORCPT ); Thu, 31 Dec 2015 09:12:25 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:60664 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751724AbbLaOMW (ORCPT ); Thu, 31 Dec 2015 09:12:22 -0500 From: Arnd Bergmann To: Sudip Mukherjee Cc: Bamvor Jian Zhang , y2038@lists.linaro.org, gregkh@linuxfoundation.org, broonie@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl Date: Thu, 31 Dec 2015 15:12:11 +0100 Message-ID: <6416183.AAnzQivnkS@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151231094308.GA3489@sudip-pc> References: <1450346332-31830-1-git-send-email-bamvor.zhangjian@linaro.org> <5683E84A.5000301@linaro.org> <20151231094308.GA3489@sudip-pc> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:h6yxzKAODKnQeYPF0amqMFvXBQY1zN5DfWkfdMJns3FjILzhF1D bG7GSybT7/boA+ojKaBPoPTybcyz9xQtaRYaUYNoDGQf7TSMCwS9+7Mw1CKbMyn/2EM58sF XknklAXV7PkbB3kcoO7Y4BWzfEk1wnctHzDb7+HOlWVLnwwBG47WEciioWliWhKZ04+QrH/ Hj+ohzi75rg+V66O52tTw== X-UI-Out-Filterresults: notjunk:1;V01:K0:Lv9w8bHQE58=:0t0LCHq07Xtn5KdXyTfXWQ I0VtYCYxpMtiWhlxldk8dnEA0v7ZOuWyCNPFCfLFZrEsSg3lAovv7Icnjp92NsK+3uAuasAMJ onH5C/Sm5bOuWYJ8J8jm6J35mjv83dg0rN0FobTZz1awFVRtmd9tbutivSGCQ2fLs/HoC05iy 69otlxIJILECrPqydTXNtDuTNV+6jUCvzBqF28oZUtYsmYONktBNUqx1u4+RqUmxpLG3Qp4Cs e04Z/gy71Z143ike/XLPoExIZ2oz0DHWuTMxLpTJw6roHkyqY0VrQrB0JxJommqy9UKfbvkK+ yROcQ5lgt8ufyE/9XwDvlUroPt0LeyvTYVR9CcOUfpfNESUEMfqXg5dFa2ooVtXRDnH0jUrH5 fdtBy4MfQbvHdWjIYrSPVOSzJG6ooeoaGdPqBvhkDtj3GmPuvz35LyiNCv/QXyNpl9SWvkrGW Nhcppqt0RRsBfrI/Ia7tzK/1pP9GSW/hZPaK6ZJE6xjqnEkXLHgY+k5t3JWfN9jU09HH30C63 nXiFx5mtWGu0WmoTwF3eTQKtGxSUcUiA2FMng59GfJ+wygD/nBg/SNucN0JN1TfJiLVtgAbnI 8HiOv5PdQC8uh3ushsAe1P6fwAknS0CxcyG3+UA9VCh+ricEo5DFsqsP+Dd8t53HxswyQeMzF qKmek9lyG0hg/ISrpKh/hZT6qBYIi6ghvDaJSjBLBmR3D3TbrU4TXZWWfcnMicRCeNr5gXoes d0+8tFHp5RFvrEVK Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 31 December 2015 15:13:08 Sudip Mukherjee wrote: > On Wed, Dec 30, 2015 at 10:20:58PM +0800, Bamvor Jian Zhang wrote: > > On 12/30/2015 09:51 PM, Arnd Bergmann wrote: > > > On Wednesday 30 December 2015 21:24:21 Bamvor Jian Zhang wrote: > > >> diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c > > > This is something that would be caught by running 'make C=1' with 'sparse' > > > on your patch. Can you try that to see if you introduce any other warnings? > > OK. I do not do it before, there is no extra warning after apply the above > > patch. > > > I'm guessing it's fine, but it would be nice to confirm. I also send a lot > > > of patches without running sparse and checkpatch first, but it's generally > > > a good idea. > > Got you. I only do the checkpatch in past. I will do sparse and checkpatch > > in future. > > Usually sparse will be part of the tests that are done by 0day. > Anyway, it worked perfectly in 64bit systems also. Can you please send > your patch v3 with this change.. > Ah, cool, thanks so much for testing. Did you happen to check with both 32-bit and 64-bit user space on a 64-bit kernel? This is one of the things that was not working originally but should work now. Arnd