From: Peter Ujfalusi <peter.ujfalusi@ti.com> To: Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>, Vinod Koul <vkoul@kernel.org>, Janusz Krzysztofik <jmkrzyszt@gmail.com> Cc: dmaengine@vger.kernel.org, alsa-devel@alsa-project.org, Dan Williams <dan.j.williams@intel.com>, linux-kernel@vger.kernel.org Subject: [2/3] dmaengine: omap-dma: make omap_dma_filter_fn private Date: Fri, 8 Mar 2019 16:32:52 +0200 [thread overview] Message-ID: <641ebb44-7278-f298-c03d-8251dcd6c71e@ti.com> (raw) On 07/03/2019 17.16, Arnd Bergmann wrote: > With the audio driver no longer referring to this function, it > can be made private to the dmaengine driver itself, and the > header file removed. Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/dma/ti/omap-dma.c | 3 ++- > include/linux/omap-dma.h | 2 -- > include/linux/omap-dmaengine.h | 21 --------------------- > 3 files changed, 2 insertions(+), 24 deletions(-) > delete mode 100644 include/linux/omap-dmaengine.h > > diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c > index a4a931ddf6f6..5bf635ba234d 100644 > --- a/drivers/dma/ti/omap-dma.c > +++ b/drivers/dma/ti/omap-dma.c > @@ -205,6 +205,7 @@ static const unsigned es_bytes[] = { > [CSDP_DATA_TYPE_32] = 4, > }; > > +static bool omap_dma_filter_fn(struct dma_chan *chan, void *param); > static struct of_dma_filter_info omap_dma_info = { > .filter_fn = omap_dma_filter_fn, > }; > @@ -1640,7 +1641,7 @@ static struct platform_driver omap_dma_driver = { > }, > }; > > -bool omap_dma_filter_fn(struct dma_chan *chan, void *param) > +static bool omap_dma_filter_fn(struct dma_chan *chan, void *param) > { > if (chan->device->dev->driver == &omap_dma_driver.driver) { > struct omap_dmadev *od = to_omap_dma_dev(chan->device); > diff --git a/include/linux/omap-dma.h b/include/linux/omap-dma.h > index 840ce551e773..ba3cfbb52312 100644 > --- a/include/linux/omap-dma.h > +++ b/include/linux/omap-dma.h > @@ -1,8 +1,6 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > #ifndef __LINUX_OMAP_DMA_H > #define __LINUX_OMAP_DMA_H > -#include <linux/omap-dmaengine.h> > - > /* > * Legacy OMAP DMA handling defines and functions > * > diff --git a/include/linux/omap-dmaengine.h b/include/linux/omap-dmaengine.h > deleted file mode 100644 > index 8e6906c72e90..000000000000 > --- a/include/linux/omap-dmaengine.h > +++ /dev/null > @@ -1,21 +0,0 @@ > -/* > - * OMAP DMA Engine support > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - */ > -#ifndef __LINUX_OMAP_DMAENGINE_H > -#define __LINUX_OMAP_DMAENGINE_H > - > -struct dma_chan; > - > -#if defined(CONFIG_DMA_OMAP) || (defined(CONFIG_DMA_OMAP_MODULE) && defined(MODULE)) > -bool omap_dma_filter_fn(struct dma_chan *, void *); > -#else > -static inline bool omap_dma_filter_fn(struct dma_chan *c, void *d) > -{ > - return false; > -} > -#endif > -#endif /* __LINUX_OMAP_DMAENGINE_H */ > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
WARNING: multiple messages have this Message-ID
From: Peter Ujfalusi <peter.ujfalusi@ti.com> To: Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>, Vinod Koul <vkoul@kernel.org>, Janusz Krzysztofik <jmkrzyszt@gmail.com> Cc: <dmaengine@vger.kernel.org>, <alsa-devel@alsa-project.org>, Dan Williams <dan.j.williams@intel.com>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 2/3] dmaengine: omap-dma: make omap_dma_filter_fn private Date: Fri, 8 Mar 2019 16:32:52 +0200 [thread overview] Message-ID: <641ebb44-7278-f298-c03d-8251dcd6c71e@ti.com> (raw) In-Reply-To: <20190307151646.1016966-2-arnd@arndb.de> On 07/03/2019 17.16, Arnd Bergmann wrote: > With the audio driver no longer referring to this function, it > can be made private to the dmaengine driver itself, and the > header file removed. Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/dma/ti/omap-dma.c | 3 ++- > include/linux/omap-dma.h | 2 -- > include/linux/omap-dmaengine.h | 21 --------------------- > 3 files changed, 2 insertions(+), 24 deletions(-) > delete mode 100644 include/linux/omap-dmaengine.h > > diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c > index a4a931ddf6f6..5bf635ba234d 100644 > --- a/drivers/dma/ti/omap-dma.c > +++ b/drivers/dma/ti/omap-dma.c > @@ -205,6 +205,7 @@ static const unsigned es_bytes[] = { > [CSDP_DATA_TYPE_32] = 4, > }; > > +static bool omap_dma_filter_fn(struct dma_chan *chan, void *param); > static struct of_dma_filter_info omap_dma_info = { > .filter_fn = omap_dma_filter_fn, > }; > @@ -1640,7 +1641,7 @@ static struct platform_driver omap_dma_driver = { > }, > }; > > -bool omap_dma_filter_fn(struct dma_chan *chan, void *param) > +static bool omap_dma_filter_fn(struct dma_chan *chan, void *param) > { > if (chan->device->dev->driver == &omap_dma_driver.driver) { > struct omap_dmadev *od = to_omap_dma_dev(chan->device); > diff --git a/include/linux/omap-dma.h b/include/linux/omap-dma.h > index 840ce551e773..ba3cfbb52312 100644 > --- a/include/linux/omap-dma.h > +++ b/include/linux/omap-dma.h > @@ -1,8 +1,6 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > #ifndef __LINUX_OMAP_DMA_H > #define __LINUX_OMAP_DMA_H > -#include <linux/omap-dmaengine.h> > - > /* > * Legacy OMAP DMA handling defines and functions > * > diff --git a/include/linux/omap-dmaengine.h b/include/linux/omap-dmaengine.h > deleted file mode 100644 > index 8e6906c72e90..000000000000 > --- a/include/linux/omap-dmaengine.h > +++ /dev/null > @@ -1,21 +0,0 @@ > -/* > - * OMAP DMA Engine support > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - */ > -#ifndef __LINUX_OMAP_DMAENGINE_H > -#define __LINUX_OMAP_DMAENGINE_H > - > -struct dma_chan; > - > -#if defined(CONFIG_DMA_OMAP) || (defined(CONFIG_DMA_OMAP_MODULE) && defined(MODULE)) > -bool omap_dma_filter_fn(struct dma_chan *, void *); > -#else > -static inline bool omap_dma_filter_fn(struct dma_chan *c, void *d) > -{ > - return false; > -} > -#endif > -#endif /* __LINUX_OMAP_DMAENGINE_H */ > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
WARNING: multiple messages have this Message-ID
From: Peter Ujfalusi <peter.ujfalusi@ti.com> To: Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>, Vinod Koul <vkoul@kernel.org>, Janusz Krzysztofik <jmkrzyszt@gmail.com> Cc: dmaengine@vger.kernel.org, alsa-devel@alsa-project.org, Dan Williams <dan.j.williams@intel.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] dmaengine: omap-dma: make omap_dma_filter_fn private Date: Fri, 8 Mar 2019 16:32:52 +0200 [thread overview] Message-ID: <641ebb44-7278-f298-c03d-8251dcd6c71e@ti.com> (raw) In-Reply-To: <20190307151646.1016966-2-arnd@arndb.de> On 07/03/2019 17.16, Arnd Bergmann wrote: > With the audio driver no longer referring to this function, it > can be made private to the dmaengine driver itself, and the > header file removed. Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/dma/ti/omap-dma.c | 3 ++- > include/linux/omap-dma.h | 2 -- > include/linux/omap-dmaengine.h | 21 --------------------- > 3 files changed, 2 insertions(+), 24 deletions(-) > delete mode 100644 include/linux/omap-dmaengine.h > > diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c > index a4a931ddf6f6..5bf635ba234d 100644 > --- a/drivers/dma/ti/omap-dma.c > +++ b/drivers/dma/ti/omap-dma.c > @@ -205,6 +205,7 @@ static const unsigned es_bytes[] = { > [CSDP_DATA_TYPE_32] = 4, > }; > > +static bool omap_dma_filter_fn(struct dma_chan *chan, void *param); > static struct of_dma_filter_info omap_dma_info = { > .filter_fn = omap_dma_filter_fn, > }; > @@ -1640,7 +1641,7 @@ static struct platform_driver omap_dma_driver = { > }, > }; > > -bool omap_dma_filter_fn(struct dma_chan *chan, void *param) > +static bool omap_dma_filter_fn(struct dma_chan *chan, void *param) > { > if (chan->device->dev->driver == &omap_dma_driver.driver) { > struct omap_dmadev *od = to_omap_dma_dev(chan->device); > diff --git a/include/linux/omap-dma.h b/include/linux/omap-dma.h > index 840ce551e773..ba3cfbb52312 100644 > --- a/include/linux/omap-dma.h > +++ b/include/linux/omap-dma.h > @@ -1,8 +1,6 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > #ifndef __LINUX_OMAP_DMA_H > #define __LINUX_OMAP_DMA_H > -#include <linux/omap-dmaengine.h> > - > /* > * Legacy OMAP DMA handling defines and functions > * > diff --git a/include/linux/omap-dmaengine.h b/include/linux/omap-dmaengine.h > deleted file mode 100644 > index 8e6906c72e90..000000000000 > --- a/include/linux/omap-dmaengine.h > +++ /dev/null > @@ -1,21 +0,0 @@ > -/* > - * OMAP DMA Engine support > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - */ > -#ifndef __LINUX_OMAP_DMAENGINE_H > -#define __LINUX_OMAP_DMAENGINE_H > - > -struct dma_chan; > - > -#if defined(CONFIG_DMA_OMAP) || (defined(CONFIG_DMA_OMAP_MODULE) && defined(MODULE)) > -bool omap_dma_filter_fn(struct dma_chan *, void *); > -#else > -static inline bool omap_dma_filter_fn(struct dma_chan *c, void *d) > -{ > - return false; > -} > -#endif > -#endif /* __LINUX_OMAP_DMAENGINE_H */ > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next reply other threads:[~2019-03-08 14:32 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-08 14:32 Peter Ujfalusi [this message] 2019-03-08 14:32 ` [PATCH 2/3] " Peter Ujfalusi 2019-03-08 14:32 ` Peter Ujfalusi -- strict thread matches above, loose matches on Subject: below -- 2019-03-25 4:56 [3/3] dmaengine: edma: make edma_filter_fn private Vinod Koul 2019-03-25 4:56 ` [PATCH 3/3] " Vinod Koul 2019-03-25 4:56 [2/3] dmaengine: omap-dma: make omap_dma_filter_fn private Vinod Koul 2019-03-25 4:56 ` [PATCH 2/3] " Vinod Koul 2019-03-08 14:32 [3/3] dmaengine: edma: make edma_filter_fn private Peter Ujfalusi 2019-03-08 14:32 ` [PATCH 3/3] " Peter Ujfalusi 2019-03-08 14:32 ` Peter Ujfalusi 2019-03-07 15:16 [3/3] " Arnd Bergmann 2019-03-07 15:16 ` [PATCH 3/3] " Arnd Bergmann 2019-03-07 15:16 [2/3] dmaengine: omap-dma: make omap_dma_filter_fn private Arnd Bergmann 2019-03-07 15:16 ` [PATCH 2/3] " Arnd Bergmann 2019-03-07 15:16 [1/3] ASoC: ti: remove compat dma probing Arnd Bergmann 2019-03-07 15:16 ` [PATCH 1/3] " Arnd Bergmann 2019-03-11 17:23 ` Applied "ASoC: ti: remove compat dma probing" to the asoc tree Mark Brown 2019-03-11 17:23 ` Mark Brown 2019-03-13 15:38 ` Mark Brown 2019-03-13 15:38 ` Mark Brown 2019-03-14 15:53 ` Mark Brown 2019-03-14 15:53 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=641ebb44-7278-f298-c03d-8251dcd6c71e@ti.com \ --to=peter.ujfalusi@ti.com \ --cc=alsa-devel@alsa-project.org \ --cc=arnd@arndb.de \ --cc=broonie@kernel.org \ --cc=dan.j.williams@intel.com \ --cc=dmaengine@vger.kernel.org \ --cc=jmkrzyszt@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=vkoul@kernel.org \ --subject='Re: [2/3] dmaengine: omap-dma: make omap_dma_filter_fn private' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.